fix(ui): handle SecretInput union in config form analyzer#31866
Merged
steipete merged 2 commits intoopenclaw:mainfrom Mar 2, 2026
Merged
fix(ui): handle SecretInput union in config form analyzer#31866steipete merged 2 commits intoopenclaw:mainfrom
steipete merged 2 commits intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes the config form analyzer incorrectly marking Key Changes:
Impact: Confidence Score: 5/5
Last reviewed commit: ab38274 |
This was referenced Mar 2, 2026
The config form marks models.providers as unsupported because SecretInputSchema creates a oneOf union that the form analyzer cannot handle. Add detection for secret-ref union variants and normalize them to plain string inputs for form display. Closes openclaw#31490
ab38274 to
49f8232
Compare
Contributor
|
Landed via temp rebase onto main.
Thanks @ningding97! |
execute008
pushed a commit
to execute008/openclaw
that referenced
this pull request
Mar 2, 2026
dawi369
pushed a commit
to dawi369/davis
that referenced
this pull request
Mar 3, 2026
OWALabuy
pushed a commit
to kcinzgg/openclaw
that referenced
this pull request
Mar 4, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Config Form view marking
models.providersas unsupported due to SecretInputSchema union.Root Cause
SecretInputSchema creates a
oneOfunion (string | secret-ref object) that the form analyzer cannot handle, causing it to mark the entire providers section as unsupported.Fix
isSecretRefUnion()detection for secret-ref object variantsCloses #31490