Telegram: keep long model callbacks selectable in /models picker#31857
Merged
steipete merged 2 commits intoopenclaw:mainfrom Mar 2, 2026
Merged
Telegram: keep long model callbacks selectable in /models picker#31857steipete merged 2 commits intoopenclaw:mainfrom
steipete merged 2 commits intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR adds a compact callback format ( Key changes:
Implementation quality:
Confidence Score: 5/5
Last reviewed commit: 384410d |
384410d to
a1eda85
Compare
Contributor
|
Landed via temp rebase onto main.
Thanks @bmendonca3! |
dawi369
pushed a commit
to dawi369/davis
that referenced
this pull request
Mar 3, 2026
OWALabuy
pushed a commit
to kcinzgg/openclaw
that referenced
this pull request
Mar 4, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
callback_dataexceeded Telegram's 64-byte limit and those buttons were silently skipped./modelsat all, even though they were configured/allowed.mdl_sel/{model}), parser support for compact callbacks, and callback-handler provider inference when provider is omitted./modeldirective resolution logic, no catalog/allowlist behavior changes, and no changes outside Telegram model-button callback handling.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
/modelsinline picker now keeps long model IDs selectable by using a compact callback format whenprovider/modelexceeds Telegram callback limits./model <provider>/<model>selections when provider inference is unique.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
us.anthropic.claude-3-5-sonnet-20240620-v1:0)agents.defaults.model=bedrock/us.anthropic.claude-3-5-sonnet-20240620-v1:0Steps
main, build Telegram model buttons for provideramazon-bedrockand modelus.anthropic.claude-3-5-sonnet-20240620-v1:0.mdl_sel_amazon-bedrock/us.anthropic.claude-3-5-sonnet-20240620-v1:0exceeds 64 bytes.continue), so model is missing/unselectable in Telegram picker.Expected
Actual
main, making selection impossible via Telegram picker.Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm test -- src/telegram/model-buttons.test.ts src/telegram/bot.test.tspnpm checkpasses.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
384410d02.src/telegram/model-buttons.tssrc/telegram/bot-handlers.tssrc/telegram/model-buttons.test.tssrc/telegram/bot.test.ts/modelsinline selection fails to resolve model callback.Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.