fix(feishu): prevent duplicate delivery when message tool uses generic provider#31538
Merged
Takhoffman merged 2 commits intoopenclaw:mainfrom Mar 2, 2026
Conversation
…ge sends Treat generic message tool providers as the originating channel when checking same-target suppression, and normalize lark->feishu alias during provider comparison. Adds regression tests for generic provider and lark alias paths. Fixes openclaw#31526
Contributor
Greptile SummaryFixed duplicate Feishu reply delivery when message tool uses generic provider or channel alias. The implementation correctly normalizes provider aliases ( Confidence Score: 5/5
Last reviewed commit: 015af4a |
Contributor
|
PR #31538 - fix(feishu): prevent duplicate delivery when message tool uses generic provider (#31538) Merged via squash.
Thanks @jlgrimes! |
18 tasks
hanqizheng
pushed a commit
to hanqizheng/openclaw
that referenced
this pull request
Mar 2, 2026
…c provider (openclaw#31538) thanks @jlgrimes Verified: - pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.ts src/auto-reply/reply/followup-runner.test.ts - pnpm check (fails on unrelated baseline type errors outside PR scope) Co-authored-by: jlgrimes <8084595+jlgrimes@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
obviyus
pushed a commit
that referenced
this pull request
Mar 2, 2026
…c provider (#31538) thanks @jlgrimes Verified: - pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.ts src/auto-reply/reply/followup-runner.test.ts - pnpm check (fails on unrelated baseline type errors outside PR scope) Co-authored-by: jlgrimes <8084595+jlgrimes@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
Linux2010
pushed a commit
to Linux2010/openclaw
that referenced
this pull request
Mar 2, 2026
…c provider (openclaw#31538) thanks @jlgrimes Verified: - pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.ts src/auto-reply/reply/followup-runner.test.ts - pnpm check (fails on unrelated baseline type errors outside PR scope) Co-authored-by: jlgrimes <8084595+jlgrimes@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
execute008
pushed a commit
to execute008/openclaw
that referenced
this pull request
Mar 2, 2026
…c provider (openclaw#31538) thanks @jlgrimes Verified: - pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.ts src/auto-reply/reply/followup-runner.test.ts - pnpm check (fails on unrelated baseline type errors outside PR scope) Co-authored-by: jlgrimes <8084595+jlgrimes@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
dawi369
pushed a commit
to dawi369/davis
that referenced
this pull request
Mar 3, 2026
…c provider (openclaw#31538) thanks @jlgrimes Verified: - pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.ts src/auto-reply/reply/followup-runner.test.ts - pnpm check (fails on unrelated baseline type errors outside PR scope) Co-authored-by: jlgrimes <8084595+jlgrimes@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
OWALabuy
pushed a commit
to kcinzgg/openclaw
that referenced
this pull request
Mar 4, 2026
…c provider (openclaw#31538) thanks @jlgrimes Verified: - pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.ts src/auto-reply/reply/followup-runner.test.ts - pnpm check (fails on unrelated baseline type errors outside PR scope) Co-authored-by: jlgrimes <8084595+jlgrimes@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…c provider (openclaw#31538) thanks @jlgrimes Verified: - pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.ts src/auto-reply/reply/followup-runner.test.ts - pnpm check (fails on unrelated baseline type errors outside PR scope) Co-authored-by: jlgrimes <8084595+jlgrimes@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider: "message"sends as originating-channel sends for suppression checkslark->feishualias in provider comparisons to avoid alias mismatchesChange Type
Scope
Linked Issue/PR
User-visible / Behavior Changes
Feishu users no longer receive duplicate assistant replies when a run includes a same-target message-tool send that defaults to the current channel.
Security Impact
Repro + Verification
Steps
messagesend without explicit channel.Expected (after fix)
Testing
pnpm exec vitest run src/auto-reply/reply/agent-runner-payloads.test.tspnpm exec vitest run src/auto-reply/reply/followup-runner.test.ts