fix(sandbox): allow mkdirp for directories within workspace boundary#31478
Closed
NaturalTensor wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(sandbox): allow mkdirp for directories within workspace boundary#31478NaturalTensor wants to merge 1 commit intoopenclaw:mainfrom
NaturalTensor wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryFixed
Confidence Score: 5/5
Last reviewed commit: c777f4a |
The boundary check treated directories as files during mkdirp, causing false failures. Now uses resolveBoundaryPath for directory operations while still enforcing workspace boundaries. Closes openclaw#31438
Contributor
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix sandbox boundary checks failing on
mkdirpoperations within the workspace.Root Cause
assertPathSafetyused file-open validation (openBoundaryFile) for all operations including directory creation. This treated directories as files and failed with "cannot create directories: /workspace".Fix
allowedType === "directory") now useresolveBoundaryPath()for boundary validation instead ofopenBoundaryFile()Tests
Closes #31438