Skip to content

[AI-assisted] test: fix typing and test fixture issues#31444

Merged
vincentkoc merged 3 commits intoopenclaw:mainfrom
vincentkoc:vincentkoc-code/fix-test-type-errors
Mar 2, 2026
Merged

[AI-assisted] test: fix typing and test fixture issues#31444
vincentkoc merged 3 commits intoopenclaw:mainfrom
vincentkoc:vincentkoc-code/fix-test-type-errors

Conversation

@vincentkoc
Copy link
Member

Summary

  • Fix TypeScript typing errors in test fixtures/helpers across model config, channels, commands, cron, node-host, secrets, and Slack monitor event tests.
  • Adjusted strict object shapes and union-typed test case inputs to align with existing config/event type contracts.
  • Updated mock callback typing and onboarding adapter patch helper typing to avoid structural and readonly mismatches.

Testing

  • Not run (per request, no test execution performed during this pass).

@openclaw-barnacle openclaw-barnacle bot added channel: slack Channel integration: slack commands Command implementations agents Agent runtime and tooling size: S maintainer Maintainer-authored PR labels Mar 2, 2026
@vincentkoc vincentkoc marked this pull request as ready for review March 2, 2026 07:55
@vincentkoc
Copy link
Member Author

Removal of routing: { sessions: { mainKey: MAIN_SESSION_KEY } }, is safe as no longer in use.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 2, 2026

Greptile Summary

This PR systematically addresses TypeScript typing issues across 16 test files without altering runtime behavior. The changes convert parameterized test cases from inline arrays to explicitly typed structures, add proper type annotations to mock functions, and refine helper function signatures to be more flexible while maintaining type safety. All changes are legitimate typing improvements that enhance code maintainability and type correctness.

Confidence Score: 5/5

  • This PR is safe to merge with no risk - contains only TypeScript typing fixes to test files with no runtime behavior changes.
  • The PR exclusively contains TypeScript typing fixes for test files with no changes to production code logic. All modifications improve type safety through explicit type annotations, proper mock function typing, and structured test case definitions. No security concerns or logical errors were identified.
  • No files require special attention.

Last reviewed commit: 4252ee8

@vincentkoc vincentkoc force-pushed the vincentkoc-code/fix-test-type-errors branch from e26cb1b to efdc741 Compare March 2, 2026 08:05
@vincentkoc vincentkoc force-pushed the vincentkoc-code/fix-test-type-errors branch from efdc741 to 61daccb Compare March 2, 2026 08:37
@vincentkoc vincentkoc merged commit 29c3ce9 into openclaw:main Mar 2, 2026
27 checks passed
@vincentkoc vincentkoc deleted the vincentkoc-code/fix-test-type-errors branch March 2, 2026 08:43
mrosmarin added a commit to mrosmarin/openclaw that referenced this pull request Mar 2, 2026
* main: (212 commits)
  fix(ci): annotate feishu hoisted mock type
  fix(ci): align strict nullable typing across channels and ui
  refactor(tests): dedupe macos ipc smoke setup blocks
  refactor(tests): dedupe ios gateway and deeplink fixtures
  refactor(tests): dedupe openclawkit chat test helpers
  test(runtime): trim timer-heavy regression suites
  test(config): reuse fixtures for faster validation
  test(cli): reduce update/program suite overhead
  refactor(tests): dedupe ios defaults and setup-code helpers
  refactor(tests): dedupe swift gateway and chat fixtures
  Diffs: extend image quality configs and add PDF as a format option (openclaw#31342)
  refactor(scripts): dedupe installer CLI verification
  refactor(extensions): dedupe channel config, onboarding, and monitors
  refactor(core): extract shared usage, auth, and display helpers
  refactor(ui): dedupe state, views, and usage helpers
  refactor(scripts): dedupe guard checks and smoke helpers
  fix(browser): honor profile attachOnly for loopback CDP (openclaw#31429)
  [AI-assisted] test: fix typing and test fixture issues (openclaw#31444)
  chore(tsgo/lint): fix CI errors
  fix(browser): support configurable CDP auto-port range start (openclaw#31352)
  ...
hanqizheng pushed a commit to hanqizheng/openclaw that referenced this pull request Mar 2, 2026
* test: fix typing and test fixture issues

* Fix type-test harness issues from session routing and mock typing

* Add routing regression test for session.mainKey precedence
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
* test: fix typing and test fixture issues

* Fix type-test harness issues from session routing and mock typing

* Add routing regression test for session.mainKey precedence
dawi369 pushed a commit to dawi369/davis that referenced this pull request Mar 3, 2026
* test: fix typing and test fixture issues

* Fix type-test harness issues from session routing and mock typing

* Add routing regression test for session.mainKey precedence
OWALabuy pushed a commit to kcinzgg/openclaw that referenced this pull request Mar 4, 2026
* test: fix typing and test fixture issues

* Fix type-test harness issues from session routing and mock typing

* Add routing regression test for session.mainKey precedence
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
* test: fix typing and test fixture issues

* Fix type-test harness issues from session routing and mock typing

* Add routing regression test for session.mainKey precedence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling channel: slack Channel integration: slack commands Command implementations maintainer Maintainer-authored PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant