ui(cron): add advanced controls for run-if-due and routing by Takhoffman · Pull Request #31244 · openclaw/openclaw

Takhoffman · 2026-03-02T03:49:07Z

Summary

Describe the problem and fix in 2–5 bullets:

Problem: Web cron management was missing advanced controls available in CLI (session-key, delivery account, light-context, and due-only run mode).
Why it matters: Cron jobs configured from Web UI could not express full routing/execution intent, causing avoidable CLI-only workflows.
What changed: Added advanced Web UI controls and payload wiring for sessionKey, delivery accountId, lightContext, and Run if due (cron.run mode due).
What did NOT change (scope boundary): Did not change gateway cron semantics or add new cron API methods; this is UI/controller/type wiring only.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

None

User-visible / Behavior Changes

Cron job editor now exposes Advanced Session key field.
Cron delivery now supports Advanced Account ID input for multi-account channel routing.
Cron agent payload now supports Advanced Light context toggle.
Job rows now include Run if due, which triggers cron.run in due-only mode.

Security Impact (required)

New permissions/capabilities? (Yes/No): No
Secrets/tokens handling changed? (Yes/No): No
New/changed network calls? (Yes/No): No
Command/tool execution surface changed? (Yes/No): No
Data access scope changed? (Yes/No): No
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS
Runtime/container: Node/pnpm workspace
Model/provider: N/A
Integration/channel (if any): Cron UI + Gateway RPC
Relevant config (redacted): default local dev config

Steps

Open Web UI Cron tab.
Create or edit an isolated agentTurn job.
Set Advanced fields (Session key, Account ID, Light context) and use Run if due.

Expected

Fields are editable and persisted through cron.add/cron.update payloads.
Run if due sends cron.run with mode due.

Actual

Matches expected.

Evidence

Attach at least one:

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios: Reviewed and validated payload wiring in controller/view paths; ran formatting checks on all touched files.
Edge cases checked: Edit-mode clearing semantics for sessionKey and lightContext; due-mode run wiring.
What you did not verify: Full browser Vitest suite in this environment (Playwright browser binary missing).

Compatibility / Migration

Backward compatible? (Yes/No): Yes
Config/env changes? (Yes/No): No
Migration needed? (Yes/No): No
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: Revert this PR.
Files/config to restore: ui/src/ui/controllers/cron.ts, ui/src/ui/views/cron.ts and associated UI type/default files.
Known bad symptoms reviewers should watch for: Missing/incorrect cron payload fields from Web UI edits.

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

Risk: Advanced fields could be misconfigured by users.
- Mitigation: Fields are optional; existing defaults and behavior remain unchanged when unset.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7607a6ce0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T03:53:38Z

                ? form.deliveryChannel.trim() || "last"
                : undefined,
            to: form.deliveryTo.trim() || undefined,
+            accountId: form.deliveryAccountId.trim() || undefined,


Send explicit accountId clears when editing cron jobs

When a job already has delivery.accountId, clearing the Account ID field in the UI does not remove it: form.deliveryAccountId.trim() || undefined yields undefined, and the gateway request path (ui/src/ui/gateway.ts JSON.stringify(frame)) drops undefined keys, so the cron.update patch omits accountId; on the server, mergeCronDelivery only clears the field when accountId is present in the patch. This leaves stale account routing that users cannot clear from the web editor.

Useful? React with 👍 / 👎.

greptile-apps · 2026-03-02T03:56:09Z

Greptile Summary

This PR successfully adds advanced cron controls to the Web UI, bringing feature parity with CLI options. The implementation adds four new capabilities: sessionKey for routing, delivery accountId for multi-account channel setups, lightContext toggle for agent payloads, and "Run if due" mode.

Key changes:

Added type definitions for sessionKey, accountId, and lightContext across type files
Implemented form state management with proper defaults in app-defaults.ts
Added UI controls in views/cron.ts with appropriate conditional rendering (Account ID and Light context only shown for agentTurn payloads)
Implemented clearing semantics in controller: empty sessionKey field explicitly sends null when editing jobs that previously had values
Extended runCronJob function with mode parameter ("force" | "due")
Added comprehensive test coverage for all new features

Implementation quality:

Changes are well-structured and follow existing patterns
Backward compatible - all new fields are optional with sensible defaults
Test coverage includes edge cases like clearing lightContext on existing jobs
UI properly disabled Account ID field when delivery mode is not "announce"

Confidence Score: 5/5

This PR is safe to merge with minimal risk - well-tested UI additions with no breaking changes or security implications.
Score reflects comprehensive test coverage, careful implementation of clearing semantics, backward compatibility, and localized changes to UI layer only. No logical errors, security issues, or breaking changes identified.
No files require special attention - all changes are well-tested and follow existing patterns.

_{Last reviewed commit: cb9184b}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b034bda15

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T04:27:00Z

+        state.cronEditingJobId &&
+        existingLightContext !== undefined
+      ) {
+        payload.lightContext = false;


Persist lightContext changes when updating cron jobs

This change sends payload.lightContext in cron.update, but the update path currently discards that field: mergeCronPayload never applies patch.lightContext and buildPayloadFromPatch also omits it (src/cron/service/jobs.ts:554-582 and src/cron/service/jobs.ts:638-649). In practice, editing an existing job and toggling the new Light context control (especially turning it off) silently does not persist, so the UI suggests a change that the stored cron job never receives.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9df616fc2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T04:38:35Z

+            accountId:
+              selectedDeliveryMode === "announce" ? form.deliveryAccountId.trim() : undefined,


Use explicit clear sentinel for delivery accountId edits

When an existing cron job has delivery.accountId set, clearing the Account ID field still does not remove it: this code sends accountId as an empty string, but the cron.update path normalizes patches with normalizeCronJobPatch, which strips blank delivery.accountId values (src/cron/normalize.ts:198-204) before applyJobPatch runs (src/gateway/server-methods/cron.ts:119-123). That means the patch omits accountId entirely, so the old routing account remains persisted and cannot be cleared from the UI.

Useful? React with 👍 / 👎.

Takhoffman · 2026-03-02T13:24:48Z

Merged via squash at 254bb7c.

Verification run on PR head 75f7d28:

pnpm install --frozen-lockfile
pnpm build
pnpm check
pnpm test:macmini

All four commands passed in this final landing run.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75f7d28021

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T13:26:32Z

    ...jobToSuggestions,
    ...accountToSuggestions,
  ]);
+  const accountSuggestions = uniquePreserveOrder(accountToSuggestions);


Restrict account suggestions to IDs for cron delivery routing

accountSuggestions is now fed directly into the new Account ID input, but this list is built from accountToSuggestions, which also contains human-readable account.name values; when a name differs from its real ID, selecting it sends that name as delivery.accountId, and downstream account lookup resolves by account key/ID (not display name), so delivery can route to the wrong/default account or fail for multi-account setups. Keep accountSuggestions ID-only (or translate names back to IDs before submit) for this field.

Useful? React with 👍 / 👎.

…31244) * ui(cron): add advanced run controls and routing fields * ui(cron): gate delivery account id to announce mode * ui(cron): allow clearing delivery account id in editor * cron: persist payload lightContext updates * tests(cron): fix payload lightContext assertion typing

…31244) * ui(cron): add advanced run controls and routing fields * ui(cron): gate delivery account id to announce mode * ui(cron): allow clearing delivery account id in editor * cron: persist payload lightContext updates * tests(cron): fix payload lightContext assertion typing (cherry picked from commit 254bb7c)

…31244) * ui(cron): add advanced run controls and routing fields * ui(cron): gate delivery account id to announce mode * ui(cron): allow clearing delivery account id in editor * cron: persist payload lightContext updates * tests(cron): fix payload lightContext assertion typing

openclaw-barnacle Bot added app: web-ui App: web-ui size: M maintainer Maintainer-authored PR labels Mar 2, 2026

chatgpt-codex-connector Bot reviewed Mar 2, 2026

View reviewed changes

openclaw-barnacle Bot added the gateway Gateway runtime label Mar 2, 2026

Takhoffman force-pushed the task/cron-ui-cli-parity branch from 386fd2c to 8b034bd Compare March 2, 2026 04:21

openclaw-barnacle Bot removed docs Improvements or additions to documentation channel: bluebubbles Channel integration: bluebubbles channel: googlechat Channel integration: googlechat channel: matrix Channel integration: matrix channel: mattermost Channel integration: mattermost labels Mar 2, 2026

openclaw-barnacle Bot added size: M and removed size: XL labels Mar 2, 2026

chatgpt-codex-connector Bot reviewed Mar 2, 2026

View reviewed changes

Takhoffman added 5 commits March 2, 2026 07:19

ui(cron): add advanced run controls and routing fields

13807be

ui(cron): gate delivery account id to announce mode

39b7a1c

ui(cron): allow clearing delivery account id in editor

2a41f9d

cron: persist payload lightContext updates

66c5742

tests(cron): fix payload lightContext assertion typing

75f7d28

Takhoffman force-pushed the task/cron-ui-cli-parity branch from d9df616 to 75f7d28 Compare March 2, 2026 13:19

Takhoffman merged commit 254bb7c into main Mar 2, 2026
26 of 27 checks passed

Takhoffman deleted the task/cron-ui-cli-parity branch March 2, 2026 13:24

chatgpt-codex-connector Bot reviewed Mar 2, 2026

View reviewed changes

jasonftl mentioned this pull request Mar 2, 2026

fix(ui): use root-relative path for control UI header logo #25696

Closed

5 tasks

alexey-pelykh mentioned this pull request Mar 16, 2026

Cherry-pick batch: Cron fixes — timeout, error handling, stale state, delivery resilience remoteclaw/remoteclaw#1547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ui(cron): add advanced controls for run-if-due and routing#31244

ui(cron): add advanced controls for run-if-due and routing#31244
Takhoffman merged 5 commits intomainfrom
task/cron-ui-cli-parity

Takhoffman commented Mar 2, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Uh oh!

greptile-apps Bot commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Uh oh!

Uh oh!

Takhoffman commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		accountId:
		selectedDeliveryMode === "announce" ? form.deliveryAccountId.trim() : undefined,

Uh oh!

Conversation

Takhoffman commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Mar 2, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Takhoffman commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Takhoffman commented Mar 2, 2026 •

edited

Loading