fix(voice-call): accept externally-initiated Twilio outbound-api calls by scoootscooob · Pull Request #31181 · openclaw/openclaw

scoootscooob · 2026-03-02T02:24:52Z

Problem

When calls are initiated directly via the Twilio REST API (e.g. curl -X POST .../Calls.json -d "Url=https://example.com/voice/webhook"), the voice-call plugin rejects the MediaStream connection with:

[MediaStream] Rejecting stream for unknown call: CAxxxxxxx

The call is immediately terminated after the recipient answers — no audio is played.

Fixes #30900

Root Cause

processEvent() in manager/events.ts only auto-registers untracked calls when event.direction === "inbound". Calls initiated via Twilio REST API arrive with Direction=outbound-api, which parseDirection() normalizes to "outbound". Since "outbound" !== "inbound", the call is never registered in CallManager, and shouldAcceptStream() rejects the media stream.

Fix

Expand the auto-registration condition to also cover direction === "outbound" — these are externally-initiated outbound-api calls arriving at our webhook without a pre-existing tracked call. Inbound policy checks (disabled/allowlist/pairing) still only apply to true inbound calls; external outbound-api calls are implicitly trusted because the caller controls the webhook URL.

Test

2 new tests in events.test.ts:
- Verifies externally-initiated outbound-api calls are auto-registered in activeCalls and providerCallIdMap
- Verifies outbound calls bypass disabled inbound policy (no hangup)
All 80 existing voice-call tests continue to pass

🤖 Generated with Claude Code

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6adf336370

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T02:29:15Z

extensions/voice-call/src/manager/events.ts

+  const isUnregisteredWebhookCall =
+    !call &&
+    event.providerCallId &&
+    (event.direction === "inbound" || event.direction === "outbound");


Preserve outbound direction for auto-registered calls

Including event.direction === "outbound" in this auto-registration branch routes externally initiated outbound-api events through createInboundCall, which hardcodes direction: "inbound" and inbound metadata. That misclassifies these calls and changes downstream behavior that depends on direction (for example, the webhook auto-response gate in extensions/voice-call/src/webhook.ts treats inbound calls as always conversational), so outbound-api calls can be handled as inbound conversations unexpectedly. Register outbound-api calls with outbound direction (or a dedicated helper) instead of the inbound constructor path.

Useful? React with 👍 / 👎.

greptile-apps · 2026-03-02T02:31:11Z

Greptile Summary

Correctly expands auto-registration to cover externally-initiated Twilio outbound-api calls, fixing MediaStream rejection issue. Security logic properly bypasses inbound policy for external outbound calls.

Critical Issue:

Externally-initiated outbound calls are stored with incorrect direction: "inbound" because createInboundCall() hardcodes the direction field, even though these calls have event.direction === "outbound". This affects data integrity and any downstream code relying on accurate direction information.

Other Issues:

Test coverage doesn't verify that call.direction matches the event's direction, which would have caught this bug.

Confidence Score: 2/5

Fixes the immediate MediaStream rejection issue but introduces data integrity bug with incorrect direction field storage
Core functionality works and security logic is sound, but externally-initiated outbound calls are stored with wrong direction: "inbound" instead of "outbound". This data inconsistency could cause unexpected behavior in code relying on accurate direction information (e.g., analytics, logging, business logic checking call.direction). The fix should preserve the event's actual direction.
extensions/voice-call/src/manager/events.ts requires attention to fix the direction field issue in the createInboundCall function

_{Last reviewed commit: 6adf336}

greptile-apps

_{3 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-03-02T02:31:18Z

extensions/voice-call/src/manager/events.test.ts

+    // Call should be registered in activeCalls and providerCallIdMap
+    expect(ctx.activeCalls.size).toBe(1);
+    expect(ctx.providerCallIdMap.get("CA-external-123")).toBeDefined();
+    const call = [...ctx.activeCalls.values()][0];
+    expect(call?.providerCallId).toBe("CA-external-123");
+    expect(call?.from).toBe("+15550000000");
+    expect(call?.to).toBe("+15559876543");


Test doesn't verify that call.direction matches the event's direction. Add:

Suggested change

// Call should be registered in activeCalls and providerCallIdMap

expect(ctx.activeCalls.size).toBe(1);

expect(ctx.providerCallIdMap.get("CA-external-123")).toBeDefined();

const call = [...ctx.activeCalls.values()][0];

expect(call?.providerCallId).toBe("CA-external-123");

expect(call?.from).toBe("+15550000000");

expect(call?.to).toBe("+15559876543");

// Call should be registered in activeCalls and providerCallIdMap

expect(ctx.activeCalls.size).toBe(1);

expect(ctx.providerCallIdMap.get("CA-external-123")).toBeDefined();

const call = [...ctx.activeCalls.values()][0];

expect(call?.direction).toBe("outbound");

expect(call?.providerCallId).toBe("CA-external-123");

expect(call?.from).toBe("+15550000000");

expect(call?.to).toBe("+15559876543");

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/voice-call/src/manager/events.test.ts Line: 253-259 Comment: Test doesn't verify that `call.direction` matches the event's direction. Add: ```suggestion // Call should be registered in activeCalls and providerCallIdMap expect(ctx.activeCalls.size).toBe(1); expect(ctx.providerCallIdMap.get("CA-external-123")).toBeDefined(); const call = [...ctx.activeCalls.values()][0]; expect(call?.direction).toBe("outbound"); expect(call?.providerCallId).toBe("CA-external-123"); expect(call?.from).toBe("+15550000000"); expect(call?.to).toBe("+15559876543"); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-03-02T02:31:20Z

Additional Comments (1)

extensions/voice-call/src/manager/events.ts
createInboundCall() hardcodes direction: "inbound" (line 74), but is now used to create externally-initiated outbound calls. The created CallRecord will have direction: "inbound" even though event.direction === "outbound". This creates data inconsistency.

Consider passing the event's direction to createInboundCall() or renaming it to a more general createWebhookCall(direction) function.

Prompt To Fix With AI

This is a comment left during a code review.
Path: extensions/voice-call/src/manager/events.ts
Line: 145

Comment:
`createInboundCall()` hardcodes `direction: "inbound"` (line 74), but is now used to create externally-initiated outbound calls. The created `CallRecord` will have `direction: "inbound"` even though `event.direction === "outbound"`. This creates data inconsistency.

Consider passing the event's direction to `createInboundCall()` or renaming it to a more general `createWebhookCall(direction)` function.

How can I resolve this? If you propose a fix, please make it concise.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 502b1aa3a4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T16:44:26Z

CHANGELOG.md

@@ -2,338 +2,97 @@

 Docs: https://docs.openclaw.ai

-## 2026.3.2 (Unreleased)
+## 2026.2.27


Restore current changelog head before adding new entry

This commit replaces the existing 2026.3.2 (Unreleased) head with an older 2026.2.27 snapshot, effectively dropping a large set of already-recorded entries and PR references from CHANGELOG.md; that is a regression in release metadata and will trip the repo’s changelog merge-hygiene check in scripts/pr (it rejects dropped PR refs that are not re-added). Please rebase this changelog edit onto the current head and add only the new voice-call fix line.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76f8a06d57

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T17:43:18Z

extensions/voice-call/src/manager/events.ts

+      initialMessage:
+        params.direction === "inbound"
+          ? params.ctx.config.inboundGreeting || "Hello! How can I help you today?"
+          : undefined,


Populate mode for auto-registered outbound webhook calls

When an untracked outbound webhook call is auto-registered here, the new CallRecord does not set metadata.mode, so downstream transcript handling treats it as non-conversational. In extensions/voice-call/src/webhook.ts:127-129, auto-replies only run for inbound calls or mode === "conversation"; externally initiated outbound-api calls created by this path therefore accept the stream but never produce bot responses, leaving the call silent after user speech.

Useful? React with 👍 / 👎.

Fixes openclaw#30900 — Calls initiated directly via the Twilio REST API (Direction=outbound-api) were rejected as "unknown call" because processEvent only auto-registered calls with direction=inbound. External outbound-api calls now get registered in the CallManager so the media stream is accepted. Inbound policy checks still only apply to true inbound calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ection Address Greptile review: externally-initiated outbound-api calls were stored with hardcoded direction: "inbound". Now createWebhookCall accepts a direction parameter so the CallRecord accurately reflects the event's actual direction. Also skip inboundGreeting for outbound calls and add a test asserting inbound direction is preserved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@scoootscooob

… (thanks @scoootscooob)

steipete · 2026-03-02T23:56:48Z

Landed via temp rebase onto main.

Gate: pnpm lint && pnpm build && pnpm test
Land commit: 6565e9f
Merge commit: 381bb86

Thanks @scoootscooob!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6565e9fa96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-03T00:00:08Z

extensions/voice-call/src/manager/events.ts

    metadata: {
-      initialMessage: params.ctx.config.inboundGreeting || "Hello! How can I help you today?",
+      initialMessage:
+        params.direction === "inbound"
+          ? params.ctx.config.inboundGreeting || "Hello! How can I help you today?"
+          : undefined,


Set mode for auto-registered outbound webhook calls

Auto-registering an untracked outbound webhook call here leaves metadata.mode unset, which breaks conversational handling for the very outbound-api flow this commit adds. In extensions/voice-call/src/webhook.ts:127-129, auto-response only runs when call.direction === "inbound" or call.metadata.mode === "conversation"; these outbound calls therefore accept media/transcripts but never trigger handleInboundResponse, resulting in silent calls after user speech unless another path manually drives responses.

Useful? React with 👍 / 👎.

@scoootscooob

… (thanks @scoootscooob)

@scoootscooob

… (thanks @scoootscooob)

@scoootscooob

… (thanks @scoootscooob)

openclaw-barnacle bot added channel: voice-call Channel integration: voice-call size: S labels Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

greptile-apps bot reviewed Mar 2, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 2, 2026

🦞 OpenClaw 生态日报 2026-03-02 rollysys/agents-radar#23

Open

steipete mentioned this pull request Mar 2, 2026

fix(voice-call): accept externally-initiated outbound Twilio calls #30904

Closed

18 tasks

scoootscooob force-pushed the fix/voice-call-external-outbound branch from 9552ee0 to 502b1aa Compare March 2, 2026 16:37

openclaw-barnacle bot added size: M and removed size: S labels Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

scoootscooob force-pushed the fix/voice-call-external-outbound branch from 502b1aa to 76f8a06 Compare March 2, 2026 17:37

openclaw-barnacle bot added size: S and removed size: M labels Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

scoootscooob and others added 3 commits March 2, 2026 23:55

fix: land external Twilio outbound-api webhook calls (openclaw#31181)…

6565e9f

… (thanks @scoootscooob)

steipete force-pushed the fix/voice-call-external-outbound branch from 76f8a06 to 6565e9f Compare March 2, 2026 23:56

steipete merged commit 381bb86 into openclaw:main Mar 2, 2026

openclaw-barnacle bot added the experienced-contributor label Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

dawi369 pushed a commit to dawi369/davis that referenced this pull request Mar 3, 2026

fix: land external Twilio outbound-api webhook calls (openclaw#31181)…

5156ac2

… (thanks @scoootscooob)

OWALabuy pushed a commit to kcinzgg/openclaw that referenced this pull request Mar 4, 2026

fix: land external Twilio outbound-api webhook calls (openclaw#31181)…

2be6fd5

… (thanks @scoootscooob)

zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

fix: land external Twilio outbound-api webhook calls (openclaw#31181)…

e02b7be

… (thanks @scoootscooob)

Uh oh!

Conversation

scoootscooob commented Mar 2, 2026

Problem

Root Cause

Fix

Test

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Confidence Score: 2/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

steipete commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants