fix(agents): expand ~ in path for read/write/edit tools by jackjin1997 · Pull Request #30744 · openclaw/openclaw

jackjin1997 · 2026-03-01T15:19:58Z

Fixes #30669. Standardizes tilde expansion across all filesystem tools by expanding ~ in normalizeToolParams (src/agents/pi-tools.read.ts).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ea935549e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/sessions/input-provenance.ts

src/config/types.tools.ts

greptile-apps · 2026-03-01T15:27:16Z

Greptile Summary

This PR implements tilde (~) expansion for filesystem tools (read/write/edit) by adding expandHomePrefix in normalizeToolParams. The implementation correctly handles path normalization and applies to all three filesystem tools through a single centralized function.

Additionally includes:

Brave search baseUrl configuration support (mirrors existing Perplexity pattern)
Inter-session message role attribution fix (sets role to "assistant" for inter-session provenance)

Key changes:

normalizeToolParams now expands ~ prefix using the expandHomePrefix utility
Type-safe with proper string checking before expansion
Falls back gracefully if home directory cannot be resolved
Brave search cache key updated to include baseUrl for proper cache segmentation

Confidence Score: 4/5

Safe to merge - changes are technically sound with proper type safety and error handling
Score reflects solid implementation of tilde expansion using well-tested utility functions, proper type checking, and graceful fallbacks. The changes follow existing codebase patterns and include multiple logical fixes. Deducted one point because the PR bundles three separate concerns (tilde expansion, Brave search baseUrl, inter-session message roles) which ideally should be separate PRs for easier review and rollback if needed.
No files require special attention - all changes are straightforward and follow existing patterns

_{Last reviewed commit: 9ea9355}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40a2a59db2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/agents/tools/web-search.ts

path.resolve() treats ~ as a literal directory name, so ~/file.txt resolved to <cwd>/~/file.txt instead of /home/user/file.txt. Add expandHomePrefix() before path.resolve() in all affected tool path resolution points: - Host write operations (mkdir, writeFile) in non-workspace mode - Host edit operations (readFile, writeFile, access) in non-workspace mode - toRelativePathInRoot() workspace boundary validator (affects all tools) - resolveWorkdir() for non-sandbox exec/bash working directory - parseSandboxBindMount() for Docker bind mount host paths The host read tool and sandbox tools already handled tilde via the upstream library's expandPath(). Closes openclaw#30669 Related: openclaw#30782, openclaw#30788, openclaw#30744, openclaw#30770, openclaw#30756, openclaw#30753, openclaw#30752, openclaw#30747

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97b94100de

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/sessions/input-provenance.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80189696ec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

skills/sherpa-onnx-tts/bin/sherpa-onnx-tts

src/agents/tilde-expansion.test.ts

- pi-tools.params.ts: add expandHomePrefix to normalizeToolParams so ~ expansion is preserved after upstream refactored the function out of pi-tools.read.ts (the PR's core feature was silently dropped in the conflict resolution) - input-provenance.ts: remove inter-session role rewrite (user→assistant) that broke hasInterSessionUserProvenance filters downstream; session-memory and session-utils relied on role=user to detect and skip inter-session content, so the rewrite caused cross-session content to leak into memory and history exports; provenance field alone is sufficient to identify inter-session messages Addresses Codex review P1/P2 feedback on PR openclaw#30744. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a620fdbe14

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

skills/sherpa-onnx-tts/bin/sherpa-onnx-tts

- pi-tools.params.ts: add expandHomePrefix to normalizeToolParams so ~ expansion is preserved after upstream refactored the function out of pi-tools.read.ts (the PR's core feature was silently dropped in the conflict resolution) - input-provenance.ts: remove inter-session role rewrite (user→assistant) that broke hasInterSessionUserProvenance filters downstream; session-memory and session-utils relied on role=user to detect and skip inter-session content, so the rewrite caused cross-session content to leak into memory and history exports; provenance field alone is sufficient to identify inter-session messages Addresses Codex review P1/P2 feedback on PR openclaw#30744. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61d2d49041

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/agents/pi-tools.read.ts

…ge role

…nter-session role - Fix inter-session provenance role rewrite to only apply to user messages - Add baseUrl to ToolsWebSearchSchema zod validation for Brave baseUrl support - Fix whitespace-only braveBaseUrl causing crash by trimming before fallback

- pi-tools.params.ts: add expandHomePrefix to normalizeToolParams so ~ expansion is preserved after upstream refactored the function out of pi-tools.read.ts (the PR's core feature was silently dropped in the conflict resolution) - input-provenance.ts: remove inter-session role rewrite (user→assistant) that broke hasInterSessionUserProvenance filters downstream; session-memory and session-utils relied on role=user to detect and skip inter-session content, so the rewrite caused cross-session content to leak into memory and history exports; provenance field alone is sufficient to identify inter-session messages Addresses Codex review P1/P2 feedback on PR openclaw#30744. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…read After rebasing onto upstream/main, the tilde-expansion cherry-pick re-introduced the normalizeToolParams/CLAUDE_PARAM_GROUPS/etc. block inline into pi-tools.read.ts. Upstream already moved these to pi-tools.params.ts (re-exported via pi-tools.read.ts), so the inline copy caused redeclared-export TS errors and an unused import. Remove the duplicate block and the now-unused expandHomePrefix import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02dc5a52be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-06T12:36:18Z

src/agents/pi-tools.params.ts

  }
+  // Expand ~ in path
+  if (typeof normalized.path === "string" && normalized.path.startsWith("~")) {
+    normalized.path = expandHomePrefix(normalized.path);


Expand filesystem tool tildes using OS home, not OPENCLAW_HOME

normalizeToolParams now expands path with expandHomePrefix, but this helper defaults to resolveEffectiveHomeDir, which prefers OPENCLAW_HOME; in deployments that set OPENCLAW_HOME for app-state isolation, a user input like ~/notes.txt is rewritten to <OPENCLAW_HOME>/notes.txt instead of the account home directory, so read/write/edit calls can hit the wrong file tree (or fail workspace guards unexpectedly). This expansion should use the OS user home source (HOME/USERPROFILE/os.homedir()) for tool paths, similar to the explicit-home expansion path used in fs-safe.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ae8ba6eedb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-07T04:25:00Z

src/agents/pi-tools.params.ts

+  if (typeof normalized.path === "string" && normalized.path.startsWith("~")) {
+    normalized.path = expandHomePrefix(normalized.path);


Expand fs-tool tilde paths with OS home

normalizeToolParams now expands ~ via expandHomePrefix without a home override, which makes ~/... resolve to OPENCLAW_HOME when that env var is set. In deployments that set OPENCLAW_HOME for app-state isolation, read/write/edit tool calls will target that state directory instead of the actual account home (or be blocked by workspace guards), so user file paths are rewritten to the wrong tree. This should use OS-home expansion for tool paths (as expandRelativePathWithHome does in src/infra/fs-safe.ts).

Useful? React with 👍 / 👎.

openclaw-barnacle bot added agents Agent runtime and tooling size: XS labels Mar 1, 2026

chatgpt-codex-connector bot reviewed Mar 1, 2026

View reviewed changes

src/sessions/input-provenance.ts Outdated Show resolved Hide resolved

src/config/types.tools.ts Show resolved Hide resolved

openclaw-barnacle bot added size: S and removed size: XS labels Mar 1, 2026

chatgpt-codex-connector bot reviewed Mar 1, 2026

View reviewed changes

src/agents/tools/web-search.ts Outdated Show resolved Hide resolved

thomasxm mentioned this pull request Mar 1, 2026

fix(agents): expand tilde in tool file paths #30847

Closed

12 tasks

thomasxm mentioned this pull request Mar 1, 2026

fix(agents): expand tilde in tool file paths #30866

Closed

13 tasks

steipete mentioned this pull request Mar 3, 2026

fix(tools): expand ~ in Edit and Write tool paths when workspaceOnly is false #30936

Closed

5 tasks

thomasxm mentioned this pull request Mar 3, 2026

fix(agents): expand tilde in tool file paths #33501

Open

12 tasks

jackjin1997 force-pushed the fix-edit-tool-tilde-expansion branch from 0238fcf to 97b9410 Compare March 5, 2026 16:56

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

src/sessions/input-provenance.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

skills/sherpa-onnx-tts/bin/sherpa-onnx-tts Outdated Show resolved Hide resolved

src/agents/tilde-expansion.test.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 5, 2026

View reviewed changes

skills/sherpa-onnx-tts/bin/sherpa-onnx-tts Outdated Show resolved Hide resolved

openclaw-barnacle bot added size: XL and removed size: S labels Mar 5, 2026

jackjin1997 force-pushed the fix-edit-tool-tilde-expansion branch from a620fdb to 61d2d49 Compare March 6, 2026 03:04

openclaw-barnacle bot added size: M and removed size: XL labels Mar 6, 2026

openclaw-barnacle bot added the size: M label Mar 6, 2026

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

src/agents/pi-tools.read.ts Outdated Show resolved Hide resolved

openclaw-barnacle bot added size: S and removed size: M labels Mar 6, 2026

jackjin1997 and others added 6 commits March 6, 2026 20:23

fix: add baseUrl support for Brave search and fix inter-session messa…

2029cf0

…ge role

fix(agents): expand ~ in path for read/write/edit tools

d550548

test(agents): add unit tests for tilde expansion in tool parameters

735db75

jackjin1997 force-pushed the fix-edit-tool-tilde-expansion branch from c8a1567 to 02dc5a5 Compare March 6, 2026 12:29

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

Merge branch 'main' into fix-edit-tool-tilde-expansion

ae8ba6e

chatgpt-codex-connector bot reviewed Mar 7, 2026

View reviewed changes

jackjin1997 added a commit to jackjin1997/openclaw that referenced this pull request Mar 7, 2026

fix(agents): address PR openclaw#30744 review feedback

bb791b6

jackjin1997 added 2 commits March 7, 2026 17:40

fix(agents): fix tilde import path and use OS home for ~ expansion

8a9e694

Merge branch 'main' into fix-edit-tool-tilde-expansion

ae7b1be

		if (typeof normalized.path === "string" && normalized.path.startsWith("~")) {
		normalized.path = expandHomePrefix(normalized.path);

Uh oh!

Conversation

jackjin1997 commented Mar 1, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Mar 1, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant