feat(feishu): prefer thread_id for topic session routing by songyaolun · Pull Request #29788 · openclaw/openclaw

songyaolun · 2026-02-28T13:52:54Z

Summary

prefer Feishu thread_id over root_id for topic-scoped session routing
keep topicSessionMode legacy behavior while improving topic isolation accuracy
force thread-context replies to stay in thread and disable streaming cards in thread contexts to avoid topic drift

Changes

parse and carry thread_id from inbound events (FeishuMessageEvent/FeishuMessageContext)
centralize group session resolution and use topic-scoped keys based on thread_id first
preserve group history isolation by using session peer id as history key
add threadReply mode in reply dispatcher to force reply_in_thread and disable streaming in thread contexts
update schema comments and add regression tests for thread-id routing and thread reply behavior

Verification

pnpm --dir /Users/bytedance/Documents/git_repo/openclaw exec vitest run extensions/feishu/src/bot.test.ts extensions/feishu/src/reply-dispatcher.test.ts
pnpm --dir /Users/bytedance/Documents/git_repo/openclaw exec oxfmt --check extensions/feishu/src/bot.ts extensions/feishu/src/types.ts extensions/feishu/src/reply-dispatcher.ts extensions/feishu/src/config-schema.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/reply-dispatcher.test.ts

Screenshots

Origin

Topic A starts an isolated session
Topic B starts a different isolated session

Bot reply stays in the same topic thread UI (attach screenshot)

Mainline group chat remains on main session (attach screenshot)

Closes #29791

greptile-apps · 2026-02-28T13:58:11Z

Greptile Summary

This PR enhances Feishu's topic session routing by preferring thread_id over root_id for improved topic isolation accuracy:

Added thread_id field to FeishuMessageEvent and FeishuMessageContext types
Introduced resolveFeishuGroupSession() function to centralize group session resolution logic
Modified topic scope resolution to prioritize thread_id ?? root_id ?? messageId (when applicable)
Implemented threadReply mode that forces replies to stay in thread and disables card streaming in thread contexts to maintain thread affinity
Updated history isolation to use session peer ID (groupSession?.peerId) instead of just chatId, providing proper history separation for topic-scoped sessions
Added comprehensive test coverage for thread_id preference, legacy mode compatibility, and thread reply behavior
Updated schema documentation to clarify thread_id preference

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The implementation is well-structured with centralized logic, comprehensive test coverage for all key behaviors, proper handling of edge cases (empty strings, undefined values), and maintains backward compatibility with legacy topicSessionMode. The changes are incremental and focused on a specific improvement without introducing breaking changes.
No files require special attention

_{Last reviewed commit: cb89f34}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb89f3422d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

extensions/feishu/src/bot.ts

Takhoffman · 2026-03-02T23:33:21Z

PR #29788 - feat(feishu): prefer thread_id for topic session routing (#29788)

Merged after verification.

Merge commit: f22fc17
Verified: pnpm test -- extensions/feishu/src/bot.test.ts extensions/feishu/src/reply-dispatcher.test.ts; pnpm build
Autoland updates:
M CHANGELOG.md
Changelog: CHANGELOG.md updated=true required=true opt_out=false

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11b87be1bd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-02T23:38:40Z

extensions/feishu/src/bot.ts

+  // Prefer root_id first so both turns stay on the same peer key.
+  const topicScope =
+    groupSessionScope === "group_topic" || groupSessionScope === "group_topic_sender"
+      ? (normalizedRootId ?? normalizedThreadId ?? (replyInThread ? messageId : null))


Align debounced grouping with thread_id topic sessions

With inbound debounce enabled (messages.inbound.debounceMs > 0), this new thread_id-based topic routing can still misroute content because the debounce key is still built from root_id only (extensions/feishu/src/monitor.account.ts:309-311). If two text messages from the same sender arrive quickly in different threads that have no root_id, onFlush merges them and dispatches using the last event’s thread metadata, so the earlier thread’s text is routed into the wrong topic/session. Since this change now routes by thread_id (topicScope fallback), the debounce key should use the same root/thread fallback to avoid cross-thread mixing.

Useful? React with 👍 / 👎.

@songyaolun

) thanks @songyaolun Verified: - pnpm test -- extensions/feishu/src/bot.test.ts extensions/feishu/src/reply-dispatcher.test.ts - pnpm build Co-authored-by: songyaolun <26423459+songyaolun@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@songyaolun

) thanks @songyaolun Verified: - pnpm test -- extensions/feishu/src/bot.test.ts extensions/feishu/src/reply-dispatcher.test.ts - pnpm build Co-authored-by: songyaolun <26423459+songyaolun@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@songyaolun

) thanks @songyaolun Verified: - pnpm test -- extensions/feishu/src/bot.test.ts extensions/feishu/src/reply-dispatcher.test.ts - pnpm build Co-authored-by: songyaolun <26423459+songyaolun@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: M labels Feb 28, 2026

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

extensions/feishu/src/bot.ts Outdated Show resolved Hide resolved

songyaolun changed the title ~~fix(feishu): prefer thread_id for topic session routing~~ feat(feishu): prefer thread_id for topic session routing Feb 28, 2026

songyaolun and others added 3 commits March 2, 2026 17:30

fix(feishu): prefer thread_id for topic session routing

fe8095f

fix(feishu): keep topic session key stable across first turn

80a4f7f

Changelog: note Feishu topic session routing updates

11b87be

Takhoffman force-pushed the pr/feishu-only-v2 branch from e89f024 to 11b87be Compare March 2, 2026 23:32

Takhoffman merged commit f22fc17 into openclaw:main Mar 2, 2026
9 checks passed

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

Takhoffman mentioned this pull request Mar 2, 2026

Feishu: reply to topic roots #29968

Merged

18 tasks

4ier mentioned this pull request Mar 7, 2026

Critical: Telegram message replay storm after upgrade to 2026.3.2 #39010

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(feishu): prefer thread_id for topic session routing#29788

feat(feishu): prefer thread_id for topic session routing#29788
Takhoffman merged 3 commits intoopenclaw:mainfrom
songyaolun:pr/feishu-only-v2

songyaolun commented Feb 28, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

Takhoffman commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

songyaolun commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Verification

Screenshots

Uh oh!

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Takhoffman commented Mar 2, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

songyaolun commented Feb 28, 2026 •

edited

Loading