Skip to content

feat(gateway): enable Android notify + notification events#29440

Merged
obviyus merged 5 commits intomainfrom
feat/android-notify-events-20260228
Feb 28, 2026
Merged

feat(gateway): enable Android notify + notification events#29440
obviyus merged 5 commits intomainfrom
feat/android-notify-events-20260228

Conversation

@obviyus
Copy link
Contributor

@obviyus obviyus commented Feb 28, 2026

Summary

  • enable system.notify in Android default node command allowlist
  • emit notifications.changed from Android notification listener on post/remove
  • handle notifications.changed in gateway node-event pipeline and enqueue system events

Testing

  • pnpm test -- src/gateway/server-node-events.test.ts src/gateway/gateway-misc.test.ts
  • cd apps/android && ./gradlew testDebugUnitTest --tests ai.openclaw.android.node.NotificationsHandlerTest

@obviyus obviyus self-assigned this Feb 28, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Enabled system.notify command for Android and implemented notification event pipeline from Android listener to gateway system events.

  • Added NODE_SYSTEM_NOTIFY_COMMAND to Android platform defaults in src/gateway/node-command-policy.ts:85
  • Connected Android notification listener to node event sink in apps/android/app/src/main/java/ai/openclaw/android/NodeRuntime.kt:306-312 via init block
  • Emit notifications.changed events on post/remove in apps/android/app/src/main/java/ai/openclaw/android/node/DeviceNotificationListenerService.kt:137-169 with full notification metadata
  • Handle notifications.changed in gateway node event pipeline (src/gateway/server-node-events.ts:457-490) with proper validation and summary formatting
  • Comprehensive test coverage for event handling in src/gateway/server-node-events.test.ts:353-410

The implementation is clean, well-tested, and follows existing patterns for node event handling.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The implementation follows established patterns for node event handling, includes comprehensive test coverage for both gateway event handling and integration, properly validates inputs, and only enables functionality already present in the codebase. All changes are additive with no breaking modifications.
  • No files require special attention

Last reviewed commit: 408b665

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 408b665b4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@openclaw-barnacle openclaw-barnacle bot added app: android App: android gateway Gateway runtime size: S maintainer Maintainer-authored PR labels Feb 28, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9b71880eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13825858c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@obviyus obviyus force-pushed the feat/android-notify-events-20260228 branch from 197f57a to 021b755 Compare February 28, 2026 05:48
@obviyus obviyus merged commit 3899c89 into main Feb 28, 2026
@obviyus obviyus deleted the feat/android-notify-events-20260228 branch February 28, 2026 05:48
@obviyus
Copy link
Contributor Author

obviyus commented Feb 28, 2026

Landed via temp rebase onto main.

  • Gate: skipped full gate per maintainer request in-thread; relied on targeted tests from PR updates.
  • Land commit: 021b755
  • Merge commit: 3899c89

mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 28, 2026
r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026
mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 28, 2026
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Feb 28, 2026
vincentkoc pushed a commit to Sid-Qin/openclaw that referenced this pull request Feb 28, 2026
vincentkoc pushed a commit to rylena/rylen-openclaw that referenced this pull request Feb 28, 2026
newtontech pushed a commit to newtontech/openclaw-fork that referenced this pull request Feb 28, 2026
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
wanjizheng pushed a commit to wanjizheng/openclaw that referenced this pull request Mar 1, 2026
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026
ansh pushed a commit to vibecode/openclaw that referenced this pull request Mar 2, 2026
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request Mar 2, 2026
steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request Mar 2, 2026
venjiang pushed a commit to venjiang/openclaw that referenced this pull request Mar 2, 2026
robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026
execute008 pushed a commit to execute008/openclaw that referenced this pull request Mar 2, 2026
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026
dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request Mar 3, 2026
sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request Mar 6, 2026
zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026
Mateljan1 pushed a commit to Mateljan1/openclaw that referenced this pull request Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: android App: android gateway Gateway runtime maintainer Maintainer-authored PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant