fix(browser): accept url alias for open and navigate by vincentkoc · Pull Request #29260 · openclaw/openclaw

vincentkoc · 2026-02-28T01:09:13Z

Summary

Problem: Browser tool open/navigate required targetUrl and rejected url.
Why it matters: LLM/tool callers commonly send url, causing false failures.
What changed: Added url to browser tool schema and accepted targetUrl ?? url in open and navigate.
What did NOT change (scope boundary): No unrelated channel/runtime behavior changes.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes [Bug]: browser tool open and navigate actions fail with "targetUrl required" despite url parameter being provided #29136
Related fix(browser): support 'url' param as alias for 'targetUrl' #29180

User-visible / Behavior Changes

browser tool now accepts url as an alias for targetUrl for open and navigate.
Error label remains targetUrl required when neither is provided.

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (No)
Data access scope changed? (No)

Repro + Verification

Environment

OS: macOS
Runtime/container: Node 22 + pnpm
Model/provider: n/a
Integration/channel (if any): browser tool
Relevant config (redacted): default

Steps

Run browser tool with action=open and url=https://example.com.
Run browser tool with action=navigate and url=https://example.com.
Run browser tool with action=open and no URL params.

Expected

url works for open and navigate.
Missing URL still reports targetUrl required.

Actual

Verified as expected via unit tests.

Evidence

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

Verified scenarios: open with url, navigate with url, missing URL error label.
Edge cases checked: preserves targetUrl required label for compatibility.
What you did not verify: live browser session on external environment.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert this PR.
Files/config to restore: src/agents/tools/browser-tool.ts, src/agents/tools/browser-tool.schema.ts, src/agents/tools/browser-tool.test.ts.
Known bad symptoms reviewers should watch for: regressions in URL parameter parsing for browser actions.

Risks and Mitigations

Risk: callers depending on strict targetUrl-only validation semantics.
- Mitigation: keeps existing targetUrl path and error label unchanged; alias is additive.

Fixes #29136

aisle-research-bot · 2026-02-28T01:21:51Z

🔒 Aisle Security Analysis

✅ We scanned this PR and did not find any security vulnerabilities.

_{Aisle supplements but does not replace security review.}

Analyzed PR: #29260 at commit 3529b2c

greptile-apps · 2026-02-28T01:24:13Z

Greptile Summary

Added url as an alias for targetUrl in browser tool's open and navigate actions to accommodate common LLM/tool caller naming patterns. The implementation uses a fallback pattern (targetUrl ?? url) that maintains full backward compatibility while accepting the more generic url parameter. Error messages consistently report "targetUrl required" when neither parameter is provided, preserving existing error handling behavior.

Implemented readTargetUrlParam() helper that tries targetUrl first, then falls back to url with proper error labeling
Updated both open and navigate actions to use the new helper
Added url as an optional parameter in BrowserToolSchema
Comprehensive test coverage validates the alias works for both actions and preserves error messages

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The change is a straightforward parameter alias addition with excellent test coverage. The implementation maintains full backward compatibility, follows the repository's coding standards, and includes proper error handling. The fallback logic is simple and correct, with no edge cases that could cause runtime errors.
No files require special attention

_{Last reviewed commit: 3529b2c}

* Changelog: add LanceDB custom baseUrl + dimensions entry (#17874) * Changelog: add Ollama autodiscovery hardening entry (#29201) * Changelog: add Ollama context-window unification entry (#29205) * Changelog: add compaction audit injection removal entry (#28507) * Changelog: add browser url alias entry (#29260) * Changelog: add codex weekly usage label entry (#26267)