test: fix pi extra params responses model typing in regression test#29131
Closed
cfregly wants to merge 1 commit intoopenclaw:mainfrom
Closed
test: fix pi extra params responses model typing in regression test#29131cfregly wants to merge 1 commit intoopenclaw:mainfrom
cfregly wants to merge 1 commit intoopenclaw:mainfrom
Conversation
18 tasks
Contributor
Greptile SummaryFixes TypeScript compilation error (TS2352) in Changes:
Confidence Score: 5/5
Last reviewed commit: 2dc8e03 |
Author
|
Superseded by #29244, which is rebased on current Closing this PR to keep review scope unambiguous. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/agents/pi-embedded-runner-extraparams.test.tsfor thesupportsStore=falseregression testModel<"openai-responses">Why
The CI
checkjob currently fails inpnpm tsgobecause that test case casts an object literal that no longer overlaps enough with the newerModel<"openai-responses">type shape.Validation