Skip to content

test: narrow openai responses mock cast to Model type#29244

Open
cfregly wants to merge 1 commit intoopenclaw:mainfrom
cfregly:test-fix-openai-responses-model-mock-typing
Open

test: narrow openai responses mock cast to Model type#29244
cfregly wants to merge 1 commit intoopenclaw:mainfrom
cfregly:test-fix-openai-responses-model-mock-typing

Conversation

@cfregly
Copy link

@cfregly cfregly commented Feb 28, 2026

Summary

  • remove a redundant intersection cast from the OpenAI Responses supportsStore=false regression test
  • keep the change to one line in one file for a minimal, explicit scope

Intent

The previous fix branch was based on an older main tip and had ambiguous scope over time. This PR is a fresh branch from current origin/main with a single, intentional typing cleanup.

Validation

  • pnpm format:check
  • pnpm tsgo
  • pnpm test -- src/agents/pi-embedded-runner-extraparams.test.ts
  • pnpm check

@cfregly cfregly force-pushed the test-fix-openai-responses-model-mock-typing branch from a6cdf2f to e05b3b2 Compare February 28, 2026 00:43
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Removed redundant intersection type from OpenAI Responses model mock in test. The Model<"openai-responses"> type already includes the compat property, making the explicit intersection & { compat?: { supportsStore?: boolean } } unnecessary.

  • Cleaned up typing in src/agents/pi-embedded-runner-extraparams.test.ts:881
  • Change makes the code consistent with other model mocks in the same test file (lines 860, 896)
  • Follows TypeScript best practices by avoiding redundant type annotations

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • This is a minimal, test-only typing cleanup that removes a redundant type intersection. The change has been validated with TypeScript checks and tests, and makes the code more consistent with other similar usages in the same file.
  • No files require special attention

Last reviewed commit: e05b3b2

@openclaw-barnacle
Copy link

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle bot added the stale Marked as stale due to inactivity label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling size: XS stale Marked as stale due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant