fix(feishu): cache probeFeishu() results with 10-min TTL to reduce API calls by Glucksberg · Pull Request #28907 · openclaw/openclaw

Glucksberg · 2026-02-27T15:56:06Z

Summary

Add in-memory caching to probeFeishu() with 10-minute TTL
Reduces Feishu API calls from ~43K/month to ~4.3K/month
Only caches successful probes; failures always make fresh calls
Closes [Feature]: The Feishu plugin's /open-apis/bot/v3/info endpoint is called every minute by Gateway health check. This results in ~43,200 API calls/month, exceeding Feishu's free tier (50,000). #26684

Test plan

Run pnpm vitest run extensions/feishu/src/probe.test.ts
Verify all 11 tests pass including TTL expiry and cache isolation

🤖 Generated with Claude Code

greptile-apps · 2026-02-27T15:58:24Z

Greptile Summary

Added in-memory caching to probeFeishu() with a 10-minute TTL to address excessive API calls from gateway health checks. The implementation successfully reduces Feishu API calls from ~43K/month to ~4.3K/month by caching successful bot info lookups.

Key changes:

Implemented Map-based cache with 10-minute TTL and 64-entry capacity
Only caches successful probes (failures always make fresh API calls)
Cache key based on appId (appropriate since bot metadata is static per app)
Added comprehensive test suite with 11 tests covering caching behavior, TTL expiry, and cache isolation
Exported clearProbeCache() function for test cleanup

Implementation notes:

Cache eviction uses FIFO strategy (deletes oldest inserted entry when capacity exceeded), which is acceptable given the low likelihood of exceeding 64 different appIds in production
Bot info (botName, botOpenId) is tied to appId and doesn't change when appSecret is rotated, so using appId as the sole cache key is correct

Confidence Score: 5/5

This PR is safe to merge - it adds a well-tested, non-breaking caching layer that addresses a real API quota issue
The implementation is clean, well-documented, and thoroughly tested. The caching strategy is sound for the use case (static bot metadata). All edge cases are covered in tests including TTL expiry, cache isolation, and failure handling. No breaking changes or risky logic introduced.
No files require special attention

_{Last reviewed commit: 0daca23}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0daca238df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T15:59:18Z

extensions/feishu/src/probe.ts

  }

+  // Return cached result if still valid
+  const cacheKey = creds.appId;


Include account identity in Feishu probe cache key

probeFeishu caches by appId only, so two accounts that share an appId but have different appSecret/domain can reuse the same cached success result. In that case, a healthy account can mask a misconfigured one (for example after secret rotation), because the second probe returns cached ok: true without making an API call, causing status/health checks to report a false positive for that account. The cache key should include the full credential context (or account ID) to prevent cross-account cache pollution.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aac96d8e63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T22:34:24Z

extensions/feishu/src/probe.ts

+  // Use accountId when available; otherwise include appSecret prefix so two
+  // accounts sharing the same appId (e.g. after secret rotation) don't
+  // pollute each other's cache entry.
+  const cacheKey = creds.accountId ?? `${creds.appId}:${creds.appSecret.slice(0, 8)}`;


Include credential fingerprint in account-scoped probe key

Using accountId alone as the cache key means a successful probe is reused even after that account’s appId, appSecret, or domain is changed, so status checks can report ok: true for up to 10 minutes against now-invalid credentials (for example right after secret rotation or a bad config edit). This regresses probe correctness for the most common call path where probeFeishu receives a resolved account object with accountId set.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-27T22:59:18Z

You have reached your Codex rate limits. Please try again later.

…ls (openclaw#26684)

…account cache pollution

Takhoffman · 2026-02-28T00:15:30Z

PR #28907 - fix(feishu): cache probeFeishu() results with 10-min TTL to reduce API calls (#28907)

Merged via squash.

Merge commit: 60ef923
Verified: pnpm build, pnpm check, pnpm test:macmini
Changes made:
M\tCHANGELOG.md
Why these changes were made:
Required changelog entry for maintainer autoland after strict review; PR code remained intact.
Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @Glucksberg!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4c97d1939

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T00:17:59Z

extensions/feishu/src/probe.ts

+  // Use accountId when available; otherwise include appSecret prefix so two
+  // accounts sharing the same appId (e.g. after secret rotation) don't
+  // pollute each other's cache entry.
+  const cacheKey = creds.accountId ?? `${creds.appId}:${creds.appSecret.slice(0, 8)}`;


Include credential fingerprint in account cache key

When accountId is present, probeFeishu keys the cache only by that ID, so a successful probe is reused even after that account’s appId/appSecret/domain changes; this can report ok: true for up to 10 minutes after a secret rotation or domain misconfiguration while real API calls are already failing. This is especially impactful because status probing passes resolved account objects into probeFeishu, so the stale-hit path is the common runtime path rather than an edge case.

Useful? React with 👍 / 👎.

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 98b8afa)

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 98b8afa)

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 98b8afa)

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 60ef923) # Conflicts: # CHANGELOG.md

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 60ef923) # Conflicts: # CHANGELOG.md # extensions/feishu/src/probe.ts

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…I calls (openclaw#28907) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: M experienced-contributor labels Feb 27, 2026

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

Glucksberg and others added 3 commits February 27, 2026 18:01

feishu: cache probeFeishu() results with 10-min TTL to reduce API cal…

ef7b8e4

…ls (openclaw#26684)

feishu: use account-scoped cache key in probeFeishu to prevent cross-…

018e453

…account cache pollution

docs(changelog): add feishu probe cache note for openclaw#28907

b4c97d1

Takhoffman force-pushed the fix/issue-26684 branch from 7fce831 to b4c97d1 Compare February 28, 2026 00:15

Takhoffman merged commit 60ef923 into openclaw:main Feb 28, 2026
9 checks passed

This was referenced Feb 28, 2026

feat(feishu): add configurable probe cache TTL to reduce API calls #26328

Closed

Feishu: cache probeFeishu() result with 10-min TTL #27133

Closed

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

gemini-code-assist bot mentioned this pull request Mar 1, 2026

chore(sync): replay rollup fixes on upstream/main MillionthOdin16/openclaw#111

Merged

This was referenced Mar 2, 2026

[Bug]: [Critical] Feishu/Lark channel health check interval causes API rate limit exhaustion (Free Tier) [严重] 飞书通道健康检查频率过高导致 API 额度耗尽（免费版） #10549

Closed

Add rate limiting to probeFeishu function #10095

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(feishu): cache probeFeishu() results with 10-min TTL to reduce API calls#28907

fix(feishu): cache probeFeishu() results with 10-min TTL to reduce API calls#28907
Takhoffman merged 3 commits intoopenclaw:mainfrom
Glucksberg:fix/issue-26684

Glucksberg commented Feb 27, 2026

Uh oh!

greptile-apps bot commented Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 27, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Glucksberg commented Feb 27, 2026

Summary

Test plan

Uh oh!

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot commented Feb 27, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants