fix(memory): discard stdout for qmd update/embed to prevent output cap failure by Glucksberg · Pull Request #28900 · openclaw/openclaw

Glucksberg · 2026-02-27T15:52:07Z

Summary

Add discardOutput option to runQmd for update/embed commands
Prevents 200K char limit failure on large QMD indexes during boot sync
Closes QMD boot update fails with large indexes: output exceeds 200K char limit #24966

Test plan

Run pnpm vitest run src/memory/qmd-manager.test.ts
Verify regression test with 300K+ stdout passes

🤖 Generated with Claude Code

greptile-apps · 2026-02-27T15:55:29Z

Greptile Summary

Adds discardOutput option to the runQmd method that prevents accumulation of stdout while preserving stderr for diagnostics, then applies it to qmd update and qmd embed commands to prevent failures when large QMD indexes produce output exceeding the 200K character limit.

Modified runQmd to accept discardOutput boolean option that drains stdout without accumulating
Applied discardOutput: true to all update and embed command calls (3 total call sites)
stderr continues to be captured for error diagnostics regardless of discard setting
Added regression test verifying sync succeeds with 300K+ character stdout output

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The implementation is clean and focused, adds an optional parameter that doesn't affect existing behavior, and includes proper test coverage. The change only affects the specific commands (update/embed) that produce large output, while preserving normal behavior for other commands (search, collection operations). The regression test properly validates the fix with output exceeding the limit.
No files require special attention

_{Last reviewed commit: d6f2769}

chatgpt-codex-connector · 2026-02-27T22:59:15Z

You have reached your Codex rate limits. Please try again later.

chatgpt-codex-connector · 2026-02-28T10:59:42Z

You have reached your Codex rate limits. Please try again later.

chatgpt-codex-connector · 2026-03-01T10:55:55Z

You have reached your Codex rate limits. Please try again later.

aisle-research-bot · 2026-03-01T17:59:48Z

🔒 Aisle Security Analysis

✅ We scanned this PR and did not find any security vulnerabilities.

_{Aisle supplements but does not replace security review.}

Analyzed PR: #28900 at commit 86fde69

_{Last updated on: 2026-03-01T18:17:36Z}

…p failure on large indexes (openclaw#24966)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f653f60b52

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-01T18:02:26Z

src/memory/qmd-manager.ts

+        if (discard) {
+          return; // drain without accumulating


Keep stdout diagnostics on failed discard-output runs

Dropping all stdout when discardOutput is enabled means qmd update/embed failures can lose their only diagnostic text, even though the error path still formats messages as stderr || stdout. In the case where QMD exits non-zero but reports the error on stdout, the thrown message becomes empty and downstream recovery checks like tryRepairNullByteCollections cannot detect ENOTDIR/NUL markers from the process output, so automatic repair can be skipped. Preserve a bounded stdout tail for failure paths instead of discarding it completely.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86fde69f7a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-01T18:16:41Z

src/memory/qmd-manager.ts

-      await this.runQmd(["update"], { timeoutMs: this.qmd.update.updateTimeoutMs });
+      await this.runQmd(["update"], {
+        timeoutMs: this.qmd.update.updateTimeoutMs,
+        discardOutput: true,


Preserve stdout text for failed qmd update repair checks

Passing discardOutput: true into runQmd(["update"]) drops stdout entirely, so a non-zero update that reports errors on stdout now throws with an empty detail string (stderr || stdout becomes empty). That breaks tryRepairNullByteCollections, which classifies recoverable ENOTDIR/null-byte failures from the thrown message and therefore may skip the one-time collection rebuild/retry path. Fresh evidence: both update attempts in runQmdUpdateOnce now set discardOutput: true, so there is no fallback attempt that preserves stdout for this classifier.

Useful? React with 👍 / 👎.

Takhoffman · 2026-03-01T18:17:11Z

PR #28900 - fix(memory): discard stdout for qmd update/embed to prevent output cap failure (#28900)

Merged via squash.

Merge commit: 1342962
Verified: pnpm install --frozen-lockfile, pnpm build, pnpm check, pnpm test:macmini
Changes made:
M CHANGELOG.md
Why these changes were made:
Changelog entry was required by the autoland policy for this user-facing fix.
Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @Glucksberg!

@Glucksberg

…p failure (openclaw#28900) thanks @Glucksberg Cherry-pick of upstream 1342962.

@Glucksberg