fix(feishu): use msg_type "audio" for opus files instead of "media" by Glucksberg · Pull Request #28269 · openclaw/openclaw

Glucksberg · 2026-02-27T04:09:24Z

Summary

Fix Feishu audio (opus) messages failing because sendMediaFeishu sends msg_type: "media" for both audio and video
Per the Feishu API, audio files require msg_type: "audio" while video files use msg_type: "media"
Update sendFileFeishu type signature to accept "audio" as a valid msgType

Closes #25464

Test plan

Send an .opus audio file via Feishu and verify it arrives as a playable voice message (not a fallback text)
Send an .mp4 video file via Feishu and verify it still works with msg_type: "media"
Send a document (PDF/DOC) via Feishu and verify it still works with msg_type: "file"

🤖 Generated with Claude Code

greptile-apps · 2026-02-27T04:12:02Z

Greptile Summary

Fixed Feishu audio message handling by correctly mapping opus files to msg_type: "audio" instead of msg_type: "media" per Feishu API requirements. The change updates both the implementation and type signatures appropriately.

Changed sendMediaFeishu logic to map opus → "audio", mp4 → "media", everything else → "file"
Updated sendFileFeishu type signature to accept "audio" as valid msgType
Updated comments to clarify the API requirements

Issue found: Test file extensions/feishu/src/media.test.ts:132-151 was not updated and will fail. The test expects msg_type: "media" for opus files but should now expect msg_type: "audio".

Confidence Score: 3/5

PR correctly fixes the Feishu audio message issue per API requirements, but will fail CI
Code change is logically correct and properly implements the Feishu API requirement. However, the test file was not updated to match the new behavior, which will cause test failures in CI. Once tests are updated, this would be a safe merge.
extensions/feishu/src/media.test.ts needs update to expect msg_type: "audio" for opus files

_{Last reviewed commit: 2426fcd}

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-27T04:12:05Z

extensions/feishu/src/media.ts

-    // Feishu requires msg_type "media" for audio/video, "file" for documents
-    const isMedia = fileType === "mp4" || fileType === "opus";
+    // Feishu API: opus -> "audio", mp4 -> "media", everything else -> "file"
+    const msgType = fileType === "opus" ? "audio" : fileType === "mp4" ? "media" : "file";


Test case needs update in media.test.ts:132-151. The test "uses msg_type=media for opus" expects msg_type: "media" but should now expect msg_type: "audio"

Suggested change

const msgType = fileType === "opus" ? "audio" : fileType === "mp4" ? "media" : "file";

// Test update needed: rename test to "uses msg_type=audio for opus" and change assertion to expect msg_type: "audio"

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/feishu/src/media.ts Line: 431 Comment: Test case needs update in `media.test.ts:132-151`. The test "uses msg_type=media for opus" expects `msg_type: "media"` but should now expect `msg_type: "audio"` ```suggestion // Test update needed: rename test to "uses msg_type=audio for opus" and change assertion to expect msg_type: "audio" ``` How can I resolve this? If you propose a fix, please make it concise.

Addressed in 0ef6fc2 — the test was updated to assert msg_type: "audio" and renamed accordingly.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2426fcd6be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-27T04:12:20Z

extensions/feishu/src/media.ts

-    // Feishu requires msg_type "media" for audio/video, "file" for documents
-    const isMedia = fileType === "mp4" || fileType === "opus";
+    // Feishu API: opus -> "audio", mp4 -> "media", everything else -> "file"
+    const msgType = fileType === "opus" ? "audio" : fileType === "mp4" ? "media" : "file";


Update opus routing assertions to match new msg_type

This change routes .opus files to msg_type: "audio", but the existing unit test still asserts msg_type: "media" for opus (extensions/feishu/src/media.test.ts, uses msg_type=media for opus), so the Feishu media test suite will fail once this commit lands. Please update the test expectation in the same change to keep CI green and prevent future regressions from being masked by a known-failing assertion.

Useful? React with 👍 / 👎.

Addressed in 0ef6fc2 — test expectation updated to msg_type: "audio" for opus files, matching the new routing logic.

Takhoffman · 2026-02-28T00:23:31Z

PR #28269 - fix(feishu): use msg_type "audio" for opus files instead of "media" (#28269)

Merged via squash.

Merge commit: 1820fd978d2c8e9290f744322ecdb9025f0d4956
Verified: pnpm build, pnpm check, pnpm test:macmini
Changes made:
M CHANGELOG.md
M extensions/feishu/src/media.test.ts
M extensions/feishu/src/media.ts
Why these changes were made:
Fix Feishu opus sends to use the API-required msg_type "audio" instead of "media", while preserving existing mp4/document behavior and adding coverage.
Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @Glucksberg!

Takhoffman · 2026-02-28T00:23:38Z

Correction: merge commit SHA is 0e755ad

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 1fdfa9a)

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 1fdfa9a)

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 1fdfa9a)

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 0e755ad) # Conflicts: # CHANGELOG.md # extensions/feishu/src/media.ts

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 0e755ad) # Conflicts: # CHANGELOG.md

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Glucksberg

…penclaw#28269) thanks @Glucksberg Verified: - pnpm build - pnpm check - pnpm test:macmini Co-authored-by: Glucksberg <80581902+Glucksberg@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: XS experienced-contributor labels Feb 27, 2026

greptile-apps bot reviewed Feb 27, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 27, 2026

View reviewed changes

Takhoffman force-pushed the fix/issue-25464 branch from ebdcf74 to 132ead0 Compare February 28, 2026 00:22

Glucksberg and others added 3 commits February 27, 2026 18:22

fix(feishu): use msg_type "audio" for opus files instead of "media"

c549ecf

test(feishu): update opus msg_type assertion to audio

4420f30

Feishu: add changelog entry for opus audio msg_type fix

a96c7c0

Takhoffman force-pushed the fix/issue-25464 branch from 132ead0 to a96c7c0 Compare February 28, 2026 00:23

Takhoffman merged commit 0e755ad into openclaw:main Feb 28, 2026
9 checks passed

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

gemini-code-assist bot mentioned this pull request Mar 1, 2026

chore(sync): replay rollup fixes on upstream/main MillionthOdin16/openclaw#111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(feishu): use msg_type "audio" for opus files instead of "media"#28269

fix(feishu): use msg_type "audio" for opus files instead of "media"#28269
Takhoffman merged 3 commits intoopenclaw:mainfrom
Glucksberg:fix/issue-25464

Glucksberg commented Feb 27, 2026

Uh oh!

greptile-apps bot commented Feb 27, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 27, 2026

Uh oh!

Glucksberg Feb 27, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Uh oh!

Glucksberg Feb 27, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const msgType = fileType === "opus" ? "audio" : fileType === "mp4" ? "media" : "file";
	// Test update needed: rename test to "uses msg_type=audio for opus" and change assertion to expect msg_type: "audio"

Uh oh!

Conversation

Glucksberg commented Feb 27, 2026

Summary

Test plan

Uh oh!

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Confidence Score: 3/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Glucksberg Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Glucksberg Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants