fix(browser): prevent stdio buffer blocking in Docker environments#27899
fix(browser): prevent stdio buffer blocking in Docker environments#27899stephenschoettler wants to merge 2 commits intoopenclaw:mainfrom
Conversation
Prevents crash when totals is undefined in byModel/byProvider/byAgent sort comparators. Fixes 'Cannot read properties of undefined (reading totalTokens)' crash that causes context overflow in active sessions.
Greptile SummaryThis PR contains two separate bug fixes:
Note: The PR title only mentions the browser fix, but includes the unrelated usage fix as well. According to the project's guidelines (CLAUDE.md), unrelated changes should typically be in separate PRs. Both fixes are valid, but bundling them may make the PR history harder to track. Confidence Score: 4/5
Last reviewed commit: 200f8c0 |
|
This pull request has been automatically marked as stale due to inactivity. |
Fixes browser automation failures in Docker by changing Chrome spawn configuration from
stdio: "pipe"tostdio: ["ignore", "ignore", "ignore"].Problem: When using
stdio: "pipe", Chrome's stdout/stderr buffers fill up (~64KB limit) and block the process, preventing CDP from becoming reachable within the timeout window.Solution: Discard Chrome's output instead of piping it. The codebase doesn't consume Chrome's stdout/stderr anyway, so there's no functional loss.
Result: CDP becomes reachable within ~500ms of Chrome startup in Docker.
Tested manually in Docker with Playwright Chromium on Debian 12.