fix(models): inherit baseUrl and api from provider config by lploc94 · Pull Request #2740 · openclaw/openclaw

lploc94 · 2026-01-27T11:57:04Z

Summary

Fix bug where custom provider's baseUrl and api were not inherited by
inline model definitions
Models now correctly use the provider's endpoint and API format

Problem

When configuring a custom provider with baseUrl and api at the provider
level:

"myProvider": {                                                                  
  "baseUrl": "http://localhost:10000",                                           
  "api": "anthropic-messages",                                                   
  "models": [{ "name": "claude-opus-4.5" }]                                      
}                                                                                
The individual models did not inherit these settings, causing requests to fail   
with 401 or be sent to wrong endpoints.                                          
                                                                                 
Test plan                                                                        
                                                                                 
- Lint passes (npm run lint)                                                     
- Unit tests pass (vitest run src/agents/pi-embedded-runner/model.test.ts)       
- Manual test with custom provider pointing to local server

Copilot

Pull request overview

This PR fixes a bug where custom provider configurations (baseUrl and api) were not being inherited by inline model definitions. When users configured a custom provider with these settings at the provider level, individual models within that provider would fail to inherit these configurations, causing requests to fail with 401 errors or be sent to incorrect endpoints.

Changes:

Updated buildInlineProviderModels to inherit baseUrl and api from provider configuration to inline models
Modified InlineModelEntry type to include baseUrl field
Updated resolveModel fallback model creation to include baseUrl from provider config

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T12:00:36Z

src/agents/pi-embedded-runner/model.ts

+    return (entry?.models ?? []).map((model) => ({
+      ...model,
+      provider: trimmed,
+      baseUrl: entry?.baseUrl,
+      api: model.api ?? entry?.api,
+    }));


The existing test for buildInlineProviderModels does not verify the new behavior introduced in this fix. The test should be updated to verify that baseUrl and api are correctly inherited from the provider configuration.

Consider adding a test case that verifies:

baseUrl is inherited from the provider when models don't specify it

api is inherited from the provider when models don't specify it

Model-level api takes precedence over provider-level api when both are present

lploc94 · 2026-01-27T12:19:50Z

CI is failing due to the workspace dependency issue (clawdbot@workspace:* in extensions/googlechat). Waiting for #2739 to be merged, then I'll rebase this PR. The actual code changes pass lint and tests locally.

When using custom providers with inline model definitions, the baseUrl and api properties from the provider config were not being passed to the individual models. This caused requests to be sent to the wrong endpoint or with the wrong API format. Changes: - buildInlineProviderModels now copies baseUrl from provider to models - buildInlineProviderModels now inherits api from provider if not set on model - resolveModel fallback path now includes baseUrl from provider config Co-Authored-By: Claude (claude-opus-4.5) <noreply@anthropic.com>

Add test cases to verify: - baseUrl is inherited from provider when model does not specify it - api is inherited from provider when model does not specify it - model-level api takes precedence over provider-level api - both baseUrl and api can be inherited together Co-Authored-By: Claude (claude-opus-4.5) <noreply@anthropic.com>