fix: suppress SUBAGENT_SPAWN_ACCEPTED_NOTE for cron isolated sessions by kevinWangSheng · Pull Request #27330 · openclaw/openclaw

kevinWangSheng · 2026-02-26T08:17:57Z

Summary

Fixes issue #27308 - Cron isolated sessions break with sessions_spawn because the 'do not poll/sleep' note causes premature turn completion.

Root Cause

When the agent sees the SUBAGENT_SPAWN_ACCEPTED_NOTE ("auto-announces on completion, do not poll/sleep"), it immediately responds with "Waiting for sub-agents..." and the turn completes. In cron isolated sessions, the turn ending means the cron job finalizes, so subagent results are never collected.

Fix

Detect cron sessions by checking if starts with "cron:" and suppress the note in that case. This allows the agent to wait naturally for subagent results, keeping the turn alive until subagents complete.

Testing

TypeScript compiles without errors
Need to test with actual cron job with sessions_spawn

- Modified assertSystemdAvailable to check both user and system scope - Added detectSystemdScope function for explicit scope detection - Updated execSystemctl to support optional --user flag - Fixes openclaw#27267: openclaw status incorrectly reports 'systemd not installed' when gateway is running via systemd

Cron isolated sessions end immediately after the agent produces a response. When the agent sees the 'do not poll/sleep' note, it immediately responds with 'Waiting for sub-agents...' and the turn completes prematurely, before subagent results are collected. This fix detects cron sessions (by checking if agentSessionKey starts with 'cron:') and suppresses the note in that case, allowing the agent to wait naturally for subagent results. Fixes openclaw#27308

greptile-apps · 2026-02-26T08:20:03Z

Greptile Summary

This PR includes two separate fixes: (1) suppresses the "do not poll/sleep" note for cron isolated sessions to prevent premature turn completion, and (2) improves systemd detection to check both user and system scopes. The cron session fix correctly detects cron sessions by checking if agentSessionKey starts with cron: and suppresses the note that would cause the agent to immediately end the turn before collecting subagent results.

Fixed cron isolated sessions breaking with sessions_spawn by suppressing SUBAGENT_SPAWN_ACCEPTED_NOTE
Added systemd scope detection for both user and system services
Critical bug: Line 148 in systemd.ts uses --status flag which doesn't exist - will cause runtime failure when checking systemd availability

Confidence Score: 2/5

This PR has a critical syntax error that will cause runtime failures when checking systemd user service availability.
The cron session fix is well-implemented and addresses the stated issue correctly, but the systemd changes contain a critical bug on line 148 where --status is used instead of status, which will cause the systemd detection to fail. This is a straightforward syntax error that needs to be fixed before merging.
src/daemon/systemd.ts requires attention - line 148 has an invalid systemctl command that will cause runtime errors.

_{Last reviewed commit: 0acf294}

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-26T08:20:07Z

src/daemon/systemd.ts


 export async function isSystemdUserServiceAvailable(): Promise<boolean> {
-  const res = await execSystemctl(["--user", "status"]);
+  const res = await execSystemctl(["--status"], true);


--status is invalid - systemctl doesn't have a --status flag. Should be status without the double dash since execSystemctl will prepend --user when useUser is true.

Suggested change

const res = await execSystemctl(["--status"], true);

const res = await execSystemctl(["status"], true);

Prompt To Fix With AI

This is a comment left during a code review. Path: src/daemon/systemd.ts Line: 148 Comment: `--status` is invalid - systemctl doesn't have a `--status` flag. Should be `status` without the double dash since `execSystemctl` will prepend `--user` when `useUser` is true. ```suggestion const res = await execSystemctl(["status"], true); ``` How can I resolve this? If you propose a fix, please make it concise.

Lukavyi · 2026-02-26T10:14:56Z

@kevinWangSheng thanks for the fix!
Pls check out greptile's comments
Looks like your systemd change is not relevant to the issue, maybe commited by mistake?

Lukavyi · 2026-02-26T11:16:54Z

Bug in `isCronSession` check

The current check:

const isCronSession = ctx.agentSessionKey?.startsWith("cron:");

Never matches. The agentSessionKey format for cron isolated sessions is:

agent:main:cron:dd871818-8eae-4218-a3b3-862e0f077b1e:run:cf959c9f-...

It starts with "agent:", not "cron:". Fix:

const isCronSession = ctx.agentSessionKey?.includes(":cron:");

Verified locally

I applied this one-line fix, rebuilt, and tested:

Check	Duration	Result
`startsWith("cron:")` (this PR)	43s	❌ "Sub-agents launched. Waiting for results..."
`includes(":cron:")` (fixed)	257s	✅ Full news digest with 30+ items, delivered

The includes version correctly suppresses the SUBAGENT_SPAWN_ACCEPTED_NOTE, allowing the cron agent to poll/wait for subagent results instead of immediately ending the turn.

Minor note

After the cron run completes, subagents still attempt to announce back to the (now dead) cron session, producing "Subagent announce direct announce agent call transient failure" warnings in the console. This is cosmetic and does not affect delivery, but could be a follow-up cleanup.

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR openclaw#27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes openclaw#27308 Fixes openclaw#25069

Lukavyi · 2026-02-26T11:24:15Z

Alternative fix with corrected session key check and tests: PR #27470

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR openclaw#27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes openclaw#27308 Fixes openclaw#25069

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR #27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes #27308 Fixes #25069

obviyus · 2026-02-26T12:27:18Z

Fixed by 69590de.

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR openclaw#27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes openclaw#27308 Fixes openclaw#25069

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR openclaw#27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes openclaw#27308 Fixes openclaw#25069 (cherry picked from commit 69590de) # Conflicts: # src/agents/subagent-spawn.ts

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR openclaw#27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes openclaw#27308 Fixes openclaw#25069

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR openclaw#27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes openclaw#27308 Fixes openclaw#25069 (cherry picked from commit 69590de) # Conflicts: # src/agents/subagent-spawn.ts

The 'do not poll/sleep' note added to sessions_spawn tool results causes cron isolated agents to immediately end their turn, since the note tells them not to wait for subagent results. In cron isolated sessions, the agent turn IS the entire run, so ending early means subagent results are never collected. Fix: detect cron sessions via includes(':cron:') in agentSessionKey and suppress the note, allowing the agent to poll/wait naturally. Note: PR openclaw#27330 used startsWith('cron:') which never matches because the session key format is 'agent:main:cron:...' (starts with 'agent:'). Fixes openclaw#27308 Fixes openclaw#25069

Kevin Shenghui added 2 commits February 26, 2026 00:08

openclaw-barnacle bot added gateway Gateway runtime agents Agent runtime and tooling size: S labels Feb 26, 2026

greptile-apps bot reviewed Feb 26, 2026

View reviewed changes

Lukavyi mentioned this pull request Feb 26, 2026

fix: suppress SUBAGENT_SPAWN_ACCEPTED_NOTE for cron isolated sessions #27470

Merged

obviyus closed this Feb 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: suppress SUBAGENT_SPAWN_ACCEPTED_NOTE for cron isolated sessions#27330

fix: suppress SUBAGENT_SPAWN_ACCEPTED_NOTE for cron isolated sessions#27330
kevinWangSheng wants to merge 2 commits intoopenclaw:mainfrom
kevinWangSheng:fix/cron-sessions-spawn-note

kevinWangSheng commented Feb 26, 2026

Uh oh!

greptile-apps bot commented Feb 26, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 26, 2026

Uh oh!

Lukavyi commented Feb 26, 2026 •

edited

Loading

Uh oh!

Lukavyi commented Feb 26, 2026

Uh oh!

Lukavyi commented Feb 26, 2026

Uh oh!

obviyus commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	const res = await execSystemctl(["--status"], true);
	const res = await execSystemctl(["status"], true);

Uh oh!

Conversation

kevinWangSheng commented Feb 26, 2026

Summary

Root Cause

Fix

Testing

Related

Uh oh!

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Confidence Score: 2/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Lukavyi commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lukavyi commented Feb 26, 2026

Bug in isCronSession check

Verified locally

Minor note

Uh oh!

Lukavyi commented Feb 26, 2026

Uh oh!

obviyus commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lukavyi commented Feb 26, 2026 •

edited

Loading

Bug in `isCronSession` check