fix(feishu): pass proxy agent to WSClient for proxy environments by colin719 · Pull Request #26397 · openclaw/openclaw

colin719 · 2026-02-25T10:42:31Z

Summary

Feishu WSClient (ws library) ignores https_proxy / HTTP_PROXY env vars, causing WebSocket connection failures in proxy environments (e.g. WSL2 with a local HTTP proxy)
Detect proxy env vars and pass an HttpsProxyAgent to Lark.WSClient via its existing agent constructor option
https-proxy-agent is already a dependency of @openclaw/feishu — no new packages added

Root Cause

The Lark SDK's pullConnectConfig() uses axios (which respects https_proxy), so fetching the WS endpoint URL succeeds. But the actual WebSocket connection uses the ws library, which does not automatically use proxy env vars. The SDK's WSClient constructor accepts an agent option for this purpose, but it was not being passed.

Test plan

Verified on WSL2 + Ubuntu with https_proxy=http://127.0.0.1:7897
Before fix: [ws] ws connect failed → [ws] connect failed → infinite reconnect loop
After fix: [ws] ws client ready immediately, no errors
When no proxy env vars are set, getWsProxyAgent() returns undefined and behavior is unchanged

🤖 Generated with Claude Code

Greptile Summary

Adds proxy support to Feishu WebSocket connections by detecting proxy environment variables and passing an HttpsProxyAgent to the Lark SDK's WSClient constructor.

Introduced getWsProxyAgent() helper that checks https_proxy, HTTPS_PROXY, http_proxy, and HTTP_PROXY environment variables
Conditionally passes the agent to Lark.WSClient via its existing agent option
Uses https-proxy-agent package already present in root dependencies
Follows the same pattern as Discord's proxy implementation in src/discord/monitor/gateway-plugin.ts
When no proxy env vars are set, behavior remains unchanged (agent is undefined)

The fix addresses the issue where the Lark SDK's WebSocket library (ws) does not automatically respect proxy environment variables, causing connection failures in proxy environments like WSL2 with local HTTP proxies.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The change is minimal, well-tested in the author's environment, and follows established patterns in the codebase. The implementation correctly checks standard proxy environment variables, uses an existing dependency, and only adds the agent option when needed. The conditional spreading pattern ensures backward compatibility when no proxy is configured. The existing test mocks will continue to work, and the change cannot introduce regressions since it only activates when proxy environment variables are explicitly set.
No files require special attention

_{Last reviewed commit: 96ead87}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

…PS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Takhoffman · 2026-02-28T05:15:22Z

Autoland update:

Added missing Feishu plugin runtime dependency for https-proxy-agent in extensions/feishu/package.json (plugin install safety).
Added regression tests in extensions/feishu/src/client.test.ts to cover WS proxy env precedence and agent wiring.
Added changelog entry for Feishu WS proxy behavior.
Resolved post-rebase lockfile conflict and revalidated full gates.

Verification run (post-rebase):

pnpm install --frozen-lockfile
pnpm build
pnpm check
pnpm test:macmini

Merged via squash at 0a23739c3795d38292a2a20072f893b952b82f88.

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 7299b01)

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 0a23739) # Conflicts: # CHANGELOG.md

…nclaw#26397) Cherry-pick of upstream 0a23739.

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 0a23739) # Conflicts: # CHANGELOG.md # extensions/feishu/src/client.ts

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…nclaw#26397) Cherry-pick of upstream 0a23739.

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…nclaw#26397) * fix(feishu): pass proxy agent to WSClient for environments behind HTTPS proxy The Lark SDK WSClient uses the `ws` library which does not automatically respect https_proxy/HTTP_PROXY environment variables. This causes WebSocket connection failures in proxy environments (e.g. WSL2 with a local proxy). Detect proxy env vars and pass an HttpsProxyAgent to WSClient via the existing `agent` constructor option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): add generic type parameter to HttpsProxyAgent return type Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(feishu): wire ws proxy dependency and coverage * chore(lockfile): resolve axios peer lock entry after rebase --------- Co-authored-by: lirui <lirui@fxiaoke.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: XS labels Feb 25, 2026

lirui and others added 4 commits February 27, 2026 22:48

fix(feishu): add generic type parameter to HttpsProxyAgent return type

4a6a0c2

Fix TS2314: `HttpsProxyAgent<Uri>` requires a type argument. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix(feishu): wire ws proxy dependency and coverage

3ae547f

chore(lockfile): resolve axios peer lock entry after rebase

efb4845

Takhoffman force-pushed the fix/feishu-ws-proxy branch from c167331 to efb4845 Compare February 28, 2026 05:15

Takhoffman merged commit 0a23739 into openclaw:main Feb 28, 2026
9 checks passed

openclaw-barnacle bot added size: S and removed size: XS labels Feb 28, 2026

github-actions bot mentioned this pull request Feb 28, 2026

📡 Upstream Digest — 2026-02-28 06:28 UTC curtismercier/openclaw-mods#143

Open

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream deps/security commits (2026-03-01-0443) hughdidit/DAISy-Agency#138

Closed

6 tasks

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 1, 2026

fix(feishu): pass proxy agent to WSClient for proxy environments (ope…

6e2621d

…nclaw#26397) Cherry-pick of upstream 0a23739.

github-actions bot mentioned this pull request Mar 3, 2026

cherry-pick: upstream deps/security commits (2026-03-02-2346) hughdidit/DAISy-Agency#144

Closed

6 tasks

keepmind9 mentioned this pull request Mar 5, 2026

fix(feishu): add HTTP proxy support for API client #35540

Open

4 tasks

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

fix(feishu): pass proxy agent to WSClient for proxy environments (ope…

c3ab74d

…nclaw#26397) Cherry-pick of upstream 0a23739.

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: Feishu adapter — community PRs and fixes remoteclaw/remoteclaw#678

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(feishu): pass proxy agent to WSClient for proxy environments#26397

fix(feishu): pass proxy agent to WSClient for proxy environments#26397
Takhoffman merged 4 commits intoopenclaw:mainfrom
colin719:fix/feishu-ws-proxy

colin719 commented Feb 25, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

colin719 commented Feb 25, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root Cause

Test plan

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

colin719 commented Feb 25, 2026 •

edited by greptile-apps bot

Loading