fix(slack): honor replyToModeByChatType when ThreadLabel exists by dbachelder · Pull Request #26251 · openclaw/openclaw

dbachelder · 2026-02-25T07:32:30Z

Problem

buildSlackThreadingToolContext uses ThreadLabel to force replyToMode="all", overriding per-chat-type configuration like replyToModeByChatType.direct: "off".

ThreadLabel is a session/conversation label — not a reliable signal that the inbound Slack message is an actual thread reply. It's present in all DM sessions, so DMs always thread regardless of config.

Fix

Switch from ThreadLabel to MessageThreadId, which is only set when the user actually replies inside a Slack thread:

// Before:
const effectiveReplyToMode = params.context.ThreadLabel ? "all" : configuredReplyToMode;

// After:
const hasExplicitThreadTarget = params.context.MessageThreadId != null;
const effectiveReplyToMode = hasExplicitThreadTarget ? "all" : configuredReplyToMode;

Behavior

Scenario	replyToMode
Normal DM (no thread)	Respects config (e.g. `direct: "off"`)
DM reply inside a thread	Forces `"all"` (thread preserved)
Channel message (no thread)	Respects config
Channel reply inside a thread	Forces `"all"` (thread preserved)

Test plan

Regression: ThreadLabel alone does NOT force "all" — honors direct: "off" config
Thread preservation: MessageThreadId present forces "all" even when direct: "off" configured
Channel safety: non-thread channel messages respect replyToModeByChatType config
Existing tests for top-level, chat-type overrides, legacy dm.replyToMode, and default behavior unchanged

Greptile Summary

Fixes threading behavior to correctly honor per-chat-type replyToMode configuration. Replaces unreliable ThreadLabel check (set for all thread contexts including DMs) with MessageThreadId check (only set when user explicitly replies in a Slack thread).

Prevented unintended threading in DMs when replyToModeByChatType.direct: "off" is configured
Preserved thread replies when users explicitly reply inside Slack threads (forces replyToMode="all")
Added comprehensive test coverage for the regression and thread preservation scenarios

Confidence Score: 5/5

This PR is safe to merge with no risk
The fix is a simple, well-tested logic change that correctly addresses the root cause. The implementation uses the appropriate field (MessageThreadId which is only set for actual thread replies) instead of the incorrect field (ThreadLabel which is a conversation label). Comprehensive test coverage validates both the fix and preservation of existing behavior.
No files require special attention

_{Last reviewed commit: 38dae53}

ThreadLabel is a session/conversation label, not a reliable indicator of an actual Slack thread reply. Using it to force replyToMode="all" overrides replyToModeByChatType.direct="off" in DMs. Switch to MessageThreadId which indicates a real thread target is available, preserving expected behavior: thread replies stay threaded, normal DMs respect the configured mode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Takhoffman · 2026-03-01T17:02:16Z

Merged via salvage path.

Merge commit: 46da76e
Head commit pinned: b7ff534

What changed before merge:

rebased onto latest main (clean)
preserved the targeted fix: force replyToMode="all" only when explicit thread target exists instead of using ThreadLabel
added missing changelog entry for this Slack threading regression fix

Verification run on the rebased branch:

CI=true pnpm install --frozen-lockfile
pnpm build
pnpm check
pnpm test:macmini

All checks passed.

…claw#26251) Cherry-pick of upstream 46da76e.

…claw#26251) * fix(slack): honor direct replyToMode when thread label exists ThreadLabel is a session/conversation label, not a reliable indicator of an actual Slack thread reply. Using it to force replyToMode="all" overrides replyToModeByChatType.direct="off" in DMs. Switch to MessageThreadId which indicates a real thread target is available, preserving expected behavior: thread replies stay threaded, normal DMs respect the configured mode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Slack: add changelog for threading tool context fix --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…claw#26251) * fix(slack): honor direct replyToMode when thread label exists ThreadLabel is a session/conversation label, not a reliable indicator of an actual Slack thread reply. Using it to force replyToMode="all" overrides replyToModeByChatType.direct="off" in DMs. Switch to MessageThreadId which indicates a real thread target is available, preserving expected behavior: thread replies stay threaded, normal DMs respect the configured mode. * Slack: add changelog for threading tool context fix --------- Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…claw#26251) Cherry-pick of upstream 46da76e.

openclaw-barnacle bot added channel: slack Channel integration: slack size: S labels Feb 25, 2026

widingmarcus-cyber mentioned this pull request Feb 25, 2026

fix(test): add missing setSessionRuntimeModel mock to cron skill-filter tests #26333

Closed

dbachelder and others added 2 commits March 1, 2026 10:43

Slack: add changelog for threading tool context fix

b7ff534

Takhoffman force-pushed the fix/slack-dm-threading-honor-config branch from 38dae53 to b7ff534 Compare March 1, 2026 17:01

Takhoffman merged commit 46da76e into openclaw:main Mar 1, 2026
9 checks passed

vabole mentioned this pull request Mar 1, 2026

ops: decision needed for upstream sync (1 disputed files) vabole/openclaw#4

Merged

1 task

github-actions bot mentioned this pull request Mar 1, 2026

📡 Upstream Digest — 2026-03-01 18:22 UTC curtismercier/openclaw-mods#154

Open

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 1, 2026

fix(slack): honor replyToModeByChatType when ThreadLabel exists (open…

ee7cccc

…claw#26251) Cherry-pick of upstream 46da76e.

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

fix(slack): honor replyToModeByChatType when ThreadLabel exists (open…

fc5ef7b

…claw#26251) Cherry-pick of upstream 46da76e.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(slack): honor replyToModeByChatType when ThreadLabel exists#26251

fix(slack): honor replyToModeByChatType when ThreadLabel exists#26251
Takhoffman merged 2 commits intoopenclaw:mainfrom
dbachelder:fix/slack-dm-threading-honor-config

dbachelder commented Feb 25, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

Uh oh!

Takhoffman commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dbachelder commented Feb 25, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Behavior

Test plan

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Takhoffman commented Mar 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dbachelder commented Feb 25, 2026 •

edited by greptile-apps bot

Loading