fix(followup): fall back to dispatcher when same-channel origin routing fails by Sid-Qin · Pull Request #26109 · openclaw/openclaw

Sid-Qin · 2026-02-25T04:28:57Z

Summary

Problem: Feishu DM replies are silently dropped when routeReply fails (e.g., outbound adapter unavailable, plugin not fully loaded, API error), making the Feishu channel unusable
Why it matters: 100% repro — users never receive agent replies in Feishu DM
What changed: In sendFollowupPayloads (src/auto-reply/reply/followup-runner.ts), when routeReply fails and originatingChannel === messageProvider (same channel), the reply now falls back to onBlockReply — the dispatcher created by the same channel's handler
What did NOT change: Cross-channel routing failures (origin ≠ provider) still drop the payload to preserve origin isolation

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes [Bug]: Feishu message reply routed to wrong channel #25767

User-visible / Behavior Changes

Feishu DM replies now reach users when the outbound routing adapter fails. Previously the reply was silently dropped; now it falls back to the channel's native dispatcher.

Security Impact (required)

New permissions/capabilities? No
Secrets/tokens handling changed? No
New/changed network calls? No
Command/tool execution surface changed? No
Data access scope changed? No

Repro + Verification

Environment

Integration/channel: Feishu (DM)

Steps

Configure Feishu channel with DM enabled
Send a DM message to the bot from Feishu
Bot processes the message and generates a reply

Expected

Reply is sent back to Feishu DM

Actual (before fix)

Reply is silently dropped; followup queue: route-reply failed logged but no fallback attempted

Evidence

Failing test/log before + passing after
New test: same-channel fallback (feishu → feishu) delivers via onBlockReply when routeReply fails
Existing test: cross-channel (discord origin, webchat provider) still does NOT fall back
All 471 auto-reply/reply tests pass

Human Verification (required)

Verified scenarios: same-channel fallback (feishu→feishu), cross-channel isolation (discord origin + webchat provider)
Edge cases checked: missing messageProvider, missing onBlockReply, successful routeReply (no fallback triggered)
What you did not verify: live Feishu bot end-to-end

Compatibility / Migration

Backward compatible? Yes
Config/env changes? No
Migration needed? No

Failure Recovery (if this breaks)

How to disable/revert this change quickly: Revert commit 13b4b6b
Files/config to restore: src/auto-reply/reply/followup-runner.ts
Known bad symptoms: Same-channel replies being double-delivered (once via routeReply success + once via fallback)

Risks and Mitigations

Risk: If routeReply returns { ok: false } but the message was actually delivered (partial success), the fallback could cause a duplicate
- Mitigation: routeReply only returns ok: false when delivery definitively failed; the fallback condition also requires originatingChannel === messageProvider to prevent cross-channel leakage

…ng fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com>

@Sid-Qin

…hanks @Sid-Qin)

steipete · 2026-02-25T04:52:19Z

Landed via temp rebase onto main.

Gate: pnpm test src/auto-reply/reply/followup-runner.test.ts && pnpm check
Land commit: 0ca4412
Merge commit: f7de41c

Thanks @Sid-Qin!

@Sid-Qin

…ng fails (openclaw#26109) * fix(followup): fall back to dispatcher when same-channel origin routing fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: allow same-channel followup fallback routing (openclaw#26109) (thanks @Sid-Qin) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@Sid-Qin

…ng fails (openclaw#26109) * fix(followup): fall back to dispatcher when same-channel origin routing fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: allow same-channel followup fallback routing (openclaw#26109) (thanks @Sid-Qin) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@Sid-Qin

…ng fails (openclaw#26109) * fix(followup): fall back to dispatcher when same-channel origin routing fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: allow same-channel followup fallback routing (openclaw#26109) (thanks @Sid-Qin) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@Sid-Qin

…ng fails (openclaw#26109) * fix(followup): fall back to dispatcher when same-channel origin routing fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: allow same-channel followup fallback routing (openclaw#26109) (thanks @Sid-Qin) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@Sid-Qin

…ng fails (openclaw#26109) * fix(followup): fall back to dispatcher when same-channel origin routing fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: allow same-channel followup fallback routing (openclaw#26109) (thanks @Sid-Qin) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@Sid-Qin

…ng fails (openclaw#26109) * fix(followup): fall back to dispatcher when same-channel origin routing fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: allow same-channel followup fallback routing (openclaw#26109) (thanks @Sid-Qin) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@Sid-Qin

…ng fails (openclaw#26109) * fix(followup): fall back to dispatcher when same-channel origin routing fails When routeReply fails for an originating channel that matches the session's messageProvider, the onBlockReply callback was created by that same channel's handler and can safely deliver the reply. Previously the payload was silently dropped on any routeReply failure, causing Feishu DM replies to never reach the user. Cross-channel fallback (origin ≠ provider) still drops the payload to preserve origin isolation. Closes openclaw#25767 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: allow same-channel followup fallback routing (openclaw#26109) (thanks @Sid-Qin) --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

openclaw-barnacle bot added size: S experienced-contributor labels Feb 25, 2026

SidQin-cyber and others added 2 commits February 25, 2026 04:49

fix: allow same-channel followup fallback routing (openclaw#26109) (t…

0ca4412

…hanks @Sid-Qin)

steipete force-pushed the fix/feishu-dm-reply-routing-25767 branch from 13b4b6b to 0ca4412 Compare February 25, 2026 04:52

steipete merged commit f7de41c into openclaw:main Feb 25, 2026
10 checks passed

github-actions bot mentioned this pull request Feb 25, 2026

📡 Upstream Digest — 2026-02-25 06:54 UTC curtismercier/openclaw-mods#122

Open

arjunaskykok mentioned this pull request Feb 26, 2026

fix/test a2ui bundle preflight #27345

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(followup): fall back to dispatcher when same-channel origin routing fails#26109

fix(followup): fall back to dispatcher when same-channel origin routing fails#26109
steipete merged 2 commits intoopenclaw:mainfrom
Sid-Qin:fix/feishu-dm-reply-routing-25767

Sid-Qin commented Feb 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

steipete commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Sid-Qin commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual (before fix)

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

Uh oh!

steipete commented Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sid-Qin commented Feb 25, 2026 •

edited

Loading