fix(slack): map legacy streaming=false to off#26020

Merged

Takhoffman merged 3 commits intoopenclaw:mainfrom

chilu18:fix/slack-streaming-false-off-25990

Mar 1, 2026

Contributor

chilu18 commented Feb 25, 2026 •

edited by greptile-apps bot

Loading

Summary

map legacy channels.slack.streaming booleans to unified streaming mode (false -> off, true -> partial)
keep nativeStreaming migration behavior unchanged
add regression coverage for Slack streaming normalization and config validation

Testing

corepack pnpm vitest --run src/slack/stream-mode.test.ts src/config/config.legacy-config-detection.rejects-routing-allowfrom.test.ts src/commands/doctor-legacy-config.test.ts
corepack pnpm vitest --run src/commands/doctor-legacy-config.migrations.test.ts

Closes #25990

Greptile Summary

Fixed legacy Slack streaming boolean mapping to properly convert false → "off" instead of always defaulting to "partial", bringing it in line with Discord and Telegram channel behavior.

Updated resolveSlackStreamingMode in src/config/discord-preview-streaming.ts:125-126 to map boolean values correctly
Added regression test coverage in src/slack/stream-mode.test.ts for both true and false cases
Added migration test in src/commands/doctor-legacy-config.test.ts to verify streaming: false maps to both streaming: "off" and nativeStreaming: false
Updated existing test expectation in src/config/config.legacy-config-detection.rejects-routing-allowfrom.test.ts:600

Confidence Score: 5/5

This PR is safe to merge with no risk
The changes are minimal, well-tested, and fix a clear logical bug. The fix brings Slack boolean mapping in line with Discord and Telegram. All affected code paths have corresponding test coverage, and the migration logic properly handles backward compatibility.
No files require special attention

_{Last reviewed commit: 475962e}

openclaw-barnacle bot added channel: slack commands size: XS trusted-contributor labels

This was referenced Mar 1, 2026

fix(slack): resolve streaming: false to "off" instead of "partial" #25995

Closed

fix: Slack streaming: false resolves to "off" instead of "partial" #26173

Closed

fix(slack): streaming: false now disables all streaming including draft preview #23819

Closed

Takhoffman force-pushed the fix/slack-streaming-false-off-25990 branch from 475962e to 8b1532e Compare

March 1, 2026 16:20

aisle-research-bot bot commented Mar 1, 2026 •

edited

Loading

🔒 Aisle Security Analysis

✅ We scanned this PR and did not find any security vulnerabilities.

_{Aisle supplements but does not replace security review.}

Analyzed PR: #26020 at commit 8b1532e

chilu18 and others added 3 commits

March 1, 2026 10:20


          fix(slack): map legacy streaming=false to off

d08efea


          docs(changelog): record slack legacy streaming=false mapping fix

29d6b58


          test(doctor): fix legacy config helper reference in slack case

f8b1e2f

Takhoffman force-pushed the fix/slack-streaming-false-off-25990 branch from 8b1532e to f8b1e2f Compare

March 1, 2026 16:21

Takhoffman merged commit dfbdab5 into openclaw:main

Contributor

Takhoffman commented Mar 1, 2026

PR #26020 - fix(slack): map legacy streaming=false to off (#26020)

Merged via squash.

Merge commit: dfbdab5
Verified: pnpm build, pnpm check, pnpm test:macmini
Changes made:
M\tCHANGELOG.md
M\tsrc/commands/doctor-legacy-config.test.ts
Why these changes were made:
Added the required changelog entry and fixed a blocking test helper reference () so the canonical streaming=false behavior fix passes strict gates on latest main.
Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @chilu18!

Contributor

Takhoffman commented Mar 1, 2026

Correction on merge summary details:

Changes made: CHANGELOG.md, src/commands/doctor-legacy-config.test.ts
Why: add required changelog entry and fix the blocking test helper reference (normalizeCompatibilityConfigValues) so this canonical streaming=false fix passes strict gates on latest main.

aisle-research-bot bot commented Mar 1, 2026 •

edited

Loading

🔒 Aisle Security Analysis

✅ We scanned this PR and did not find any security vulnerabilities.

_{Aisle supplements but does not replace security review.}

Analyzed PR: #26020 at commit f8b1e2f

vabole mentioned this pull request

ops: decision needed for upstream sync (1 disputed files) vabole/openclaw#4

Merged

1 task

zooqueen added a commit to hanzoai/bot that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

d060e28

…chilu18

Cherry-pick of upstream dfbdab5.

ansh pushed a commit to vibecode/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

eae503c

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

f3e78f2

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

safzanpirani pushed a commit to safzanpirani/clawdbot that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

2462f68

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

steipete pushed a commit to Sid-Qin/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

amitmiran137 pushed a commit to amitmiran137/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

8feed4a

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

57084e2

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

hanqizheng pushed a commit to hanqizheng/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

ed2fc58

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

execute008 pushed a commit to execute008/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

09aaae2

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

dorgonman pushed a commit to kanohorizonia/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

62e387c

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

sachinkundu pushed a commit to sachinkundu/openclaw that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

48e6226

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

zooqueen pushed a commit to hanzoai/bot that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

96f3c48

…chilu18

Verified:
- pnpm build
- pnpm check
- pnpm test:macmini

Co-authored-by: chilu18 <7957943+chilu18@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

zooqueen added a commit to hanzoai/bot that referenced this pull request


          fix(slack): map legacy streaming=false to off (openclaw#26020) thanks @…

1be0741

…chilu18

Cherry-pick of upstream dfbdab5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: slack commands size: XS