telegram: clarify webhook config help and local listener startup logging#25732
Conversation
| .string() | ||
| .optional() | ||
| .describe( | ||
| "Public HTTPS webhook URL registered with Telegram for inbound updates. This must be internet-reachable and requires channels.telegram.webhookSecret.", |
There was a problem hiding this comment.
help text states "Public HTTPS webhook URL" but webhook.ts:130 defaults to http:// when publicUrl is not provided
| "Public HTTPS webhook URL registered with Telegram for inbound updates. This must be internet-reachable and requires channels.telegram.webhookSecret.", | |
| "Public webhook URL (HTTPS required for production) registered with Telegram for inbound updates. This must be internet-reachable and requires channels.telegram.webhookSecret.", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/config/zod-schema.providers-core.ts
Line: 172
Comment:
help text states "Public HTTPS webhook URL" but `webhook.ts:130` defaults to `http://` when `publicUrl` is not provided
```suggestion
"Public webhook URL (HTTPS required for production) registered with Telegram for inbound updates. This must be internet-reachable and requires channels.telegram.webhookSecret.",
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
I'm fine with guiding folks to use this with HTTPS. Telegram says they allow port 80... but if they really do that's a BAD idea to even suggest to folks that they should consider HTTP as an option for the webhook public URL.
|
@Takhoffman - Got a second to take a look at this one? It's got nice screenshots, closes an old issue, and should reduce support requests. |
7ba8f01 to
b7178f4
Compare
42b564f to
23f28a7
Compare
|
So local-listener log now builds URL from configured |
23f28a7 to
2983dd9
Compare
2983dd9 to
e535e71
Compare
Summary
Describe the problem and fix in 2–5 bullets:
mainregression in port0not being allowed - per request from @obviyuswebhookUrl,webhookSecret,webhookPath,webhookHost,webhookPort) and added a startup log line for the local listener URL (http://host:port/path), while keeping the existing public URL log.channels.telegram.webhookSecretwithchannels.telegram.webhookUrlis still rejected at config validation/startup.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:N/ARepro + Verification
Environment
channels.telegram.webhookUrl,channels.telegram.webhookSecret,channels.telegram.webhookHost,channels.telegram.webhookPort,channels.telegram.webhookPathSteps
Expected
Actual
Evidence
Attach at least one:
Sanitized startup log snippet
Log snippet when
webhoookPort: 0Screenshot - Web UI After
Screenshot - Startup Logs
Added log line:
19:05:13 [telegram] webhook local listener on http://127.0.0.1:8787/telegram-webhookHuman Verification (required)
What you personally verified (not just CI), and how:
channels.telegram.webhookUrlwithoutchannels.telegram.webhookSecreton startup.Compatibility / Migration
Yes)No)No)N/AFailure Recovery (if this breaks)
Risks and Mitigations
Greptile Summary
Enhanced Telegram webhook configuration guidance by adding inline help text for all webhook-related fields (
webhookUrl,webhookSecret,webhookPath,webhookHost,webhookPort) in the config schema. Added startup logging to display the local listener URL alongside the existing public webhook URL log, improving troubleshooting visibility for operators.http://host:port/path)Confidence Score: 5/5
Last reviewed commit: 337770c