CLI: fix gateway restart health ownership for child listener pids by gumadeiras · Pull Request #24696 · openclaw/openclaw

gumadeiras · 2026-02-23T18:30:00Z

Summary

fix restart-health ownership checks to treat listener child processes as owned by the running service pid
capture unix listener ppid in port inspection (ps -o ppid=) so restart checks can distinguish owned children from true stale listeners
add regression tests for child-owned listener vs non-owned listener behavior

Why

openclaw gateway restart could falsely report stale gateway processes and time out when the service manager pid and the socket-listener pid differ (parent/child model), which happens on both launchd and systemd setups.

Testing

pnpm test -- src/cli/daemon-cli/restart-health.test.ts src/cli/daemon-cli/lifecycle.test.ts src/infra/ports.test.ts
pnpm openclaw gateway restart
pnpm openclaw gateway restart --json

Greptile Summary

Fixed restart-health ownership checks to recognize child listener processes by capturing parent pid (ppid) from Unix ps output. The restart command previously timed out when the service manager pid differed from the socket-listener pid (parent/child model common in launchd and systemd setups). The fix adds ppid to PortListener, captures it via ps -o ppid=, and updates listenerOwnedByRuntimePid() to check both direct pid match and ppid match against the runtime pid.

Key changes:

Added ppid field to PortListener type
Implemented resolveUnixParentPid() to capture parent process ID on Unix systems
Updated listenerOwnedByRuntimePid() helper to check both listener.pid === runtimePid and listener.ppid === runtimePid
Added comprehensive test coverage for child-owned vs non-owned listener scenarios

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The implementation is focused, well-tested, and solves a specific bug without introducing side effects. The new ppid field is optional and backward-compatible. The logic correctly handles both direct ownership (pid match) and child process ownership (ppid match). Tests verify both the fixed scenario and the unchanged behavior for non-owned listeners.
No files require special attention

_{Last reviewed commit: a8d05ef}

Copilot

Pull request overview

This PR fixes a bug in gateway restart health checks where the service could falsely report stale processes when using parent/child process models (common with launchd and systemd). The fix adds parent PID tracking to distinguish legitimately owned child listener processes from truly stale ones.

Changes:

Add ppid (parent process ID) field to PortListener type for tracking process parent relationships
Capture ppid during Unix port inspection via ps -o ppid= command
Update restart health ownership checks to recognize child processes (listener.ppid === runtime.pid) as owned
Add regression tests for child-owned vs non-owned listener scenarios

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/infra/ports-types.ts	Adds optional ppid field to PortListener type
src/infra/ports-inspect.ts	Implements resolveUnixParentPid function and integrates ppid lookup into listener inspection
src/cli/daemon-cli/restart-health.ts	Adds listenerOwnedByRuntimePid helper and updates ownership/stale detection logic to check both pid and ppid
src/cli/daemon-cli/restart-health.test.ts	Adds tests verifying child-owned listeners are healthy and non-owned listeners are marked stale

gumadeiras · 2026-02-23T18:53:14Z

Merged via squash.

Prepared head SHA: d6d4b43
Merge commit: 5de1f54

Thanks @gumadeiras!

@rrenamed

* upstream/main: (1467 commits) fix(doctor): use gateway health status for memory search key check (openclaw#22327) refactor: harden reset notice + cron delivery target flow refactor(exec): simplify env-prefixed wrapper modifier check fix(skills): support multiline frontmatter fallback without PyYAML fix(skills): make quick_validate work without PyYAML fix(exec): bind env-prefixed shell wrappers to full approval text fix(browser): derive relay auth token from gateway token in Chrome extension Browser relay: accept raw gateway token in extension auth fix(gateway): include platform and reason in node command rejection error CLI: fix gateway restart health ownership for child listener pids (openclaw#24696) docs: detail per-agent prompt caching configuration fix(config): tighten bedrock cache-retention type narrowing feat(agents): add per-agent stream params overrides for cache tuning (openclaw#17470) (thanks @rrenamed) fix(providers): support Bedrock Anthropic cacheRetention defaults/pass-through (openclaw#22303) (thanks @snese) fix(providers): disable Bedrock prompt caching for non-Anthropic models (openclaw#20866) (thanks @pierreeurope) docs(changelog): note /new and /reset auth-label removal (openclaw#24409) fix(reply): omit auth labels in /new and /reset docs(changelog): correct kimi issue references test(tools): fix kimi web_search mock typing feat(media): add moonshot video provider and wiring ... # Conflicts: # ui/src/ui/app-render.ts # ui/src/ui/controllers/agents.ts

@gumadeiras