fix: support versioned node binaries (e.g., node-22)#2444
Merged
gumadeiras merged 1 commit intoopenclaw:mainfrom Jan 27, 2026
Merged
fix: support versioned node binaries (e.g., node-22)#2444gumadeiras merged 1 commit intoopenclaw:mainfrom
gumadeiras merged 1 commit intoopenclaw:mainfrom
Conversation
Fedora and some other distros install Node.js with a version suffix
(e.g., /usr/bin/node-22) and create a symlink from /usr/bin/node.
When Node resolves process.execPath, it returns the real binary path,
not the symlink, causing buildParseArgv to fail the looksLikeNode check.
This adds executable.startsWith('node-') to handle versioned binaries.
Fixes openclaw#2442
gumadeiras
added a commit
that referenced
this pull request
Jan 27, 2026
Member
|
Landed via rebase onto main.
Thanks @David-Marsh-Photo! |
14 tasks
john-ver
pushed a commit
to apmcoin/apmclaw
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2442
On Fedora (and potentially other distros), Node.js is installed with a version-suffixed binary (e.g.,
/usr/bin/node-22) with/usr/bin/nodeas a symlink. When Node resolvesprocess.execPath, it returns the real binary path, not the symlink.This causes
buildParseArgvinsrc/cli/argv.tsto fail thelooksLikeNodecheck, resulting in malformed argv that commander.js can't parse.Changes
Added
executable.startsWith("node-")to thelooksLikeNodecondition to handle versioned node binaries.Testing
Tested on Fedora 43 with
/usr/bin/node-22— all CLI commands now work correctly.