fix: sort IPv4 addresses before IPv6 in SSRF pinned DNS resolution#24295
Merged
steipete merged 2 commits intoopenclaw:mainfrom Feb 24, 2026
Merged
fix: sort IPv4 addresses before IPv6 in SSRF pinned DNS resolution#24295steipete merged 2 commits intoopenclaw:mainfrom
steipete merged 2 commits intoopenclaw:mainfrom
Conversation
Contributor
|
Triage: this looks merge-ready from CI status on the PR checks run (test/lint/protocol/checks all green in latest run). Issue mapping: #23975 remains open and appears to be waiting on this merge. |
0c2db80 to
8929395
Compare
steipete
added a commit
to Glucksberg/OpenClaw
that referenced
this pull request
Feb 24, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
…am media fetch on IPv6-broken hosts On hosts where IPv6 is configured but not routed (common on cloud VMs), Telegram media downloads fail because the pinned DNS lookup may return IPv6 addresses first. Even though autoSelectFamily (Happy Eyeballs) is enabled, the round-robin pinned lookup serves individual IPv6 addresses that fail before IPv4 is attempted. Sort resolved addresses so IPv4 comes first, ensuring both Happy Eyeballs and single-address round-robin try the working address family first. Fixes openclaw#23975 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
8929395 to
936991c
Compare
Contributor
|
Landed via temp rebase onto main.
Thanks @Glucksberg! |
obviyus
pushed a commit
to Glucksberg/OpenClaw
that referenced
this pull request
Feb 24, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
margulans
pushed a commit
to margulans/Neiron-AI-assistant
that referenced
this pull request
Feb 25, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
Jackson3195
pushed a commit
to Jackson3195/openclaw-with-a-personal-touch
that referenced
this pull request
Feb 25, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
brianleach
pushed a commit
to brianleach/openclaw
that referenced
this pull request
Feb 26, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
2 tasks
execute008
pushed a commit
to execute008/openclaw
that referenced
this pull request
Feb 27, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
r4jiv007
pushed a commit
to r4jiv007/openclaw
that referenced
this pull request
Feb 28, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com> (cherry picked from commit 3f07d72) # Conflicts: # CHANGELOG.md
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com> (cherry picked from commit 3f07d72) # Conflicts: # CHANGELOG.md
joelnishanth
pushed a commit
to joelnishanth/openclaw
that referenced
this pull request
Mar 3, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
… (thanks @Glucksberg) Co-Authored-By: Glucksberg <80581902+Glucksberg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dns-result-ordertoverbatimresolvePinnedHostnameWithPolicy()insrc/infra/net/ssrf.tsto sort IPv4 addresses before IPv6 in the resolved address listautoSelectFamily) and single-address round-robin try IPv4 firstTest plan
Fixes #23975
🤖 Generated with Claude Code
Greptile Summary
Modified
resolvePinnedHostnameWithPolicy()insrc/infra/net/ssrf.ts:280to sort IPv4 addresses before IPv6 addresses in the resolved address list. This ensures Happy Eyeballs (autoSelectFamily) and single-address round-robin selection try IPv4 first, avoiding connection failures on hosts with broken IPv6 routing (common on cloud VMs and WSL2).toSorted()with a comparator that checks for colons to differentiate IPv6 from IPv4SetConfidence Score: 5/5
Last reviewed commit: ca53435