fix(doctor): replace nonexistent auth add command with openclaw onboard (#24220)#24266
Closed
lailoo wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(doctor): replace nonexistent auth add command with openclaw onboard (#24220)#24266lailoo wants to merge 1 commit intoopenclaw:mainfrom
lailoo wants to merge 1 commit intoopenclaw:mainfrom
Conversation
3 tasks
Contributor
|
AI-assisted stale triage closure (fix-only duplicate sweep). This PR overlaps with #24485 for issue #24220 (doctor command guidance replacement). #24485 is the active path for this fix scope. Closing this duplicate as AI-closed to keep one active fix PR per issue. Reopen guidance:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openclaw doctorsuggests nonexistentopenclaw auth add --provider <X>command when memory search has no API key.noteMemorySearchHealth()insrc/commands/doctor-memory-search.tshardcodesopenclaw auth add --provider ...which is not a valid CLI command.openclaw onboardwhich is the correct general-purpose auth setup command.Fixes #24220
Problem
When
openclaw doctordetects that memory search has no embedding provider API key, it suggests:This command does not exist. Running it produces the top-level help output. The correct auth commands are
openclaw models auth setup-token,openclaw models auth login --provider <X>, oropenclaw onboard.Before fix:
Changes
src/commands/doctor-memory-search.ts— Replaceopenclaw auth add --provider <X>withopenclaw onboardat lines 65 and 92.src/commands/doctor-memory-search.test.ts— Add 2 regression tests verifying the suggested commands are valid.After fix:
Test plan
openclaw auth addcommand #24220)openclaw auth addcommand #24220)Effect on User Experience
Before: User follows doctor suggestion, runs
openclaw auth add --provider openai, gets unhelpful top-level help output.After: User follows doctor suggestion, runs
openclaw onboard, enters the interactive auth setup wizard.Greptile Summary
Fixes
openclaw doctorto suggest the correct command when memory search credentials are missing. Previously suggestedopenclaw auth add --provider <X>which doesn't exist (the actual command structure isopenclaw models auth login --provider <X>oropenclaw models auth add). Now correctly suggestsopenclaw onboard, which is the general-purpose interactive setup wizard that handles authentication and configuration.src/commands/doctor-memory-search.ts:65andsrc/commands/doctor-memory-search.ts:92Confidence Score: 5/5
Last reviewed commit: a5745dd