Cron: apply timeout to startup catch-up runs#23966
Merged
Takhoffman merged 2 commits intomainfrom Feb 22, 2026
Merged
Conversation
813bb07 to
8ac52ba
Compare
Contributor
Author
|
Merged via autoland after rebasing onto Local verification:
Pinned merge head:
|
carlosrivera
pushed a commit
to myascendai/meshiclaw
that referenced
this pull request
Feb 23, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
gabrielkoo
pushed a commit
to gabrielkoo/openclaw
that referenced
this pull request
Feb 23, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
mreedr
pushed a commit
to mreedr/openclaw-custom
that referenced
this pull request
Feb 24, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
mylukin
pushed a commit
to mylukin/openclaw
that referenced
this pull request
Feb 26, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
r4jiv007
pushed a commit
to r4jiv007/openclaw
that referenced
this pull request
Feb 28, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
ogt-redknie
pushed a commit
to ogt-redknie/OPENX
that referenced
this pull request
May 2, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
* Cron: apply timeout to startup catch-up runs * Changelog: add cron startup timeout catch-up note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
runMissedJobsbypassed cron timeout handling.executeJobCoreWithTimeout(...), and a regression test verifies timeout/abort behavior.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
timeoutSecondsthe same way timer/manual runs do.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
timeoutSeconds: 0.01.runMissedJobs).Expected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
pnpm -s vitest run src/cron/service.issue-regressions.test.tsin/Users/thoffman/openclaw-wt-cron-1.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/cron/service/timer.ts,src/cron/service.issue-regressions.test.ts.Risks and Mitigations
List only real risks for this PR. Add/remove entries as needed. If none, write
None.Greptile Summary
This PR fixes a bug where startup catch-up executions in
runMissedJobsbypassed cron timeout handling. The fix ensures that startup catch-up runs now useexecuteJobCoreWithTimeout(...)instead ofexecuteJobCore(...), applying the same timeout behavior as timer and manual runs. The change is minimal and focused, with a comprehensive regression test that verifies the timeout abort signal is properly observed during startup catch-up.Confidence Score: 5/5
executeJobCorewithexecuteJobCoreWithTimeoutin the startup catch-up path. The implementation is already proven in the timer and manual execution paths. The regression test comprehensively validates the timeout behavior with real abort signal verification. No breaking changes to existing behavior.Last reviewed commit: 5ca52cb