security(cli): redact sensitive values in config get output by SleuthCo · Pull Request #23654 · openclaw/openclaw

SleuthCo · 2026-02-22T15:11:02Z

Summary

runConfigGet() reads raw config values but never applies redaction before printing. Running openclaw config get gateway.token leaks the real credential to the terminal — visible in shell history, scrollback, and screenshots.

This is a 1-line fix using the existing redactConfigObject() from redact-snapshot.ts (already used by the Web UI path) to scrub sensitive fields before output.

Supersedes #13777 (rebased against current HEAD after upstream refactored config get into runConfigGet()).

Fixes #13683

Changes

Import redactConfigObject from ../config/redact-snapshot.js
Apply redactConfigObject(snapshot.config) before getAtPath() in runConfigGet()

Test plan

openclaw config get gateway.token → prints __OPENCLAW_REDACTED__ instead of real token
openclaw config get gateway.token --json → prints "__OPENCLAW_REDACTED__"
openclaw config get agents → non-sensitive paths return real values unchanged

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Greptile Summary

This PR fixes a security vulnerability where openclaw config get commands leaked sensitive credentials (tokens, passwords, API keys) to terminal output, shell history, and screenshots. The fix applies the existing redactConfigObject() function from src/config/redact-snapshot.ts before retrieving the config value, ensuring sensitive fields are replaced with __OPENCLAW_REDACTED__ sentinel values.

Imported redactConfigObject from ../config/redact-snapshot.js in src/cli/config-cli.ts:4
Applied redaction to snapshot.config before getAtPath() in runConfigGet() at src/cli/config-cli.ts:236-237
The redaction logic is well-tested and already used by the Web UI path and other config endpoints
Sensitive field detection uses regex patterns matching token, password, secret, apiKey (with exceptions for fields like maxTokens)
Non-sensitive paths return actual values unchanged

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The fix is a targeted 2-line security patch that reuses existing, well-tested redaction infrastructure (redactConfigObject()) already used by the Web UI and gateway config endpoints. The change is minimal, focused, and follows established patterns in the codebase. The redaction function has comprehensive test coverage and handles edge cases (environment variable placeholders, whitelisted fields like maxTokens). No breaking changes or performance concerns.
No files require special attention

_{Last reviewed commit: 92dace9}

`runConfigGet()` reads raw config values but never applies redaction before printing. When a user runs `openclaw config get gateway.token` the real credential is printed to the terminal, leaking it into shell history, scrollback buffers, and screenshots. Use the existing `redactConfigObject()` (from redact-snapshot.ts, already used by the Web UI path) to scrub sensitive fields before `getAtPath()` resolves the requested key. Fixes openclaw#13683 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

SleuthCo · 2026-02-22T15:20:12Z

@vincentkoc — small security follow-up to the prototype pollution fix you merged in #22213.

runConfigGet() (extracted in the recent refactor) reads raw config but never calls redactConfigObject() before printing. So openclaw config get gateway.token leaks the real credential to the terminal.

This is a 1-line fix using the existing redactConfigObject() from redact-snapshot.ts that's already wired into the Web UI path. Happy to adjust if needed.

vincentkoc

Looks good after validation.

I pushed two follow-ups to this PR branch:

Added a changelog entry under 2026.2.22 (Unreleased) -> Fixes
Added a regression test in src/cli/config-cli.test.ts for redacted config get output

Thanks @SleuthCo.

…#23654) * security(cli): redact sensitive values in config get output `runConfigGet()` reads raw config values but never applies redaction before printing. When a user runs `openclaw config get gateway.token` the real credential is printed to the terminal, leaking it into shell history, scrollback buffers, and screenshots. Use the existing `redactConfigObject()` (from redact-snapshot.ts, already used by the Web UI path) to scrub sensitive fields before `getAtPath()` resolves the requested key. Fixes openclaw#13683 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * CLI/Config: add redaction regression test and changelog --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Vincent Koc <vincentkoc@ieee.org>

…#23654) * security(cli): redact sensitive values in config get output `runConfigGet()` reads raw config values but never applies redaction before printing. When a user runs `openclaw config get gateway.token` the real credential is printed to the terminal, leaking it into shell history, scrollback buffers, and screenshots. Use the existing `redactConfigObject()` (from redact-snapshot.ts, already used by the Web UI path) to scrub sensitive fields before `getAtPath()` resolves the requested key. Fixes openclaw#13683 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * CLI/Config: add redaction regression test and changelog --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Vincent Koc <vincentkoc@ieee.org> (cherry picked from commit 9c87b53) # Conflicts: # CHANGELOG.md # src/cli/config-cli.test.ts # src/cli/config-cli.ts

…#23654) * security(cli): redact sensitive values in config get output `runConfigGet()` reads raw config values but never applies redaction before printing. When a user runs `openclaw config get gateway.token` the real credential is printed to the terminal, leaking it into shell history, scrollback buffers, and screenshots. Use the existing `redactConfigObject()` (from redact-snapshot.ts, already used by the Web UI path) to scrub sensitive fields before `getAtPath()` resolves the requested key. Fixes openclaw#13683 * CLI/Config: add redaction regression test and changelog --------- Co-authored-by: Vincent Koc <vincentkoc@ieee.org>

openclaw-barnacle bot added cli CLI command changes size: XS labels Feb 22, 2026

vincentkoc added 2 commits February 22, 2026 19:22

Merge branch 'main' into security/redact-config-get-v2

0ceb80d

CLI/Config: add redaction regression test and changelog

1b61816

vincentkoc approved these changes Feb 23, 2026

View reviewed changes

vincentkoc merged commit 9c87b53 into openclaw:main Feb 23, 2026
24 checks passed

github-actions bot mentioned this pull request Feb 23, 2026

📡 Upstream Digest — 2026-02-23 01:22 UTC curtismercier/openclaw-mods#105

Open

github-actions bot mentioned this pull request Feb 24, 2026

上游更新: v2026.2.23, v2026.2.22 — 114 P0 + 122 P1 待合并 jiulingyun/openclaw-cn#328

Closed

jiulingyun mentioned this pull request Feb 24, 2026

upstream(cli): 移植 2 个冲突 commit (P0) — v2026.2.21→v2026.2.23 jiulingyun/openclaw-cn#340

Closed

6 tasks

Copilot AI mentioned this pull request Feb 24, 2026

[WIP] Resolve conflicts and apply upstream commits for CLI jiulingyun/openclaw-cn#343

Closed

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream deps/security commits (2026-03-01-0443) hughdidit/DAISy-Agency#138

Closed

6 tasks

github-actions bot mentioned this pull request Mar 3, 2026

cherry-pick: upstream deps/security commits (2026-03-02-2346) hughdidit/DAISy-Agency#144

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

security(cli): redact sensitive values in config get output#23654

security(cli): redact sensitive values in config get output#23654
vincentkoc merged 3 commits intoopenclaw:mainfrom
SleuthCo:security/redact-config-get-v2

SleuthCo commented Feb 22, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

SleuthCo commented Feb 22, 2026

Uh oh!

vincentkoc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SleuthCo commented Feb 22, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Greptile Summary

Confidence Score: 5/5

Uh oh!

SleuthCo commented Feb 22, 2026

Uh oh!

vincentkoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

SleuthCo commented Feb 22, 2026 •

edited by greptile-apps bot

Loading