fix(browser): complete extension relay handshake on connect.challenge by pandego · Pull Request #22571 · openclaw/openclaw

pandego · 2026-02-21T09:29:04Z

Summary

Fixes Chrome extension relay sessions getting stuck at badge … by implementing the required gateway handshake flow in the bundled extension background worker.

Closes #22553

Root cause

Gateway now emits a pre-connect connect.challenge event. The extension websocket client did not handle that event and never sent a connect request, so the relay session never became authenticated/ready.

What changed

Handle type=event,event=connect.challenge in assets/chrome-extension/background.js
Send a proper gateway connect request from the extension with token auth and client metadata
Wait for successful connect response before considering relay setup complete
Ensure message listener is bound early so the first challenge frame cannot be missed
Cleanly reject pending handshake promise on disconnect/timeouts

Validation

node --check assets/chrome-extension/background.js

AI assistance

AI-assisted; change reviewed and validated locally.

Greptile Summary

Implemented the required gateway handshake flow to fix Chrome extension relay sessions getting stuck at the connecting badge (…). The extension now properly handles the connect.challenge event sent by the gateway server and responds with a connect request containing authentication credentials and client metadata. The message handler is bound early (before WebSocket open) to prevent race conditions where the challenge could be missed, and the connection waits for successful handshake completion before proceeding with relay operations.

Added state variables to track handshake progress (relayGatewayToken, relayConnectRequestId, relayConnectResolve/Reject, relayConnectTimer, relayChallengeSeen)
Implemented waitForGatewayConnect() to create a promise-based handshake with 8-second timeout
Added ensureGatewayHandshakeStarted() to send the connect request with proper protocol parameters
Handle connect.challenge event and successful/failed connect responses in onRelayMessage
Clean up handshake state on disconnect/errors via clearRelayConnectState()
Bound ws.onmessage before the WebSocket opens to prevent missing the initial challenge event

Confidence Score: 5/5

Safe to merge - addresses a critical bug with proper error handling and timeout protection
Implementation correctly follows the gateway protocol as documented and matches patterns from the TypeScript client. The handshake flow includes proper timeout handling (8s), early message binding to prevent race conditions, clean state management on errors/disconnects, and appropriate promise-based async flow. The fix directly addresses the reported issue and includes validation.
No files require special attention

_{Last reviewed commit: 6d012ed}

pandego · 2026-02-21T09:54:18Z

Follow-up fix pushed for CI stability:

Stabilized extensions/msteams/src/messenger.test.ts OneDrive fallback mention test by mocking loadWebMedia deterministically in-test, removing filesystem/temp-path dependence across platforms.
This keeps the test focused on mention+fallback-link behavior and avoids platform-specific path/IO variance.

Local validation run:

pnpm vitest run extensions/msteams/src/messenger.test.ts ✅
pnpm oxfmt --check extensions/msteams/src/messenger.test.ts ✅

…ssenger test

@pandego

Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR #22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

steipete · 2026-02-26T14:26:44Z

Landed on main via 65d5a9124.

What landed from this PR (adapted for current relay architecture):

early WS message binding before onopen so immediate first frames are not missed
non-blocking connect.challenge compatibility handling in the extension worker
handshake-failure handling that closes/retries without forcing a blocking connect wait on current local relay protocol
changelog attribution for PR fix(browser): complete extension relay handshake on connect.challenge #22571

Note: I intentionally did not land the unrelated extensions/msteams/src/messenger.test.ts change from this PR branch.

SHA mapping:

original browser fix commit: 9c9d24f0a9c5c4c0133c9fb749efe37cbbf3b8ad
landed commit: 65d5a9124

Thanks for the fix direction, @pandego.

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 03e1b2a)

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 65d5a91) # Conflicts: # CHANGELOG.md # assets/chrome-extension/background.js

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com> (cherry picked from commit 65d5a91) # Conflicts: # CHANGELOG.md # assets/chrome-extension/background.js

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

@pandego

…ndling Bind relay WS message handling before onopen and add non-blocking connect.challenge response support without forcing handshake waits on current relay protocol. Landed from contributor @pandego (PR openclaw#22571). Co-authored-by: pandego <7780875+pandego@users.noreply.github.com>

openclaw-barnacle bot added size: S channel: msteams Channel integration: msteams labels Feb 21, 2026

mdjahid11978-design approved these changes Feb 21, 2026

View reviewed changes

pandego force-pushed the fix/22553-extension-connect-challenge branch 2 times, most recently from 7df8591 to af52d6b Compare February 21, 2026 12:43

openclaw-barnacle bot removed the channel: msteams Channel integration: msteams label Feb 21, 2026

pandego added 2 commits February 21, 2026 14:21

fix(browser): handle gateway connect.challenge in chrome relay extension

9c9d24f

chore(ci): retrigger windows test lane after repeated local pass

404a2e5

pandego force-pushed the fix/22553-extension-connect-challenge branch from 5e6e302 to 404a2e5 Compare February 21, 2026 13:21

refactor(test): ensure parent dir exists before mkdtemp in msteams me…

74dd36b

…ssenger test

openclaw-barnacle bot added the channel: msteams Channel integration: msteams label Feb 21, 2026

steipete closed this Feb 26, 2026

gemini-code-assist bot mentioned this pull request Feb 27, 2026

chore(sync): replay rollup fixes on upstream/main MillionthOdin16/openclaw#94

Merged

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(browser): complete extension relay handshake on connect.challenge#22571

fix(browser): complete extension relay handshake on connect.challenge#22571
pandego wants to merge 3 commits intoopenclaw:mainfrom
pandego:fix/22553-extension-connect-challenge

pandego commented Feb 21, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

pandego commented Feb 21, 2026

Uh oh!

steipete commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

pandego commented Feb 21, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

What changed

Validation

AI assistance

Greptile Summary

Confidence Score: 5/5

Uh oh!

pandego commented Feb 21, 2026

Uh oh!

steipete commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pandego commented Feb 21, 2026 •

edited by greptile-apps bot

Loading