fix(auto-reply): Hide message_id and sender metadata in direct chats#22054
fix(auto-reply): Hide message_id and sender metadata in direct chats#22054jd316 wants to merge 0 commit intoopenclaw:mainfrom
Conversation
src/auto-reply/reply/inbound-meta.ts
Outdated
| message_id_full: | ||
| messageIdFull && messageIdFull !== messageId ? messageIdFull : undefined, |
There was a problem hiding this comment.
message_id_full will leak in direct chats when it differs from message_id, since the isDirect check is missing
| message_id_full: | |
| messageIdFull && messageIdFull !== messageId ? messageIdFull : undefined, | |
| message_id_full: isDirect | |
| ? undefined | |
| : (messageIdFull && messageIdFull !== messageId ? messageIdFull : undefined), |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/auto-reply/reply/inbound-meta.ts
Line: 81-82
Comment:
`message_id_full` will leak in direct chats when it differs from `message_id`, since the `isDirect` check is missing
```suggestion
message_id_full: isDirect
? undefined
: (messageIdFull && messageIdFull !== messageId ? messageIdFull : undefined),
```
How can I resolve this? If you propose a fix, please make it concise.9635265 to
0ba1e90
Compare
34ebf07 to
0f6c97a
Compare
8f6ea64 to
2325f6a
Compare
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
21 similar comments
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Closing this PR because it looks dirty (too many unrelated or unexpected changes). This usually happens when a branch picks up unrelated commits or a merge went sideways. Please recreate the PR from a clean branch. |
|
Too many files changed for review. ( |
|
Sorry, accidentally replayed main commits here. Reverting. |
|
@jd316 closed? |
|
@jd316 I was working on this one and preparing to merge it. Please do not create duplicate PRs. |
|
@obviyus apologies for the confusion. The bot closed #22054, so I thought it was dead and created #24359. Both are now closed. I have a clean branch fix/auto-reply-direct-chat-metadata with the 4 auto-reply commits (2 files only as you requested). How would you like to proceed?
|
Direct chats do not require moderation tracking or complex group threaded history, but this untrusted metadata visibly leaks into the standard DM UI. This change strictly hides this metadata in
isDirectconversation info context, resolving UI clutter. Tests have been updated to reflect the new behavior.Greptile Summary
Hides
message_id,conversation_label, andsenderfields in direct chat contexts to prevent untrusted metadata from cluttering the DM UI. Tests updated to verify these fields remain visible in group chats.Issues found:
message_id_fullfield is not hidden in direct chats, allowing metadata to leak when it differs frommessage_idConfidence Score: 2/5
message_id_fullfield is not properly hidden in direct chats, violating the stated goal of preventing metadata leakage in DM UIsrc/auto-reply/reply/inbound-meta.ts:81-82where themessage_id_fulllogic needs theisDirectcheckLast reviewed commit: f708dfc
(2/5) Greptile learns from your feedback when you react with thumbs up/down!