test(ios): cover IPv4-mapped IPv6 loopback in manual TLS policy#22045
Merged
test(ios): cover IPv4-mapped IPv6 loopback in manual TLS policy#22045
Conversation
Contributor
Author
rodrigogs
pushed a commit
to rodrigogs/openclaw
that referenced
this pull request
Feb 20, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
Hansen1018
added a commit
to Hansen1018/openclaw
that referenced
this pull request
Feb 21, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
dgarson
pushed a commit
to dgarson/clawdbot
that referenced
this pull request
Feb 21, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
mmyyfirstb
pushed a commit
to mmyyfirstb/openclaw
that referenced
this pull request
Feb 21, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
obviyus
pushed a commit
to guirguispierre/openclaw
that referenced
this pull request
Feb 22, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
mreedr
pushed a commit
to mreedr/openclaw-custom
that referenced
this pull request
Feb 24, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky (cherry picked from commit fe32150) # Conflicts: # CHANGELOG.md
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky (cherry picked from commit fe32150) # Conflicts: # CHANGELOG.md
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…claw#22045) Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: ec952f0 Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Co-authored-by: mbelinky <132747814+mbelinky@users.noreply.github.com> Reviewed-by: @mbelinky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::ffff:127.0.0.1in manual host TLS resolution testsWhy
Greptile correctly pointed out this specific test gap after the loopback hardening changes.
Changes
apps/ios/Tests/GatewayConnectionSecurityTests.swift#expect(controller._test_resolveManualUseTLS(host: "::ffff:127.0.0.1", useTLS: false) == false)Verification
xcodebuild -project apps/ios/OpenClaw.xcodeproj -scheme OpenClaw -destination 'platform=iOS Simulator,name=iPhone 17' test -only-testing:OpenClawTests/GatewayConnectionSecurityTests/manualConnectionsForceTLSForNonLoopbackHostswatchOS 26.2 must be installed).Greptile Summary
Added regression test for IPv4-mapped IPv6 loopback address (
::ffff:127.0.0.1) to verify it's correctly treated as loopback and doesn't force TLS in manual gateway connections.isLoopbackIPv6(lines 695-707) already handles IPv4-mapped addresses by checking bytes[10-11] for0xFFand bytes[12] for127Confidence Score: 5/5
isLoopbackIPv6at lines 704-705), filling a gap in test coverage.Last reviewed commit: 822d26e