fix: Chrome relay extension auto-reattach after SPA navigation by nishantkabra77 · Pull Request #19766 · openclaw/openclaw

nishantkabra77 · 2026-02-18T04:29:24Z

Summary

Fixes #19744 — The Chrome Browser Relay extension loses its CDP connection after any click that triggers SPA in-page navigation (Gmail, Google Calendar, etc.), making it effectively read-only for SPAs.

Root Cause

onDebuggerDetach in background.js unconditionally calls detachTab() on any debugger detach event — including navigations where the tab still exists. It never attempts to re-attach, so the connection is permanently lost until the user manually clicks the extension badge again.

Changes

Core fix — onDebuggerDetach rewritten:

Detects navigation vs tab close (checks if tab still exists via chrome.tabs.get)
Skips re-attach for chrome:// and extension pages
Sends Target.detachedFromTarget for old session before re-attaching (clean session handoff)
3 retries with exponential backoff (300ms → 700ms → 1500ms) to handle varying page load times
Each retry verifies: tab exists, relay connected, re-attach not cancelled by user
Logs at each step for debugging (chrome://extensions service worker console)

Race condition fixes:

reattachPending Set prevents concurrent re-attach loops for the same tab
connectOrToggleForActiveTab: if user clicks badge during re-attach, cancels cleanly
onRelayClosed: clears reattachPending so in-flight retries bail out immediately

New: chrome.tabs.onRemoved listener:

Original code had no handler for tab removal — could leave stale state
Now cleans up both reattachPending and tabs map on tab close

Testing

Tested with:

Gmail (clicking emails in inbox triggers SPA navigation)
Google Calendar (navigating between days/weeks)
Tabs that are closed during re-attach retry window
User toggling badge during re-attach

Files Changed

assets/chrome-extension/background.js — 143 insertions, 2 deletions

Greptile Summary

This PR fixes the Chrome Browser Relay extension losing its CDP connection after SPA in-page navigations (Gmail, Google Calendar, etc.) by rewriting onDebuggerDetach to detect whether the tab still exists and attempt automatic re-attachment with exponential backoff retries.

The approach is sound: it distinguishes navigation from tab close, cleans up old session state, notifies the relay, and retries with proper guards against races (concurrent re-attach, user toggle, relay disconnect, tab removal).

Key issue found: The reason parameter from chrome.debugger.onDetach is not checked for canceled_by_user or replaced_with_devtools, which means the extension will fight the user's explicit action to dismiss the debugger bar by re-attaching 3 times before giving up.
Race condition handling between onRemoved and onDebuggerDetach is correctly implemented.
The new chrome.tabs.onRemoved listener properly cleans up stale state.

Confidence Score: 3/5

Generally safe to merge but has a notable UX bug where the extension will fight user-initiated debugger dismissal
The core SPA navigation re-attach logic is well-structured with proper race condition handling, but the missing check for canceled_by_user and replaced_with_devtools detach reasons is a real UX issue that will frustrate users who manually dismiss the debugger bar.
assets/chrome-extension/background.js — the onDebuggerDetach function needs to check the reason parameter before attempting re-attach

_{Last reviewed commit: 0643000}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-18T04:32:31Z

assets/chrome-extension/background.js

+async function onDebuggerDetach(source, reason) {
  const tabId = source.tabId
  if (!tabId) return
  if (!tabs.has(tabId)) return
-  void detachTab(tabId, reason)
+


Missing check for canceled_by_user and replaced_with_devtools detach reasons

Chrome's onDetach provides a reason parameter with values "target_closed", "canceled_by_user", and "replaced_with_devtools". When the user explicitly dismisses the debugger infobar (canceled_by_user) or opens DevTools (replaced_with_devtools), the tab still exists and the URL won't be chrome://, so the current code will attempt to re-attach — fighting the user's explicit intent.

This creates a frustrating UX: the user cancels the debugger bar, it reappears 300ms later, they cancel again, it comes back at 700ms, etc., for 3 cycles before giving up. For replaced_with_devtools, re-attaching would conflict with DevTools.

Suggested change

async function onDebuggerDetach(source, reason) {

const tabId = source.tabId

if (!tabId) return

if (!tabs.has(tabId)) return

void detachTab(tabId, reason)

async function onDebuggerDetach(source, reason) {

const tabId = source.tabId

if (!tabId) return

if (!tabs.has(tabId)) return

// User explicitly cancelled or DevTools replaced the connection — respect their intent

if (reason === 'canceled_by_user' || reason === 'replaced_with_devtools') {

void detachTab(tabId, reason)

return

}

Prompt To Fix With AI

This is a comment left during a code review. Path: assets/chrome-extension/background.js Line: 458-462 Comment: **Missing check for `canceled_by_user` and `replaced_with_devtools` detach reasons** Chrome's `onDetach` provides a `reason` parameter with values `"target_closed"`, `"canceled_by_user"`, and `"replaced_with_devtools"`. When the user explicitly dismisses the debugger infobar (`canceled_by_user`) or opens DevTools (`replaced_with_devtools`), the tab still exists and the URL won't be `chrome://`, so the current code will attempt to re-attach — fighting the user's explicit intent. This creates a frustrating UX: the user cancels the debugger bar, it reappears 300ms later, they cancel again, it comes back at 700ms, etc., for 3 cycles before giving up. For `replaced_with_devtools`, re-attaching would conflict with DevTools. ```suggestion async function onDebuggerDetach(source, reason) { const tabId = source.tabId if (!tabId) return if (!tabs.has(tabId)) return // User explicitly cancelled or DevTools replaced the connection — respect their intent if (reason === 'canceled_by_user' || reason === 'replaced_with_devtools') { void detachTab(tabId, reason) return } ``` How can I resolve this? If you propose a fix, please make it concise.

nishantkabra77 · 2026-02-18T06:24:35Z

The protocol:check failures on Linux and Windows are unrelated to this PR — they're caused by a missing threadId field in GatewayModels.swift (protocol drift from main). Our change only touches assets/chrome-extension/background.js. All relevant checks (tests, lint, build) pass.

When Chrome's debugger detaches during page navigation (common in SPAs like Gmail, Google Calendar), the extension now automatically re-attaches instead of permanently losing the connection. Changes: - onDebuggerDetach: detect navigation vs tab close, attempt re-attach with 3 retries and exponential backoff (300ms, 700ms, 1500ms) - Add reattachPending guard to prevent concurrent re-attach races - connectOrToggleForActiveTab: handle pending re-attach state - onRelayClosed: clear reattachPending on relay disconnect - Add chrome.tabs.onRemoved listener for proper cleanup Fixes openclaw#19744

Skip re-attach when user explicitly dismisses debugger bar or opens DevTools. Prevents frustrating re-attach loop that fights user intent. Addresses review feedback from greptile-apps.

@nishantkabra77

…hanks @nishantkabra77)

steipete · 2026-02-24T04:11:22Z

Landed via temp rebase onto main.

Gate: pnpm test src/browser/chrome-extension-background-utils.test.ts
Land commit: df2c47e
Merge commit: 004a610

Thanks @nishantkabra77!

@nishantkabra77

…hanks @nishantkabra77)

@nishantkabra77

…hanks @nishantkabra77)

@nishantkabra77

…hanks @nishantkabra77)

@nishantkabra77

…hanks @nishantkabra77)

@nishantkabra77

…hanks @nishantkabra77)

@nishantkabra77

…hanks @nishantkabra77) (cherry picked from commit 004a610)

@nishantkabra77

…hanks @nishantkabra77) (cherry picked from commit 004a610)

@nishantkabra77

…hanks @nishantkabra77)

openclaw-barnacle bot added the size: S label Feb 18, 2026

greptile-apps bot reviewed Feb 18, 2026

View reviewed changes

NK and others added 3 commits February 24, 2026 04:10

fix: respect canceled_by_user and replaced_with_devtools detach reasons

449d3b7

Skip re-attach when user explicitly dismisses debugger bar or opens DevTools. Prevents frustrating re-attach loop that fights user intent. Addresses review feedback from greptile-apps.

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

df2c47e

…hanks @nishantkabra77)

steipete force-pushed the fix/chrome-relay-spa-navigation branch from cd402ad to df2c47e Compare February 24, 2026 04:11

steipete merged commit 004a610 into openclaw:main Feb 24, 2026

github-actions bot mentioned this pull request Feb 24, 2026

上游更新: v2026.2.23, v2026.2.22 — 114 P0 + 122 P1 待合并 jiulingyun/openclaw-cn#328

Closed

plgs2005 pushed a commit to plgs2005/openclaw that referenced this pull request Feb 24, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

d7d159b

…hanks @nishantkabra77)

abdelkadermeflahi6-web referenced this pull request Feb 24, 2026

docs(changelog): trim 2026.2.24 unreleased entries

e3ac491

abdelkadermeflahi6-web referenced this pull request Feb 24, 2026

chore(release): bump version to 2026.2.24

2bad30b

margulans pushed a commit to margulans/Neiron-AI-assistant that referenced this pull request Feb 25, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

16ff239

…hanks @nishantkabra77)

brianleach pushed a commit to brianleach/openclaw that referenced this pull request Feb 26, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

1a16672

…hanks @nishantkabra77)

arjunaskykok mentioned this pull request Feb 26, 2026

fix/test a2ui bundle preflight #27345

Open

2 tasks

mylukin pushed a commit to mylukin/openclaw that referenced this pull request Feb 26, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

3be4379

…hanks @nishantkabra77)

r4jiv007 pushed a commit to r4jiv007/openclaw that referenced this pull request Feb 28, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

4ccfee1

…hanks @nishantkabra77)

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream docs commits (2026-03-01-0443) hughdidit/DAISy-Agency#141

Closed

6 tasks

hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

f9b4858

…hanks @nishantkabra77) (cherry picked from commit 004a610)

hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

6aea238

…hanks @nishantkabra77) (cherry picked from commit 004a610)

zooqueen pushed a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

docs(changelog): note relay nav auto-reattach fix (openclaw#19766) (t…

3be52d3

…hanks @nishantkabra77)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Chrome relay extension auto-reattach after SPA navigation#19766

fix: Chrome relay extension auto-reattach after SPA navigation#19766
steipete merged 3 commits intoopenclaw:mainfrom
nishantkabra77:fix/chrome-relay-spa-navigation

nishantkabra77 commented Feb 18, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 18, 2026

Uh oh!

nishantkabra77 commented Feb 18, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nishantkabra77 commented Feb 18, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root Cause

Changes

Testing

Files Changed

Greptile Summary

Confidence Score: 3/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

nishantkabra77 commented Feb 18, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nishantkabra77 commented Feb 18, 2026 •

edited by greptile-apps bot

Loading