fix(mac): add Sendable conformance to generated Swift protocol structs#195
Merged
steipete merged 5 commits intoopenclaw:mainfrom Jan 4, 2026
Merged
Conversation
Contributor
|
Thanks @andranik-sahakyan — great catch. Landed (incl. generator regen + CI lint fix + changelog credit). |
dgarson
referenced
this pull request
in dgarson/clawdbot
Feb 7, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
openclaw#195) * fix(mac): add Sendable conformance to generated Swift protocol structs * fix(mac): make generated protocol types Sendable * chore(mac): drop redundant Sendable extensions * docs(changelog): thank @andranik-sahakyan for Sendable fix * chore(swiftformat): exclude generated protocol models --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
3 tasks
ph0t0bar
added a commit
to ph0t0bar/openclaw
that referenced
this pull request
Mar 17, 2026
… runway), PRs openclaw#195-199 logged
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
openclaw#195) * fix(mac): add Sendable conformance to generated Swift protocol structs * fix(mac): make generated protocol types Sendable * chore(mac): drop redundant Sendable extensions * docs(changelog): thank @andranik-sahakyan for Sendable fix * chore(swiftformat): exclude generated protocol models --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
openclaw#195) * fix(mac): add Sendable conformance to generated Swift protocol structs * fix(mac): make generated protocol types Sendable * chore(mac): drop redundant Sendable extensions * docs(changelog): thank @andranik-sahakyan for Sendable fix * chore(swiftformat): exclude generated protocol models --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Sendableconformance to all structs generated byprotocol-gen-swift.ts.Problem
Swift 6's strict concurrency checking requires types passed across actor boundaries to conform to
Sendable. The generatedGatewayModels.swiftstructs are used in async contexts (e.g.,OnboardingWizard.swift) but don't conform toSendable, causing build failures:Solution
One-line change to the generator:
All generated structs only contain value types (strings, ints, optionals, arrays of Codable), so they're safe to be
Sendable.Testing
pnpm lint- no errorsGatewayModels.swiftincludesSendableconformanceAI Disclosure 🤖
This fix was discovered while setting up clawdbot on a fresh machine and attempting to build the macOS app from source.