Telegram: keep DM topic replies in the originating thread#18586
Merged
sebslight merged 1 commit intoopenclaw:mainfrom Feb 16, 2026
Merged
Telegram: keep DM topic replies in the originating thread#18586sebslight merged 1 commit intoopenclaw:mainfrom
sebslight merged 1 commit intoopenclaw:mainfrom
Conversation
sebslight
added a commit
that referenced
this pull request
Feb 16, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 5134983 Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Reviewed-by: @sebslight
5 tasks
Closed
6 tasks
archerhpagent
pushed a commit
to howardpark/openclaw
that referenced
this pull request
Feb 18, 2026
archerhpagent
pushed a commit
to howardpark/openclaw
that referenced
this pull request
Feb 18, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 5134983 Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Reviewed-by: @sebslight
jun-planfit
pushed a commit
to planfit/openclaw
that referenced
this pull request
Feb 19, 2026
6 tasks
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 1, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 5134983 Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Reviewed-by: @sebslight (cherry picked from commit 0f6b39e)
hughdidit
pushed a commit
to hughdidit/DAISy-Agency
that referenced
this pull request
Mar 3, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 5134983 Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Reviewed-by: @sebslight (cherry picked from commit 0f6b39e)
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
Merged via /review-pr -> /prepare-pr -> /merge-pr. Prepared head SHA: 5134983 Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Co-authored-by: sebslight <19554889+sebslight@users.noreply.github.com> Reviewed-by: @sebslight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_thread_idfor DM-scoped Telegram threads inbuildTelegramThreadParamsthread_id=1still omitted for forum sends)Regression coverage
src/telegram/bot/helpers.test.tssrc/telegram/bot/delivery.test.tssrc/telegram/draft-stream.test.tsValidation
pnpm test -- src/telegramGreptile Summary
This PR fixes Telegram DM topic thread routing by including
message_thread_idin API calls for DM-scoped threads. Previously,buildTelegramThreadParamsunconditionally dropped thread IDs for DM scope because Telegram private chats historically didn't support topics. Telegram now supports "Topics in Private Chats," so the helper is updated to includemessage_thread_idwhen the normalized thread ID is positive, while still omitting non-positive values (0, negative) as invalid.buildTelegramThreadParamsnow returns{ message_thread_id: normalized }for DM threads with positive IDs, instead of always returningundefined1is correctly included (unlike forum scope where1is the General topic and must be skipped)Confidence Score: 5/5
buildTelegramThreadParams) with a clear behavioral rationale (Telegram now supports DM topics). The implementation correctly handles edge cases (non-positive IDs, truncation), maintains forum behavior (General topic id=1 still omitted), and all three test files are updated to cover the new behavior. No new dependencies, no architectural changes, and the diff is minimal.Last reviewed commit: fd055a0