fix(slack): replace files.uploadV2 with 3-step upload flow to fix missing_scope error by fif911 · Pull Request #17558 · openclaw/openclaw

fif911 · 2026-02-15T22:18:25Z

Problem

uploadSlackFile() uses client.files.uploadV2() from @slack/web-api, which internally calls the deprecated files.upload endpoint. This fails with missing_scope even when files:write is correctly granted in the bot token scopes.

The direct REST API (files.getUploadURLExternal → upload → files.completeUploadExternal) works fine with the same token, confirming the scope is present but the SDK method uses a different code path.

Fix

Replace the single files.uploadV2() call with Slack's recommended 3-step upload flow:

files.getUploadURLExternal — get presigned upload URL + file_id
fetch(upload_url) — upload file content to presigned URL
files.completeUploadExternal — finalize & share to channel/thread

Changes

1 file changed: src/slack/send.ts
Only the uploadSlackFile() function body is modified
Function signature unchanged
All existing behavior preserved (channel uploads, thread replies via thread_ts, captions via initial_comment)
Removed unused FilesUploadV2Arguments type import

Testing

Manually verified the 3-step flow works correctly:

✅ Channel upload (file shared to channel with caption)
✅ Thread reply upload (file shared in thread with thread_ts)
✅ Same bot token, same files:write scope — no more missing_scope error

Greptile Summary

This PR replaces the broken files.uploadV2() SDK call in uploadSlackFile() with Slack's recommended 3-step upload flow: getUploadURLExternal → presigned URL POST → completeUploadExternal. The change fixes missing_scope errors that occurred because files.uploadV2 internally uses the deprecated files.upload endpoint.

The implementation is clean and well-structured with explicit error handling at each step
Function signature and all existing behavior (channel uploads, thread replies via thread_ts, captions via initial_comment) are preserved
The return value semantics remain the same — both old and new code return a Slack file ID, not a message timestamp. This is a pre-existing limitation where messageId in SlackSendResult won't be a valid Slack ts for file-only uploads (affecting downstream operations like reactions/edits), but this PR does not change that behavior
The unused FilesUploadV2Arguments import is correctly removed
CHANGELOG entry is accurate

Confidence Score: 4/5

This PR is safe to merge — it fixes a real Slack API compatibility issue with a well-structured replacement that preserves all existing behavior.
Score of 4 reflects that this is a focused, well-implemented fix for a known Slack SDK issue. The 3-step upload flow follows Slack's recommended approach, error handling is thorough, and existing behavior is preserved. Minor deduction because the Content-Type header is not forwarded to the presigned URL upload (style concern, not a functional bug).
No files require special attention. The change is isolated to the uploadSlackFile function body in src/slack/send.ts.

_{Last reviewed commit: 30ee226}

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/slack/send.ts

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-17T01:52:40Z

Additional Comments (1)

src/slack/send.ts
Missing Content-Type header on presigned URL upload
The contentType from loadWebMedia is extracted on line 181 (as _contentType) but not forwarded to the presigned URL upload. While Slack's presigned URL endpoint generally accepts raw bytes without a Content-Type header, setting it explicitly ensures the file's MIME type is correctly recorded server-side — especially for non-obvious file types. Consider passing it through:

  const uploadResp = await fetch(uploadUrlResp.upload_url, {
    method: "POST",
    headers: _contentType ? { "Content-Type": _contentType } : {},
    body: new Uint8Array(buffer) as BodyInit,
  });

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/slack/send.ts
Line: 199:202

Comment:
**Missing Content-Type header on presigned URL upload**
The `contentType` from `loadWebMedia` is extracted on line 181 (as `_contentType`) but not forwarded to the presigned URL upload. While Slack's presigned URL endpoint generally accepts raw bytes without a `Content-Type` header, setting it explicitly ensures the file's MIME type is correctly recorded server-side — especially for non-obvious file types. Consider passing it through:

```suggestion
  const uploadResp = await fetch(uploadUrlResp.upload_url, {
    method: "POST",
    headers: _contentType ? { "Content-Type": _contentType } : {},
    body: new Uint8Array(buffer) as BodyInit,
  });
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

fif911 · 2026-02-18T15:54:36Z

@steipete is there anything to fix here? this essentially fixes the file upload in Slack thread. Now the agent would fail to attach the file to the thread (only attaching into the channel and DMs will work without this fix)

files.uploadV2 from @slack/web-api internally calls the deprecated files.upload endpoint, which fails with missing_scope even when files:write is correctly granted in the bot token scopes. Replace with Slack's recommended 3-step upload flow: 1. files.getUploadURLExternal - get presigned URL + file_id 2. fetch(upload_url) - upload file content 3. files.completeUploadExternal - finalize & share to channel/thread This preserves all existing behavior including thread replies via thread_ts and caption via initial_comment.

…sing_scope error (openclaw#17558) Cherry-pick of upstream 2a409bb.

…sing_scope error (openclaw#17558) * fix(slack): replace files.uploadV2 with 3-step upload flow files.uploadV2 from @slack/web-api internally calls the deprecated files.upload endpoint, which fails with missing_scope even when files:write is correctly granted in the bot token scopes. Replace with Slack's recommended 3-step upload flow: 1. files.getUploadURLExternal - get presigned URL + file_id 2. fetch(upload_url) - upload file content 3. files.completeUploadExternal - finalize & share to channel/thread This preserves all existing behavior including thread replies via thread_ts and caption via initial_comment. * fix(slack): harden external upload flow and tests --------- Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

… fix missing_scope error (openclaw#17558)" This reverts commit 6951d92.

…sing_scope error (openclaw#17558) * fix(slack): replace files.uploadV2 with 3-step upload flow files.uploadV2 from @slack/web-api internally calls the deprecated files.upload endpoint, which fails with missing_scope even when files:write is correctly granted in the bot token scopes. Replace with Slack's recommended 3-step upload flow: 1. files.getUploadURLExternal - get presigned URL + file_id 2. fetch(upload_url) - upload file content 3. files.completeUploadExternal - finalize & share to channel/thread This preserves all existing behavior including thread replies via thread_ts and caption via initial_comment. * fix(slack): harden external upload flow and tests --------- Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…sing_scope error (openclaw#17558) Cherry-pick of upstream 2a409bb.

openclaw-barnacle bot added channel: slack Channel integration: slack size: S labels Feb 15, 2026

greptile-apps bot reviewed Feb 15, 2026

View reviewed changes

src/slack/send.ts Outdated Show resolved Hide resolved

steipete closed this Feb 16, 2026

steipete reopened this Feb 17, 2026

greptile-apps bot reviewed Feb 17, 2026

View reviewed changes

fif911 and others added 2 commits March 1, 2026 11:32

fix(slack): harden external upload flow and tests

3b80205

Takhoffman force-pushed the fix/slack-file-upload-missing-scope branch from 30ee226 to 3b80205 Compare March 1, 2026 17:37

Takhoffman merged commit 2a409bb into openclaw:main Mar 1, 2026
9 checks passed

Takhoffman mentioned this pull request Mar 1, 2026

fix(slack): add title param and channel resolution for file upload #8684

Closed

github-actions bot mentioned this pull request Mar 1, 2026

📡 Upstream Digest — 2026-03-01 18:22 UTC curtismercier/openclaw-mods#154

Open

vabole mentioned this pull request Mar 1, 2026

ops: decision needed for upstream sync (1 disputed files) vabole/openclaw#4

Merged

1 task

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 1, 2026

fix(slack): replace files.uploadV2 with 3-step upload flow to fix mis…

98013b9

…sing_scope error (openclaw#17558) Cherry-pick of upstream 2a409bb.

robertchang-ga pushed a commit to robertchang-ga/openclaw that referenced this pull request Mar 2, 2026

Revert "fix(slack): replace files.uploadV2 with 3-step upload flow to…

c78fa67

… fix missing_scope error (openclaw#17558)" This reverts commit 6951d92.

fif911 deleted the fix/slack-file-upload-missing-scope branch March 3, 2026 10:06

zooqueen added a commit to hanzoai/bot that referenced this pull request Mar 6, 2026

fix(slack): replace files.uploadV2 with 3-step upload flow to fix mis…

7d26485

…sing_scope error (openclaw#17558) Cherry-pick of upstream 2a409bb.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(slack): replace files.uploadV2 with 3-step upload flow to fix missing_scope error#17558

fix(slack): replace files.uploadV2 with 3-step upload flow to fix missing_scope error#17558
Takhoffman merged 2 commits intoopenclaw:mainfrom
fif911:fix/slack-file-upload-missing-scope

fif911 commented Feb 15, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot commented Feb 17, 2026

Uh oh!

fif911 commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

fif911 commented Feb 15, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Changes

Testing

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 17, 2026

Uh oh!

fif911 commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fif911 commented Feb 15, 2026 •

edited by greptile-apps bot

Loading