test(feishu): add regression for audio download resource type=file by Yaxuan42 · Pull Request #16311 · openclaw/openclaw

Yaxuan42 · 2026-02-14T16:30:59Z

Summary

Adds a regression test ensuring Feishu audio message resource downloads use type=file (Feishu API only supports type=image|file).

Context

The runtime logic already maps non-image message types to type=file, but we had no test coverage to prevent re-introducing type=audio (which causes HTTP 400 per Feishu docs).

Changes

Add downloadMessageResourceFeishu test suite in extensions/feishu/src/media.test.ts
- audio uses type=file
- image uses type=image

Fixes #8746

Test plan

npx vitest run extensions/feishu/src/media.test.ts
pnpm lint

Greptile Summary

Adds a test suite for downloadMessageResourceFeishu in the Feishu extension, with two test cases verifying that the function correctly forwards type=file for audio resources and type=image for image resources to the Feishu SDK.

The mock setup and test structure follow existing patterns in the file and are well-organized
The actual audio→file mapping that prevents Feishu/Lark: audio resource download uses unsupported type=audio (should use type=file) #8746 regressions lives in bot.ts (extractMediaFromMessage), not in downloadMessageResourceFeishu — the test validates parameter forwarding but doesn't cover the mapping logic itself
No runtime or type safety issues introduced

Confidence Score: 4/5

This PR is safe to merge — it only adds test code with no production changes.
Pure test addition with no production code changes. The tests are correct in what they verify (parameter forwarding), though the "audio uses type=file" test doesn't cover the actual mapping logic in bot.ts that prevents the Feishu/Lark: audio resource download uses unsupported type=audio (should use type=file) #8746 regression. No risk to existing behavior.
No files require special attention

_{Last reviewed commit: 05ca5a2}

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-17T00:39:56Z

extensions/feishu/src/media.test.ts

+  it("audio uses type=file", async () => {
+    const result = await downloadMessageResourceFeishu({
+      cfg: {} as any,
+      messageId: "om_audio_msg",
+      fileKey: "file_key_audio",
+      type: "file",
+    });
+
+    expect(messageResourceGetMock).toHaveBeenCalledWith({
+      path: { message_id: "om_audio_msg", file_key: "file_key_audio" },
+      params: { type: "file" },
+    });
+    expect(result.buffer).toBeInstanceOf(Buffer);
+  });


Test validates pass-through, not the actual mapping logic

This test passes type: "file" as input and asserts that type: "file" arrives at the mock — but downloadMessageResourceFeishu simply forwards whatever type it receives. The actual regression risk (audio → type=file mapping) lives in bot.ts:392:

const resourceType = messageType === "image" ? "image" : "file";

As-is, this test would still pass even if someone changed that mapping to type: "audio" in bot.ts, because the mapping is not exercised here. For a true regression test for #8746, consider testing the call site in bot.ts (e.g. extractMediaFromMessage) where messageType === "audio" is mapped to resourceType = "file", or at minimum rename the test to clarify it's verifying the function's parameter forwarding contract.

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/feishu/src/media.test.ts Line: 216:229 Comment: **Test validates pass-through, not the actual mapping logic** This test passes `type: "file"` as input and asserts that `type: "file"` arrives at the mock — but `downloadMessageResourceFeishu` simply forwards whatever `type` it receives. The actual regression risk (audio → `type=file` mapping) lives in `bot.ts:392`: ```ts const resourceType = messageType === "image" ? "image" : "file"; ``` As-is, this test would still pass even if someone changed that mapping to `type: "audio"` in `bot.ts`, because the mapping is not exercised here. For a true regression test for #8746, consider testing the call site in `bot.ts` (e.g. `extractMediaFromMessage`) where `messageType === "audio"` is mapped to `resourceType = "file"`, or at minimum rename the test to clarify it's verifying the function's parameter forwarding contract. How can I resolve this? If you propose a fix, please make it concise.

Fixed in e704739. Added call-site mapping coverage by extracting and testing toMessageResourceType (audio -> file, image -> image, others -> file), and renamed the downloader test to clarify it verifies parameter forwarding only.

openclaw-barnacle · 2026-02-22T04:14:09Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

Yaxuan42 · 2026-02-28T04:18:48Z

superseded by main behavior, re-opening as test-only follow-up

greptile-apps · 2026-02-28T04:24:15Z

Greptile Summary

Adds comprehensive regression test coverage for Feishu audio message downloads, ensuring they use type=file instead of type=audio (which causes HTTP 400). Successfully addresses previous review feedback by extracting the mapping logic into a testable toMessageResourceType function.

Extracted toMessageResourceType function from inline logic, making the audio→file mapping explicit and testable
Added unit tests in bot.test.ts covering all mapping cases (image→image, audio→file, other types→file)
Added integration tests in media.test.ts verifying parameter forwarding to Feishu API
Clear documentation explaining Feishu API constraint (supports only type=image|file)

Confidence Score: 5/5

Safe to merge - pure test addition with minimal refactoring, no production behavior changes
Score reflects comprehensive test coverage of the regression risk, clean extraction of mapping logic into a testable function, and clear documentation. The changes are additive (tests + refactoring existing inline logic), with no behavioral modifications to production code paths.
No files require special attention

_{Last reviewed commit: e704739}

…aw#8746) Feishu's messageResource.get API only supports type=image|file. Audio/video resources must use type=file, never type=audio. Add regression tests to prevent re-introduction of the unsupported type=audio parameter that causes HTTP 400 from the Feishu API. Fixes openclaw#8746 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- extract bot mapping helper toMessageResourceType and use it at messageResource call site\n- add unit tests for image/audio/video/file/sticker mapping\n- rename media test to clarify it validates parameter forwarding contract

Takhoffman · 2026-02-28T04:49:21Z

PR #16311 - test(feishu): add regression for audio download resource type=file (#16311)

Merged via squash.

Merge commit: 8beb048
Verified: pnpm build, pnpm check, pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts
Changes made:
CHANGELOG.md\n- extensions/feishu/src/bot.ts\n- extensions/feishu/src/bot.test.ts\n- extensions/feishu/src/media.test.ts
Why these changes were made:
Rebased onto current main and resolved changelog conflict after fix(feishu): insert document blocks sequentially to preserve order (#26022) #26172 merge.\n- Added changelog entry required by merge policy.\n- Preserved and validated audio/file resource-type regression coverage at the call site.
Changelog: CHANGELOG.md updated=true required=true opt_out=false

Thanks @Yaxuan42!

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit e72df63)

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit e72df63)

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit e72df63)

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 8beb048) # Conflicts: # CHANGELOG.md # extensions/feishu/src/bot.test.ts

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 8beb048) # Conflicts: # CHANGELOG.md # extensions/feishu/src/bot.test.ts

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

@Yaxuan42

…penclaw#16311) thanks @Yaxuan42 Verified: - pnpm build - pnpm check - pnpm vitest run --config vitest.extensions.config.ts extensions/feishu/src/bot.test.ts extensions/feishu/src/media.test.ts Co-authored-by: Yaxuan42 <184813557+Yaxuan42@users.noreply.github.com> Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: S labels Feb 14, 2026

thewilloftheshadow force-pushed the main branch from bfc1ccb to f92900f Compare February 15, 2026 18:46

steipete closed this Feb 16, 2026

steipete reopened this Feb 17, 2026

greptile-apps bot reviewed Feb 17, 2026

View reviewed changes

openclaw-barnacle bot added stale Marked as stale due to inactivity and removed stale Marked as stale due to inactivity labels Feb 22, 2026

Yaxuan42 closed this Feb 28, 2026

Takhoffman reopened this Feb 28, 2026

Takhoffman force-pushed the fix/feishu-audio-download-type-file branch from e704739 to c73174d Compare February 28, 2026 04:46

Yaxuan42 and others added 3 commits February 27, 2026 22:48

test(feishu): cover audio->file mapping at call site

61e3714

- extract bot mapping helper toMessageResourceType and use it at messageResource call site\n- add unit tests for image/audio/video/file/sticker mapping\n- rename media test to clarify it validates parameter forwarding contract

Changelog: note feishu media resource regression tests

63c3715

Takhoffman force-pushed the fix/feishu-audio-download-type-file branch from c73174d to 63c3715 Compare February 28, 2026 04:49

Takhoffman merged commit 8beb048 into openclaw:main Feb 28, 2026
3 checks passed

Yaxuan42 deleted the fix/feishu-audio-download-type-file branch February 28, 2026 05:15

Takhoffman mentioned this pull request Feb 28, 2026

feat(feishu): comprehensive enhancements for Feishu channel #8975

Closed

github-actions bot mentioned this pull request Mar 1, 2026

cherry-pick: upstream bugfix commits (2026-03-01-0443) hughdidit/DAISy-Agency#140

Closed

6 tasks

gemini-code-assist bot mentioned this pull request Mar 1, 2026

chore(sync): replay rollup fixes on upstream/main MillionthOdin16/openclaw#111

Merged

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: Feishu adapter — community PRs and fixes remoteclaw/remoteclaw#678

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(feishu): add regression for audio download resource type=file#16311

test(feishu): add regression for audio download resource type=file#16311
Takhoffman merged 3 commits intoopenclaw:mainfrom
Yaxuan42:fix/feishu-audio-download-type-file

Yaxuan42 commented Feb 14, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 17, 2026

Uh oh!

Yaxuan42 Feb 24, 2026

Uh oh!

openclaw-barnacle bot commented Feb 22, 2026

Uh oh!

Yaxuan42 commented Feb 28, 2026

Uh oh!

greptile-apps bot commented Feb 28, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Yaxuan42 commented Feb 14, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Context

Changes

Test plan

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Yaxuan42 Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

openclaw-barnacle bot commented Feb 22, 2026

Uh oh!

Yaxuan42 commented Feb 28, 2026

Uh oh!

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Yaxuan42 commented Feb 14, 2026 •

edited by greptile-apps bot

Loading