Skip to content

Channels: add per-group tool policies#1557

Merged
steipete merged 2 commits into
openclaw:mainfrom
adam91holt:issue-1546-group-tools
Jan 24, 2026
Merged

Channels: add per-group tool policies#1557
steipete merged 2 commits into
openclaw:mainfrom
adam91holt:issue-1546-group-tools

Conversation

@adam91holt

Copy link
Copy Markdown
Contributor

Summary

  • add per-group tool allow/deny policies across built-in + plugin channels
  • wire group context through live and queued agent runs
  • extend config schemas/types and add coverage for group tool resolution

Testing

  • pnpm test -- src/agents/pi-tools-agent-config.test.ts

Closes #1546.

@steipete steipete self-assigned this Jan 24, 2026
@steipete

Copy link
Copy Markdown
Contributor

Thanks Adam! This one... I'd love if you could use /review on it, it's a bit loose and this is security relateed

  • High — Group tool policy not applied to subagents. resolveGroupToolPolicy only uses sessionKey or explicit group fields; subagent session keys drop group context, so per-group allow/deny won’t restrict subagent tools spawned from group chats. refs src/ agents/pi-tools.policy.ts:158, src/agents/tools/sessions-spawn-tool.ts:155
  • Medium — Compaction/system runs still omit group context when building tool lists, so group policy can be skipped there. refs src/ agents/pi-embedded-runner/compact.ts:201, src/agents/pi-tools.policy.ts:158

(taking over)

@steipete steipete force-pushed the issue-1546-group-tools branch from f01b279 to 6f26928 Compare January 24, 2026 05:49
@steipete steipete merged commit 9d98e55 into openclaw:main Jan 24, 2026
19 of 22 checks passed
@steipete

Copy link
Copy Markdown
Contributor

Landed via temp rebase onto main.

  • Gate: pnpm lint && pnpm build && pnpm test
  • Land commit: 6f26928
  • Merge commit: 9d98e55

Thanks @adam91holt!

lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
guillaumemaka pushed a commit to guillaumemaka/openclaw that referenced this pull request May 28, 2026
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Per-group tool policies

2 participants