fix(slack): download all files in multi-image messages by CommanderCrowCode · Pull Request #15447 · openclaw/openclaw

CommanderCrowCode · 2026-02-13T13:14:57Z

Summary

resolveSlackMedia() now collects all successfully downloaded files into an array instead of returning after the first one
prepareSlackMessage() populates MediaPaths, MediaUrls, and MediaTypes arrays, matching the pattern used by Telegram, Line, Discord, and iMessage adapters
Backward compatible: single-image messages produce an array of length 1, and singular MediaPath/MediaType/MediaUrl fields are still populated from the first element

Problem

When a Slack user sends multiple images in a single message, only the first image is downloaded and processed. The resolveSlackMedia() function returns immediately after the first successful file download (return { path, contentType, placeholder }), discarding all subsequent files.

This is particularly impactful for use cases like nutrition logging where users photograph multiple dishes in one message.

Fixes #11892, #7536

Changes

`src/slack/monitor/media.ts`

Changed resolveSlackMedia() return type from Promise<{path, contentType, placeholder} | null> to Promise<SlackMediaResult[] | null>
The loop now pushes each result to an array instead of returning early
Added exported SlackMediaResult type

`src/slack/monitor/message-handler/prepare.ts`

rawBody placeholder: joins all file placeholders with spaces
effectiveMedia context fields: MediaPath/MediaType/MediaUrl use first element; new MediaPaths/MediaUrls/MediaTypes arrays carry all elements
Thread starter media log message updated for array format

`src/slack/monitor/media.test.ts`

Added assertion that error-fallback test returns array of length 1
Added new test: "returns all successfully downloaded files as an array" — verifies both files are returned with correct paths and placeholders

Test plan

Existing resolveSlackMedia tests pass with updated assertions
New multi-file test verifies both files are returned
Single-image Slack messages continue to work (array of 1)
Multi-image Slack messages now process all images
MediaPath singular field still populated (backward compat)

🤖 Generated with Claude Code

Greptile Overview

Greptile Summary

This PR updates Slack inbound media handling to support multi-file messages: resolveSlackMedia() now downloads all successfully fetched attachments and returns them as an array, and prepareSlackMessage() populates both legacy single-value media fields and new MediaPaths/MediaUrls/MediaTypes arrays.

Main issue to address before merge: MediaTypes is currently derived with a filter(Boolean) which can shrink the array and break index alignment with MediaPaths/MediaUrls. Several downstream components treat these arrays as index-correlated (or require equal lengths), so this can cause MIME hints to be dropped or misapplied for multi-attachment messages.

Confidence Score: 4/5

Mostly safe to merge, but fix MediaTypes index alignment for multi-attachment messages first.
Core change (returning an array from resolveSlackMedia and plumbing MediaPaths/Urls/Types) is straightforward and test-covered. The remaining issue is a concrete data-shape bug: filtering falsy MediaTypes values can desync arrays and break downstream assumptions about attachment indexing.
src/slack/monitor/message-handler/prepare.ts

_{Last reviewed commit: ddfb393}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

greptile-apps

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-13T13:19:06Z

src/slack/monitor/message-handler/prepare.ts

+    MediaTypes:
+      effectiveMedia && effectiveMedia.length > 0
+        ? (effectiveMedia.map((m) => m.contentType).filter(Boolean) as string[])
+        : undefined,


Misaligned MediaTypes array

MediaTypes is built with effectiveMedia.map((m) => m.contentType).filter(Boolean), which can shorten the array compared to MediaPaths/MediaUrls when any attachment lacks a contentType. Downstream code treats these arrays as index-aligned (and in some places requires equal lengths), so this drops MIME hints for multi-attachment messages and can mis-associate types. Prefer keeping MediaTypes the same length/order as MediaPaths (e.g., preserve undefined entries) so indices remain consistent.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/slack/monitor/message-handler/prepare.ts Line: 615:618 Comment: **Misaligned MediaTypes array** `MediaTypes` is built with `effectiveMedia.map((m) => m.contentType).filter(Boolean)`, which can shorten the array compared to `MediaPaths`/`MediaUrls` when any attachment lacks a `contentType`. Downstream code treats these arrays as index-aligned (and in some places requires equal lengths), so this drops MIME hints for multi-attachment messages and can mis-associate types. Prefer keeping `MediaTypes` the same length/order as `MediaPaths` (e.g., preserve `undefined` entries) so indices remain consistent. How can I resolve this? If you propose a fix, please make it concise.

@CommanderCrowCode

@CommanderCrowCode)

resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…Urls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@CommanderCrowCode

@CommanderCrowCode)

steipete · 2026-02-14T13:17:53Z

Merged via squash.

Merge commit: c76288b

Thanks @CommanderCrowCode!

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com>

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com> (cherry picked from commit c76288b) # Conflicts: # src/slack/monitor/media.test.ts # src/slack/monitor/media.ts

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Peter Steinberger <steipete@gmail.com> (cherry picked from commit c76288b) # Conflicts: # extensions/feishu/package.json # scripts/write-plugin-sdk-entry-dts.ts # src/slack/monitor/media.test.ts # src/slack/monitor/media.ts # src/slack/monitor/message-handler/prepare.ts

@CommanderCrowCode

* fix(slack): download all files in multi-image messages resolveSlackMedia() previously returned after downloading the first file, causing multi-image Slack messages to lose all but the first attachment. This changes the function to collect all successfully downloaded files into an array, matching the pattern already used by Telegram, Line, Discord, and iMessage adapters. The prepare handler now populates MediaPaths, MediaUrls, and MediaTypes arrays so downstream media processing (vision, sandbox staging, media notes) works correctly with multiple attachments. Fixes openclaw#11892, openclaw#7536 * fix(slack): preserve MediaTypes index alignment with MediaPaths/MediaUrls The filter(Boolean) on MediaTypes removed entries with undefined contentType, shrinking the array and breaking index correlation with MediaPaths and MediaUrls. Downstream code (media-note.ts, attachments.ts) requires these arrays to have equal lengths for correct per-attachment MIME type lookup. Replace filter(Boolean) with a nullish coalescing fallback to "application/octet-stream". * fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks @CommanderCrowCode) * fix: unblock plugin-sdk account-id typing (openclaw#15447) --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>

openclaw-barnacle bot added channel: slack Channel integration: slack size: S labels Feb 13, 2026

greptile-apps bot reviewed Feb 13, 2026

View reviewed changes

steipete self-assigned this Feb 14, 2026

steipete force-pushed the fix/slack-multi-image-media branch from e99a2ac to d433773 Compare February 14, 2026 12:47

steipete added a commit to CommanderCrowCode/openclaw that referenced this pull request Feb 14, 2026

fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks

d433773

@CommanderCrowCode)

CommanderCrowCode and others added 4 commits February 14, 2026 13:47

fix(slack): align MediaType fallback and tests (openclaw#15447) (thanks

2b0de5d

@CommanderCrowCode)

fix: unblock plugin-sdk account-id typing (openclaw#15447)

da64c9e

steipete force-pushed the fix/slack-multi-image-media branch from d433773 to da64c9e Compare February 14, 2026 13:06

openclaw-barnacle bot added scripts Repository scripts channel: feishu Channel integration: feishu labels Feb 14, 2026

Merge remote-tracking branch 'upstream/main' into pr-15447-merge

ac0a42c

steipete merged commit c76288b into openclaw:main Feb 14, 2026
13 checks passed

github-actions bot mentioned this pull request Feb 14, 2026

📡 Upstream Digest — 2026-02-14 14:20 UTC curtismercier/openclaw-mods#23

Open

nickytonline mentioned this pull request Feb 14, 2026

nickytonline/trusted auth docs update nickytonline/openclaw#1

Closed

mcaxtr mentioned this pull request Feb 14, 2026

fix(slack): resolve all file attachments instead of only the first #10685

Closed

3 tasks

steipete mentioned this pull request Feb 23, 2026

Slack: only first file processed when multiple files attached #7536

Closed

msvechla mentioned this pull request Feb 23, 2026

[Feature]: Include file attachments from Slack thread history messages #24681

Closed

This was referenced Mar 1, 2026

cherry-pick: upstream deps/security commits (2026-03-01-0443) hughdidit/DAISy-Agency#138

Closed

cherry-pick: upstream deps/security commits (2026-03-02-2346) hughdidit/DAISy-Agency#144

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(slack): download all files in multi-image messages#15447

fix(slack): download all files in multi-image messages#15447
steipete merged 5 commits intoopenclaw:mainfrom
CommanderCrowCode:fix/slack-multi-image-media

CommanderCrowCode commented Feb 13, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 13, 2026

Uh oh!

Uh oh!

steipete commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

CommanderCrowCode commented Feb 13, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Changes

src/slack/monitor/media.ts

src/slack/monitor/message-handler/prepare.ts

src/slack/monitor/media.test.ts

Test plan

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

steipete commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CommanderCrowCode commented Feb 13, 2026 •

edited by greptile-apps bot

Loading

`src/slack/monitor/media.ts`

`src/slack/monitor/message-handler/prepare.ts`

`src/slack/monitor/media.test.ts`