fix(logging): use Symbol.for for externalTransports to survive jiti module isolation by Yida-Dev · Pull Request #12475 · openclaw/openclaw

Yida-Dev · 2026-02-09T08:59:36Z

Summary

Plugins loaded via jiti get their own module cache, so the module-level externalTransports Set in logger.ts becomes a separate instance in the plugin context. Any transport registered by a plugin via registerLogTransport() is silently lost when buildLogger() iterates the main process's Set.

Root cause

Main process:   import logger.ts  ->  externalTransports = new Set() (A)
Plugin (jiti):  import logger.ts  ->  externalTransports = new Set() (B)

Plugin calls registerLogTransport(fn)  ->  adds to Set B
buildLogger() iterates Set A           ->  fn is missing

Fix

Store the Set on globalThis[Symbol.for("openclaw.logging.externalTransports")] so all module instances -- regardless of how they were loaded -- share the same collection.

This matches the pattern already established in:

src/infra/warning-filter.ts (Symbol.for("openclaw.warning-filter"))
src/plugins/runtime.ts (Symbol.for("openclaw.pluginRegistryState"))

Files changed

File	Change
`src/logging/logger.ts`	Replace `new Set()` with `globalThis[Symbol.for()]` getter
`src/logging/logger-transport.test.ts`	Verify shared Set and register/unregister lifecycle

Test plan

New test: externalTransports is stored on globalThis via Symbol.for
New test: registerLogTransport adds to and removes from the shared global Set
All 27 existing logging + diagnostics-otel tests pass

Greptile Overview

Greptile Summary

This PR changes src/logging/logger.ts to store the externalTransports Set on globalThis[Symbol.for("openclaw.logging.externalTransports")] so transports registered from jiti-loaded plugin module instances are visible to the main process logger builder.

It also adds src/logging/logger-transport.test.ts to validate that the Set is shared via Symbol.for and that registerLogTransport() mutates the shared Set (including unregister cleanup).

Confidence Score: 4/5

Mostly safe to merge, but the newly added tests are order-dependent and can fail in isolation/sharded runs.
The production change in logger.ts is small and follows established patterns (Symbol.for + globalThis). The only clear issues found are in the new test file, which assumes logger.js has already been executed and dereferences the global Set before ensuring initialization.
src/logging/logger-transport.test.ts

…odule isolation Plugins loaded via jiti get their own module cache, so the module-level `externalTransports` Set in logger.ts is a different instance in the plugin context than in the main process. Any transport registered by a plugin is silently lost when buildLogger() iterates the main Set. Store the Set on `globalThis[Symbol.for("openclaw.logging.externalTransports")]` so all module instances share the same collection, matching the pattern already used by warning-filter.ts and plugins/runtime.ts. Closes openclaw#12473 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

greptile-apps

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-09T09:00:39Z

+  it("externalTransports is stored on globalThis via Symbol.for", () => {
+    // Importing logger.ts should have populated the global key.
+    const g = globalThis as typeof globalThis & {
+      [key: symbol]: Set<LogTransport> | undefined;
+    };
+    expect(g[EXTERNAL_TRANSPORTS_KEY]).toBeInstanceOf(Set);


Order-dependent test setup

This test expects globalThis[Symbol.for(...)] to be populated by importing logger.ts, but this file only imports LogTransport as a type (erased at runtime), so ./logger.js may never run. That makes the assertion fail when this test runs in isolation or in a fresh worker. Consider doing a real await import("./logger.js") (or importing a runtime symbol) before reading g[EXTERNAL_TRANSPORTS_KEY] so initialization is deterministic.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/logging/logger-transport.test.ts Line: 7:12 Comment: **Order-dependent test setup** This test expects `globalThis[Symbol.for(...)]` to be populated by importing `logger.ts`, but this file only imports `LogTransport` as a type (erased at runtime), so `./logger.js` may never run. That makes the assertion fail when this test runs in isolation or in a fresh worker. Consider doing a real `await import("./logger.js")` (or importing a runtime symbol) before reading `g[EXTERNAL_TRANSPORTS_KEY]` so initialization is deterministic. How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-09T09:00:40Z

+    const g = globalThis as typeof globalThis & {
+      [key: symbol]: Set<LogTransport> | undefined;
+    };
+    const set = g[EXTERNAL_TRANSPORTS_KEY]!;
+    const sizeBefore = set.size;


Dereference before initialization

In this test, const set = g[EXTERNAL_TRANSPORTS_KEY]!; happens before importing ./logger.js, so set can be undefined and the non-null assertion will crash. Import ./logger.js first (or otherwise ensure initialization) before reading the global key, so the test doesn’t depend on previous tests/order.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/logging/logger-transport.test.ts Line: 18:22 Comment: **Dereference before initialization** In this test, `const set = g[EXTERNAL_TRANSPORTS_KEY]!;` happens *before* importing `./logger.js`, so `set` can be `undefined` and the non-null assertion will crash. Import `./logger.js` first (or otherwise ensure initialization) before reading the global key, so the test doesn’t depend on previous tests/order. How can I resolve this? If you propose a fix, please make it concise.

openclaw-barnacle · 2026-02-21T04:19:18Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

steipete · 2026-02-24T05:17:01Z

Closing as AI-assisted stale-fix triage.

Linked issue #12473 ("[Bug]: Plugin log transports lost due to module isolation in logging system") is currently CLOSED and was closed on 2026-02-13T15:11:52Z with state reason NOT_PLANNED.
Given that issue state, this fix PR is no longer needed in the active queue and is being closed as stale.

If the underlying bug is still reproducible on current main, please reopen this PR (or open a new focused fix PR) and reference both #12473 and #12475 for fast re-triage.

steipete · 2026-02-24T05:17:02Z

Closed after AI-assisted stale-fix triage (closed issue duplicate/stale fix).

The externalTransports Set in logger.ts is module-scoped, so plugin bundles that receive a separate copy of the module have their own isolated registry. registerLogTransport() from the OTel plugin may register on a different Set than the one the gateway logger reads. Fix: use globalThis.__openclawLogTransportState singleton, matching the pattern PR openclaw#12897 established for the diagnostic event bus. Related openclaw#12475

greptile-apps Bot reviewed Feb 9, 2026

View reviewed changes

leonnardo mentioned this pull request Feb 15, 2026

fix(diagnostics-otel): share listeners/transports across module bundles #16865

Closed

18 tasks

thewilloftheshadow force-pushed the main branch from bfc1ccb to f92900f Compare February 15, 2026 18:46

This was referenced Feb 17, 2026

fix(diagnostics): share event bus and log transport across module bundles triclambert/openclaw#1

Open

fix(diagnostics): share event bus and log transport across module bundles #20059

Closed

openclaw-barnacle Bot added the stale Marked as stale due to inactivity label Feb 21, 2026

dashed mentioned this pull request Feb 21, 2026

fix(plugins): add postinstall patch for ESM-only package exports dashed/openclaw#7

Open

3 tasks

openclaw-barnacle Bot removed the stale Marked as stale due to inactivity label Feb 23, 2026

steipete closed this Feb 24, 2026

sreis mentioned this pull request Feb 26, 2026

feat(diagnostics): trace context propagation + log transport isolation fix #27249

Closed

16 tasks

sreis mentioned this pull request Feb 26, 2026

feat(diagnostics): trace context propagation + log transport isolation fix #27675

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(logging): use Symbol.for for externalTransports to survive jiti module isolation#12475

fix(logging): use Symbol.for for externalTransports to survive jiti module isolation#12475
Yida-Dev wants to merge 1 commit intoopenclaw:mainfrom
Yida-Dev:fix/plugin-log-transport-module-isolation

Yida-Dev commented Feb 9, 2026 •

edited by greptile-apps Bot

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot Feb 9, 2026

Uh oh!

greptile-apps Bot Feb 9, 2026

Uh oh!

openclaw-barnacle Bot commented Feb 21, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Yida-Dev commented Feb 9, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Fix

Files changed

Test plan

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

openclaw-barnacle Bot commented Feb 21, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

steipete commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Yida-Dev commented Feb 9, 2026 •

edited by greptile-apps Bot

Loading