Tests: add unit tests for sessions/session-label.ts#11387
Closed
WeatherPal-AI wants to merge 1 commit intoopenclaw:mainfrom
Closed
Tests: add unit tests for sessions/session-label.ts#11387WeatherPal-AI wants to merge 1 commit intoopenclaw:mainfrom
WeatherPal-AI wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Add 13 tests for the session label parsing module: - Valid labels, whitespace trimming, special and unicode characters - Max length boundary (exact limit and exceeding) - Rejection of empty, whitespace-only, and non-string inputs (number, null, undefined, object) - Constant export verification
SutanuNandigrami
pushed a commit
to SutanuNandigrami/openclaw
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 13 tests for the session label parsing module:
Testing
pnpm vitest run src/sessions/session-label.test.tsGreptile Overview
Greptile Summary
This PR adds a new Vitest unit test file for
src/sessions/session-label.ts, covering success cases (valid labels, trimming, unicode/special characters), boundary behavior atSESSION_LABEL_MAX_LENGTH, and failure cases for empty/whitespace-only and non-string inputs. The tests align with the currentparseSessionLabelcontract (returning{ ok: true, label }or{ ok: false, error }) and don’t introduce changes to production logic.Confidence Score: 5/5
parseSessionLabel; the assertions match the current function outputs and don’t affect runtime code paths.