Fix #1056: prevent macOS FD exhaustion by ignoring node_modules in skills watcher#1074
Merged
steipete merged 1 commit intoopenclaw:mainfrom Jan 17, 2026
Conversation
On macOS, watching deep dependency trees can exhaust file descriptors and lead to spawn EBADF failures. The skills watcher only needs to observe skill changes, so ignore dotfiles, node_modules, and dist by default. Adds regression coverage.
Contributor
|
good one, thanks! |
steipete
added a commit
that referenced
this pull request
Jan 17, 2026
Contributor
|
Landed via temp rebase onto main.
Thanks @roshanasingh4! |
|
Hello, Thanks! |
dominicnunez
pushed a commit
to dominicnunez/openclaw
that referenced
this pull request
Feb 26, 2026
zooqueen
pushed a commit
to hanzoai/bot
that referenced
this pull request
Mar 6, 2026
…eavy-watch-paths Fix openclaw#1056: prevent macOS FD exhaustion by ignoring node_modules in skills watcher
dustin-olenslager
pushed a commit
to dustin-olenslager/ironclaw-supreme
that referenced
this pull request
Mar 24, 2026
Fato07
pushed a commit
to Fato07/elav
that referenced
this pull request
Mar 26, 2026
…k-document-crud feat(plugins): add document CRUD methods to Plugin SDK
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
…eavy-watch-paths Fix openclaw#1056: prevent macOS FD exhaustion by ignoring node_modules in skills watcher
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…eavy-watch-paths Fix openclaw#1056: prevent macOS FD exhaustion by ignoring node_modules in skills watcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1056.
Problem
chokidarcan hold huge numbers of file descriptors when asked to watch deep dependency trees (notablynode_modules).child_process.spawnto fail withspawn EBADF, breaking tool execution.Fix
ignoredpatterns to skip dotfiles (incl..git),node_modules, anddist.Tests
src/agents/skills/refresh.test.tsasserting the watcher is configured with the ignore patterns.