fix(feishu): Remove incorrect oc_ prefix assumption in resolveFeishuSession by Bermudarat · Pull Request #10407 · openclaw/openclaw

Bermudarat · 2026-02-06T13:20:00Z

Fix Feishu `oc_` prefix assumption causing DM misrouting

🐛 Problem

resolveFeishuSession incorrectly assumes all oc_ prefixed IDs are group chats. However, Feishu's oc_ is a generic chat_id that can represent both groups and DMs (p2p chats).

📊 Impact

DMs with oc_ chat_ids are misrouted as group sessions
Creates duplicate/incorrect session keys
Breaks session isolation between DMs and groups

🔍 Evidence

Verified with Feishu API queries:

Chat ID	Actual Type (from API)	Current Behavior	Expected
`oc_19dd...`	`chat_mode: "p2p"` (DM)	❌ Treated as group	✅ Treat as DM
`oc_724b...`	`chat_mode: "group"`	✅ Treated as group	✅ Treat as group

Root cause: The code incorrectly assumes ID prefix determines type, but Feishu uses the same oc_ prefix for both groups and DMs.

🛠 Solution

Before:

const idLower = trimmed.toLowerCase();
if (idLower.startsWith("oc_")) isGroup = true;  // ❌ Wrong assumption
else if (idLower.startsWith("ou_") || idLower.startsWith("on_")) isGroup = false;

After:

let typeExplicit = false;
// Track if type was explicitly specified via prefix
if (lower.startsWith("group:") || lower.startsWith("chat:")) {
    typeExplicit = true;
    isGroup = true;
} else if (lower.startsWith("user:") || lower.startsWith("dm:")) {
    typeExplicit = true;
    isGroup = false;
}

// Only infer type from ID prefix if not explicitly specified
// Note: oc_ is a chat_id and can be either group or DM
// Only ou_/on_ can be reliably identified as user IDs (always DM)
if (!typeExplicit) {
    if (idLower.startsWith("ou_") || idLower.startsWith("on_")) {
        isGroup = false;
    }
    // oc_ requires explicit prefix: dm:oc_xxx or group:oc_xxx
}

Key changes:

✅ Add typeExplicit flag to track explicit type specification
✅ Remove incorrect oc_ → group assumption
✅ Keep ou_/on_ → DM inference (these are user IDs, always DM)
✅ oc_ IDs now require explicit dm: or group: prefix

✅ Testing

Tested with real Feishu environment:

DM with oc_ chat_id correctly routes to DM session
Group with oc_ chat_id correctly routes to group session
Explicit prefixes (dm:oc_xxx, group:oc_xxx) work correctly
User IDs (ou_, on_) still infer as DM
No regression on existing group chats

📚 Context

Feishu's ID format:

oc_: chat_id (generic, can be group or DM - needs chat_mode to distinguish)
ou_: user open_id (always DM)
on_: user union_id (always DM)

The correct approach is to either:

Use chat_mode field from Feishu API response (for incoming messages) ✅
Require explicit type prefix for outgoing messages (dm: or group:) ✅

This PR implements approach #2 for resolveFeishuSession (outbound routing).

⚠️ Limitation

Bare oc_ without an explicit prefix now defaults to DM (isGroup=false).
This is a safer default than the previous behavior (always group), as
misrouting a group message to a DM session has a smaller blast radius
than the reverse — a DM session leaking into a group context is a worse
outcome from both a privacy and UX perspective.

For outbound routing (e.g. message tool, cron delivery), callers should
use explicit prefixes: group:oc_xxx or dm:oc_xxx.

🔮 Future improvement

Auto-detection of oc_ chat type (e.g. via session store lookup or
Feishu Chat API query) could eliminate the need for explicit prefixes
entirely. This is out of scope for this fix but tracked in #12658.

🔗 Related

Feishu Open Platform Docs: https://open.feishu.cn/document/home/user-identity-introduction/introduction
Follow-up: feat(feishu): Auto-detect oc_ chat type for outbound routing #12658 (auto-detect oc_ chat type)

First-time contributor here! 👋 Found this bug while using OpenClaw's Feishu integration and verified with API calls. Happy to make any adjustments based on feedback.

Greptile Overview

Greptile Summary

Updates Feishu outbound target parsing to stop assuming all oc_ IDs are group chats.
Adds a typeExplicit flag so group:/chat: vs dm:/user: prefixes take precedence over ID-prefix heuristics.
Keeps ou_/on_ inference as DM-only when no explicit type is provided, avoiding DM/group session key collisions for Feishu chat_ids.

Confidence Score: 4/5

This PR is largely safe to merge, with one documentation inconsistency to fix.
The logic change is small and localized to Feishu outbound session resolution, and it removes an incorrect inference that caused real misrouting. The main remaining issue is that the in-file Feishu ID format comment contradicts the new behavior and Feishu semantics, which can cause future regressions if left uncorrected.
src/infra/outbound/outbound-session.ts

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

greptile-apps

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-06T13:21:21Z

Additional Comments (1)

src/infra/outbound/outbound-session.ts
Incorrect Feishu ID docs

The comment block above resolveFeishuSession still states oc_xxx is a group chat ID, but this PR’s behavior (and Feishu’s API) treats oc_ as a generic chat_id that can be either group or p2p. This mismatch will mislead future changes and reviewers. Update the comment to reflect that oc_ can be DM or group (and requires explicit prefix / API chat_mode to disambiguate).

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/infra/outbound/outbound-session.ts
Line: 819:825

Comment:
**Incorrect Feishu ID docs**

The comment block above `resolveFeishuSession` still states `oc_xxx` is a group chat ID, but this PR’s behavior (and Feishu’s API) treats `oc_` as a generic `chat_id` that can be either group or p2p. This mismatch will mislead future changes and reviewers. Update the comment to reflect that `oc_` can be DM or group (and requires explicit prefix / API `chat_mode` to disambiguate).

How can I resolve this? If you propose a fix, please make it concise.

rheros · 2026-02-09T02:07:13Z

when will this merge complete

Bermudarat · 2026-02-09T03:20:10Z

Hi @joshp123, this PR fixes a bug in the resolveFeishuSession logic introduced in #7313 — the oc_ prefix was assumed to always be a group chat, but Feishu's oc_ is a generic chat_id that can also be a p2p DM (verified via API). This caused DM messages to be misrouted as group sessions.

It's a small, localized fix (one file) and has been approved. The CI failure (macOS swiftlint) is unrelated. Would love your review since you handled the original Feishu integration. Thanks! 🙏

openclaw-barnacle · 2026-02-21T04:32:17Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

…ession - Feishu oc_ is a generic chat_id that can represent both groups and DMs - Must use chat_mode field from API to distinguish, not ID prefix - Only ou_/on_ prefixes reliably indicate user IDs (always DM) - Fixes session misrouting for DMs with oc_ chat IDs This bug caused DM messages with oc_ chat_ids to be incorrectly created as group sessions, breaking session isolation and routing.

The previous comment incorrectly stated oc_ is always a group chat. This update clarifies that oc_ chat_ids can be either groups or DMs, and explicit prefixes (dm:/group:) should be used to distinguish.

Takhoffman · 2026-02-28T04:16:30Z

Autoland follow-up:

Rebasing and conflict resolution completed.
Added outbound routing regression coverage for Feishu oc_ session handling.
Verified with: pnpm test src/infra/outbound/outbound.test.ts.

Merged in #10407 via commit 6a8d83b.

…ession (openclaw#10407) * fix(feishu): remove incorrect oc_ prefix assumption in resolveFeishuSession - Feishu oc_ is a generic chat_id that can represent both groups and DMs - Must use chat_mode field from API to distinguish, not ID prefix - Only ou_/on_ prefixes reliably indicate user IDs (always DM) - Fixes session misrouting for DMs with oc_ chat IDs This bug caused DM messages with oc_ chat_ids to be incorrectly created as group sessions, breaking session isolation and routing. * docs: update Feishu ID format comment to reflect oc_ ambiguity The previous comment incorrectly stated oc_ is always a group chat. This update clarifies that oc_ chat_ids can be either groups or DMs, and explicit prefixes (dm:/group:) should be used to distinguish. * feishu: add regression coverage for oc session routing --------- Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

…ession (openclaw#10407) * fix(feishu): remove incorrect oc_ prefix assumption in resolveFeishuSession - Feishu oc_ is a generic chat_id that can represent both groups and DMs - Must use chat_mode field from API to distinguish, not ID prefix - Only ou_/on_ prefixes reliably indicate user IDs (always DM) - Fixes session misrouting for DMs with oc_ chat IDs This bug caused DM messages with oc_ chat_ids to be incorrectly created as group sessions, breaking session isolation and routing. * docs: update Feishu ID format comment to reflect oc_ ambiguity The previous comment incorrectly stated oc_ is always a group chat. This update clarifies that oc_ chat_ids can be either groups or DMs, and explicit prefixes (dm:/group:) should be used to distinguish. * feishu: add regression coverage for oc session routing --------- Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> (cherry picked from commit 1274b6f)

…ession (openclaw#10407) * fix(feishu): remove incorrect oc_ prefix assumption in resolveFeishuSession - Feishu oc_ is a generic chat_id that can represent both groups and DMs - Must use chat_mode field from API to distinguish, not ID prefix - Only ou_/on_ prefixes reliably indicate user IDs (always DM) - Fixes session misrouting for DMs with oc_ chat IDs This bug caused DM messages with oc_ chat_ids to be incorrectly created as group sessions, breaking session isolation and routing. * docs: update Feishu ID format comment to reflect oc_ ambiguity The previous comment incorrectly stated oc_ is always a group chat. This update clarifies that oc_ chat_ids can be either groups or DMs, and explicit prefixes (dm:/group:) should be used to distinguish. * feishu: add regression coverage for oc session routing --------- Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>

greptile-apps bot reviewed Feb 6, 2026

View reviewed changes

realmikewestfall304-wq approved these changes Feb 6, 2026

View reviewed changes

Bermudarat force-pushed the fix/feishu-oc-prefix-bug branch from 2bfba0f to 42a814f Compare February 9, 2026 03:46

Bermudarat mentioned this pull request Feb 9, 2026

feat(feishu): Auto-detect oc_ chat type for outbound routing #12658

Closed

thewilloftheshadow force-pushed the main branch from bfc1ccb to f92900f Compare February 15, 2026 18:46

openclaw-barnacle bot added stale Marked as stale due to inactivity size: S and removed stale Marked as stale due to inactivity labels Feb 21, 2026

Bermudarat and others added 3 commits February 27, 2026 22:13

docs: update Feishu ID format comment to reflect oc_ ambiguity

69a3ef1

The previous comment incorrectly stated oc_ is always a group chat. This update clarifies that oc_ chat_ids can be either groups or DMs, and explicit prefixes (dm:/group:) should be used to distinguish.

feishu: add regression coverage for oc session routing

c6b8cd2

Takhoffman force-pushed the fix/feishu-oc-prefix-bug branch from a6d8952 to c6b8cd2 Compare February 28, 2026 04:16

Takhoffman merged commit 6a8d83b into openclaw:main Feb 28, 2026
2 checks passed

github-actions bot mentioned this pull request Feb 28, 2026

📡 Upstream Digest — 2026-02-28 04:49 UTC curtismercier/openclaw-mods#142

Open

greptile-apps bot mentioned this pull request Mar 1, 2026

[AI-assisted] fix(feishu): cron announce delivery fails to recognize oc_ group chat IDs #30661

Closed

3 tasks

gemini-code-assist bot mentioned this pull request Mar 1, 2026

chore(sync): replay rollup fixes on upstream/main MillionthOdin16/openclaw#111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(feishu): Remove incorrect oc_ prefix assumption in resolveFeishuSession#10407

fix(feishu): Remove incorrect oc_ prefix assumption in resolveFeishuSession#10407
Takhoffman merged 3 commits intoopenclaw:mainfrom
Bermudarat:fix/feishu-oc-prefix-bug

Bermudarat commented Feb 6, 2026 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot commented Feb 6, 2026

Uh oh!

rheros commented Feb 9, 2026

Uh oh!

Bermudarat commented Feb 9, 2026

Uh oh!

openclaw-barnacle bot commented Feb 21, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Bermudarat commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix Feishu oc_ prefix assumption causing DM misrouting

🐛 Problem

📊 Impact

🔍 Evidence

🛠 Solution

✅ Testing

📚 Context

⚠️ Limitation

🔮 Future improvement

🔗 Related

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 6, 2026

Uh oh!

rheros commented Feb 9, 2026

Uh oh!

Bermudarat commented Feb 9, 2026

Uh oh!

openclaw-barnacle bot commented Feb 21, 2026

Uh oh!

Uh oh!

Takhoffman commented Feb 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bermudarat commented Feb 6, 2026 •

edited

Loading

Fix Feishu `oc_` prefix assumption causing DM misrouting