fix(keyring): persist OAuth tokens across Homebrew upgrades#94
Merged
steipete merged 2 commits intoopenclaw:mainfrom Jan 21, 2026
Merged
Conversation
Disable KeychainTrustApplication to prevent macOS Keychain from tying access control to the specific binary hash. This allows tokens to survive across Homebrew upgrades where the binary hash changes. Users may see a one-time keychain access prompt after upgrade. Fixes openclaw#86 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9cc14c7 to
713c52a
Compare
Collaborator
|
Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test\n- Land commit: 713c52a\n- Merge commit: 259eba8\n\nThanks @salmonumbrella! |
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
…rsistence fix(keyring): persist OAuth tokens across Homebrew upgrades
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeychainTrustApplicationto prevent macOS Keychain from tying access control to the specific binary hashRoot Cause
When
KeychainTrustApplication: true, macOS Keychain ties ACLs to the binary hash. Eachbrew upgradeinstalls a new binary with a different hash, causing the new binary to lose access to existing keychain items.Test Plan
gog auth liststill worksFixes #86
🤖 Generated with Claude Code