Skip to content

fix: code quality improvements#91

Merged
steipete merged 2 commits intoopenclaw:mainfrom
salmonumbrella:fix/code-quality-improvements
Jan 21, 2026
Merged

fix: code quality improvements#91
steipete merged 2 commits intoopenclaw:mainfrom
salmonumbrella:fix/code-quality-improvements

Conversation

@salmonumbrella
Copy link
Copy Markdown
Contributor

Code Quality Fixes

  • Fixed Printf newline inconsistency: Removed redundant \n from Printf calls (UI library auto-appends newlines)
  • Added context propagation to Chat API: All Chat API calls now use .Context(ctx) for proper cancellation support
  • Extracted chat magic strings to constants: Created chat_types.go with spaceType*, userType*, and messageReplyOption* constants

Test Plan

  • All tests pass (go test ./...)
  • Build succeeds (go build ./...)

@steipete
Copy link
Copy Markdown
Collaborator

Thank you!

salmonumbrella and others added 2 commits January 21, 2026 07:34
The UI library's Printf auto-appends newlines. Remove redundant \n from
all Printf calls to prevent double newlines in output.

Files fixed:
- calendar_propose_time.go
- calendar_team.go
- calendar_users.go
- chat_dm.go
- gmail_thread.go
- groups.go

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@steipete steipete force-pushed the fix/code-quality-improvements branch from e49884f to 99204c6 Compare January 21, 2026 07:35
@steipete steipete merged commit 8a4e1fc into openclaw:main Jan 21, 2026
4 checks passed
@steipete
Copy link
Copy Markdown
Collaborator

Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test\n- Land commit: 99204c6\n- Merge commit: 8a4e1fc\n\nThanks @salmonumbrella!

klodr pushed a commit to klodr/gogcli that referenced this pull request Apr 22, 2026
klodr pushed a commit to klodr/gogcli that referenced this pull request Apr 22, 2026
…mprovements

fix: code quality improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants