fix(completion): enable shell completions in release builds#77
Merged
steipete merged 2 commits intoopenclaw:mainfrom Jan 17, 2026
Merged
fix(completion): enable shell completions in release builds#77steipete merged 2 commits intoopenclaw:mainfrom
steipete merged 2 commits intoopenclaw:mainfrom
Conversation
Implements working shell completions for bash, zsh, fish, and PowerShell. Changes: - Add CompletionInternalCmd for kong's __complete helper - Refactor completion generation to use kong's built-in support - Extract newParser() for reuse in completion generation - Add baseDescription() to avoid duplication The completion command now generates valid scripts that work when eval'd in the user's shell configuration. Fixes openclaw#65 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
a45eba9 to
410ea2f
Compare
Collaborator
|
Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test (skipped: no package.json), make lint, make test\n- Land commit: 410ea2f\n- Merge commit: c550930\n\nThanks @salmonumbrella! |
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
…ons-65 fix(completion): enable shell completions in release builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompletionInternalCmdfor kong's__completehelpernewParser()for reuse in completion generationChanges
completion.go: Refactored to generate proper shell scripts using kongcompletion_internal.go: New file implementing__completesubcommandroot.go: AddedCompletecommand, extractednewParser()andbaseDescription()Test Plan
go test ./...passesgog completion zshoutputs valid zsh completion scriptgog completion bashoutputs valid bash completion scriptgog completion fishoutputs valid fish completion scriptgog completion powershelloutputs valid PowerShell completion scriptFixes #65
🤖 Generated with Claude Code