feat(classroom): add tests, nil guards, and topic filter#73
Merged
steipete merged 4 commits intoopenclaw:mainfrom Jan 17, 2026
Merged
Conversation
a44330b to
24d2469
Compare
|
Can we have more test cases, so it covers all features |
Contributor
Author
|
Added a more comprehensive Classroom command test suite (JSON coverage, topic filters, validation errors). Thanks for the nudge on expanding coverage! |
- Add clickable account cards with pointer cursor - Add "Permissions" button on hover to trigger re-auth - Add /auth/upgrade endpoint with force-consent and login_hint - Add service icons for classroom, groups, docs, keep - Show all services on success page with missing ones greyed out Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add confirmDestructive() to leave command for consistency with other destructive operations - Add SYNC comments to shared CSS in HTML templates - Add tests for /auth/upgrade endpoint (success, missing email, creds error) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5483ee2 to
f5f33ca
Compare
Collaborator
|
Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test (fails: no package.json), make lint, make test\n- Land commit: f5f33ca\n- Merge commit: 8c95b56\n\nThanks @salmonumbrella! |
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
…ue-71-classroom feat(classroom): add tests, nil guards, and topic filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses code review feedback for issue #71 (Classroom API support):
profileEmail()helper for nil-safe email extraction--topicfilter for coursework and materials list commandsCloses #71
Test Plan
🤖 Generated with Claude Code