Fix/filter cancelled events#362
Merged
steipete merged 2 commits intoopenclaw:mainfrom Mar 7, 2026
Merged
Conversation
|
Love it. |
Contributor
|
Thanks. |
steipete
added a commit
that referenced
this pull request
Mar 7, 2026
Collaborator
|
Follow-up landed on main after the merge race: Thanks @sharukh010! |
steipete
added a commit
that referenced
this pull request
Mar 7, 2026
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
* fix: filter cancelled events from calendar list by default * fix(contacts): fix bool/string type mismatch in apply helpers.
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fix: Filter cancelled events from calendar list
gog calendar listwas returning cancelled events becauseShowDeletedwas not explicitly set in the API call.
Added
.ShowDeleted(false)tocalendarEventsListCall, ensuring theGoogle Calendar API filters out cancelled events before returning results.
2. Fix: Bool/string type mismatch in contacts (contacts_crud.go)
Variables
givenandorgwere incorrectly declared asboolbut areused as strings throughout the function (e.g. passed to
strings.TrimSpaceand contact name/org setters).
Changed declarations from
booltostringto match their actual usage.Fixes #358