fix(contacts): correct parameter type grouping in helper functions#333
Closed
0xStef wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(contacts): correct parameter type grouping in helper functions#3330xStef wants to merge 1 commit intoopenclaw:mainfrom
0xStef wants to merge 1 commit intoopenclaw:mainfrom
Conversation
`contactsApplyPersonName` and `contactsApplyPersonOrganization` had incorrect Go parameter type grouping where string parameters (`given`, `org`) were implicitly typed as `bool` due to sharing a type group with the preceding bool parameter. This caused a compilation error: cannot use given (variable of type bool) as string value in argument to strings.TrimSpace Introduced in 957603e.
4 tasks
0xStef
added a commit
to 0xStef/google-cli
that referenced
this pull request
Feb 24, 2026
Upstream steipete/gogcli:main has a compilation error introduced in 957603e where string parameters (given, org) were implicitly typed as bool due to Go parameter group sharing. Apply the same fix from PR openclaw#333 so this branch compiles standalone without depending on that PR landing.
b28da88 to
a16c335
Compare
Collaborator
|
Closing as duplicate of #355, which covers the same contacts_crud build fix with current tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contactsApplyPersonNameandcontactsApplyPersonOrganizationintroduced in 957603eTest plan